From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A01ECD3ABF4 for ; Mon, 11 Nov 2024 19:51:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12EC36B009D; Mon, 11 Nov 2024 14:51:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DF776B009E; Mon, 11 Nov 2024 14:51:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC1296B009F; Mon, 11 Nov 2024 14:51:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CD7C46B009D for ; Mon, 11 Nov 2024 14:51:54 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2705E81ABF for ; Mon, 11 Nov 2024 19:51:54 +0000 (UTC) X-FDA: 82774857648.13.82D7A1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 818D316001A for ; Mon, 11 Nov 2024 19:51:24 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eK9y85FE; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731354657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cxkp09Wn6xOqNmAsLyuA2bs9IEHpbeHvn+LarSYd7M8=; b=e6WvSFHF6J7hZC9IwryQ0y0tj0CbQSu1ddJHs28+xkkP2mHuGz/I7iy0HRq8vvPUzHxYTW 035Jah8/4FEoidNC6jqSmpbnCetVDWs909hd4EMg2TMllvh0z1Us2dfeT6RFa3Wf30R7Xl DtEkSQh8OnpvH7+7Qi0TXfiJou8cUpI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731354657; a=rsa-sha256; cv=none; b=c93WrlCuR2wgdfzrmEVaUB8l7il8UfWgbvv4v83iQkJXfYgf4rLB0Ew5etSRckv4qZ68fN aPG0sRA3O1t1ZR1RSEKjqg9YLh8AFU3J57brPyv3ph6gmCy5zrEZE3ypPtVL+LdBfP+dZC BgBVBEB0ORKP39tKHT6Q59kl8WdiAIo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eK9y85FE; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731354711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cxkp09Wn6xOqNmAsLyuA2bs9IEHpbeHvn+LarSYd7M8=; b=eK9y85FE/KSZ5Qy0hett5tINgcT2mMX6y0Z3Ow+BdSV8PKb3wNCG3MQzjW0Wz0rqZBmBkA jwjV7bGLuOD5PSStyRFkqQjOwu5PUBvcH2FdlSTv76l/HQ50nmiquRWTFFojjlCDEhg0b8 olLgIM0I2NgOnwcKGH2iCpqM/JjQ8Sg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-kc3FF0aqPQOSisEIKI7oVA-1; Mon, 11 Nov 2024 14:51:48 -0500 X-MC-Unique: kc3FF0aqPQOSisEIKI7oVA-1 X-Mimecast-MFC-AGG-ID: kc3FF0aqPQOSisEIKI7oVA Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43154a0886bso34375895e9.0 for ; Mon, 11 Nov 2024 11:51:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731354707; x=1731959507; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cxkp09Wn6xOqNmAsLyuA2bs9IEHpbeHvn+LarSYd7M8=; b=Wk54AAfsUvpm3qa4xAsxFmCtS+Ivg3wjVwJdycLkmjVJ9YAyRQE20A7lc+RczfRcc+ AmOZmygepWm7ipj8dkjWX0uX617HeBEZVsWNXDL2D5EsMU4+w0TSreSvbhkKr5fe1rCm GO4iHCL2IoMYDavi+OdbO6MtSl83ARvgx2PldzPO+bVHUHmN8zqLHHSnGI7GO9j66Hes YGtBFeNF6ISmpdS0w4z6+hHVyjTIwcW9Wc8pNud35jeBoOVw0fmHMvG/NlLu3/U0L3l3 csZoSjybTMHtP8yVaqZP8zgckWApfjZon1op2UyvJmWukq9l+1jN+ZlfwzReg86Z1qbc HfHg== X-Forwarded-Encrypted: i=1; AJvYcCUSAyYQATy8YhJnYdfjJ4UkQSS4tUF3gguqFYoA5Yc0fuauCyRAIQwda9h1uaWXB/VUF7JN/u+Dcg==@kvack.org X-Gm-Message-State: AOJu0YxAfLLpM4wdwnwTJF30KigfD9W51q1Yq+9nHQnhSL0WIPQEkAx3 H3guMxUGUB9NTd42Z5WGPweBQh9wLzDrTcLCA/LDtXKpapOo1ymkidIe2Lxai5c4ZPl5wmhCAgv S91CwukZporMEkdHCHEuflLpadBdQka6RcsFXX3ZC8RE0yURh X-Received: by 2002:a05:600c:46c4:b0:431:5e3c:2ff0 with SMTP id 5b1f17b1804b1-432b75031famr119885355e9.8.1731354706746; Mon, 11 Nov 2024 11:51:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFP9RVZ1kNZ/IBhv/CWvkVmEuo+FVjt7CB9tKWAyy/O5wR+vlyuuD+hH5TPvQjBnioIekuhSw== X-Received: by 2002:a05:600c:46c4:b0:431:5e3c:2ff0 with SMTP id 5b1f17b1804b1-432b75031famr119885205e9.8.1731354706416; Mon, 11 Nov 2024 11:51:46 -0800 (PST) Received: from ?IPV6:2003:cb:c730:4300:18eb:6c63:a196:d3a2? (p200300cbc730430018eb6c63a196d3a2.dip0.t-ipconnect.de. [2003:cb:c730:4300:18eb:6c63:a196:d3a2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed970d89sm13972099f8f.8.2024.11.11.11.51.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Nov 2024 11:51:45 -0800 (PST) Message-ID: <17bb7fe8-c859-40e5-8ded-be343196880f@redhat.com> Date: Mon, 11 Nov 2024 20:51:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm: factor out the order calculation into a new helper To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, wangkefeng.wang@huawei.com, 21cnbao@gmail.com, ryan.roberts@arm.com, ioworker0@gmail.com, da.gomez@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aiYpepV32GmhUAsXxJWwkXC779V3_-L_pWk1CtVlAf4_1731354707 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: fhy19h8seb35xg4a44pnweb11sskc3t9 X-Rspam-User: X-Rspamd-Queue-Id: 818D316001A X-Rspamd-Server: rspam02 X-HE-Tag: 1731354684-478753 X-HE-Meta: U2FsdGVkX18kj+0wGqour+HATQfzSe3FVaX6oe49NyyKtQT7vHUqEXutn7wW2PY8OxNSVhQDQHU7lcyzIa5mXZEIPQ+/GUmT/PRv9pMJDux/nziEl3o64UbbyFldFgIgXIguhL+D1HE+ohqJwPWx1qSTOHR/6kTFUXjIo5spUyRZ6pwhHLlW0kAK44WdTs7RO2fDknDageiTDz1Qdx6T3W8ru6qzarQIvFXCYSbcCy4r+WJuo8Akde28L2UJN3eEiYK4kUfSFwjTDRHo7Z2PT/dhfUURzMBLiaj18prsnifix+vRXuA5xO34JSevBOxaKEaatdByJ53xzKVCbvXmBSUAN+sAoDR6Rxwr/JjVedCH+8GBS7uHTk0lVyhId8ZxfFKkYU7gom+2QbcUZMsEcZQm6Iu2Nz850QHeziVPlxwQ4nmQLCsbn5w1BPZbGheJPYyVRgAdHg50ygjpzQgXvRORfEsy1t1QtjrjZrI5Ia48kbN2QU9+Kz031qQH8uNzdzFzCMA/7/mvC1NuHoRhH7Ji4jgO582FA3i7THq9VBebjBfZ/QJGWpFig0cy2oizbMngKW2NXdKf4xM5fxVo0DPOAjMoEIJCSXqFTNnIPVaryNn2MkMyFHuuHrPfOfRLSIcZCT89bdGLj1Zh8rX4WKxXnTYs12aOg0t1M9bKZatvb7vyZ+IYM+hAlLZtJSTzVS6RqQICwWk4E3RA3+M4MLkFXTys5WiA0gXNVUvPWwQzFDhSTZCadvwa0vsbXzcaXKhI5HJgcvsE7GJy3/7JHPkExBPkMUGhp8JJmwUnvFbW5dvKq9iI1RSM6b+F00ZbSETMSeoRap7pr3rSXc4mmFXlfqNCrl7lpNJRhAdKk/BHrIk7gxT9m6ztOVPrJFQqoMCNPn6mBcQbcNXFbLijZUSnGrNhA7oCfWRM4kl+g6B36XOuW+SIUa8YUUeSqJedMHAZSfwNLkhPvOMmro1 ho3w/jxx XL4OkD2liyUnvpiLS5CoE8wnMuSXeBzLM6dEHcA1v1U0SFO0UdC1mEtDKQRTkZnmLUjJHPpRZ/vo7qRvrBfhHPvyoEUdZ6tnNLpXtgSaMwQ/m2qnF6fRtMCF+9gXsXtHQpXdR06g8n9cDAoaoPmz7UtgC1FYwAHHPunwgn9SiuR13CBqxISMWud3Tu5KFQUC8DuOd9XcNVsnigS7t8AaR74CSgSvJh47RiZB9uQufjkVK3gtuT/D7lBiUPTfIZpeGxg1d8iX02JAa/JbffdD7oNMNMqE825raDjXzTRuV/sIzZ18FiHG3GD6st8gb96fJDv4wDVTnsqPu65FarCYlmbzrQIe3PM/B47mTn3YC+5edJabGap4GJRSFv1nI2Xa6w5il/xaZfv4iVs2RL6ntP+ymHRrlanoRjwWD8yldZq2pXKnfc04R8eF5utJalXAx7lg80Kg0IeFgVQkYcS+3DXOFnzat/NUX8LUKfp6JDK+/p5foCxaSinS7Mg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.11.24 05:12, Baolin Wang wrote: > Factor out the order calculation into a new helper, which can be reused > by shmem in the following patch. > > Suggested-by: Matthew Wilcox > Signed-off-by: Baolin Wang > --- > include/linux/pagemap.h | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index bcf0865a38ae..d796c8a33647 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -727,6 +727,16 @@ typedef unsigned int __bitwise fgf_t; > > #define FGP_WRITEBEGIN (FGP_LOCK | FGP_WRITE | FGP_CREAT | FGP_STABLE) > > +static inline unsigned int filemap_get_order(size_t size) > +{ > + unsigned int shift = ilog2(size); > + > + if (shift <= PAGE_SHIFT) > + return 0; > + > + return shift - PAGE_SHIFT; > +} > + I'd have added some words somewhere, how this differs to get_order() [calculated order might not have space to fit the complete size] and why [avoid over-allocation]. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb