From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 605CAC27C77 for ; Wed, 12 Jun 2024 08:24:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FB646B019F; Wed, 12 Jun 2024 04:24:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AAA96B01A0; Wed, 12 Jun 2024 04:24:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64D9A6B01A1; Wed, 12 Jun 2024 04:24:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 479F16B019F for ; Wed, 12 Jun 2024 04:24:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BB97C141403 for ; Wed, 12 Jun 2024 08:24:35 +0000 (UTC) X-FDA: 82221550110.18.07B1900 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 6790A1C0011 for ; Wed, 12 Jun 2024 08:24:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I5OSZAhY; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718180673; a=rsa-sha256; cv=none; b=NQ5x0NrO3LM9cAL10G1bNXtiK17H/cPq0Qu+jZuShoK43wZUtX0zf2PAdgLSwAbeQWto2W ki2YqJvezgc77IqPyUx4tsgK4Y7eYfz9plqy5UQDg8uRpiyuhzIxJJL0NhYUD9z+/srrH5 5jT4oXbjNTO47bFILx/JxgVftPmZqdw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I5OSZAhY; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718180673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x4SAin/ZbIr0LKUcDWptj03+6GW7XfZLpNKJdBjC5OY=; b=ZWoObNu/yMH78Oy93d0IdqDyWC5e6uPlle+0zqJlvHy/TUsNEgaqrUEH862OefeeCo8Fy7 aETS/1+e+h5Srd3jrhC3qi/iqgLGgWyMzgufKCPohwlUOXCRQqHKd1Qn7SorhBzXwyRDeJ vaDJjHm2522TepfvhCt5U/gDFR086zw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718180672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=x4SAin/ZbIr0LKUcDWptj03+6GW7XfZLpNKJdBjC5OY=; b=I5OSZAhYke+IKa2F01pm73YMZEeY4VHoA0p8P4JdFyDbSY3+vIoSrzhsKi7lVNNtHgdoBf ICk3ZAiVxu5l5q1If9iXMupMwI9iV8iTXA5qcaRZrpbjdDLuHir81tG4K67TOG+WXVzE2x Qs7xAFC1MoXoqYltKd75n8DZTed5cXQ= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-75z1nI0DPoW9Y7JH4tiuQw-1; Wed, 12 Jun 2024 04:24:26 -0400 X-MC-Unique: 75z1nI0DPoW9Y7JH4tiuQw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a6ef628c5ecso117330766b.0 for ; Wed, 12 Jun 2024 01:24:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718180665; x=1718785465; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=x4SAin/ZbIr0LKUcDWptj03+6GW7XfZLpNKJdBjC5OY=; b=mJcNgEPcHQbIYAyyqOoytV6gQHzvnlBxX275Hl4nPZqytbO0i3DpeJtmPWAqHPdrS8 e7VFopjVS0byA/+Dfrz48uNhcDv86jlK3Oghy4rqxL7T7Geee1DyOM/dXLyI3Zfh8Ay8 O6Z0qscwGncxwtZPit8Ya/SVH26VN7eYV4+9dhPmRcKJlMtUcUiqMMLTLssOkqPghrxs qGzDLKqHo4uetBPWcuAWyfOHP0vxsr/42//Od9w4UXU/z7xZQetEnKv99mc6KFTjmgqd /MJ8sBRqYYFsZFUC8DVhGbbyg1t5tuwIN3lITpXZzLYRRLYUJMiQWkVTqcvjzCcgwnHe H9Xw== X-Forwarded-Encrypted: i=1; AJvYcCXG5TO+I2pT1MJpV40Cp8XRp+qU/jOP89YeN5zVpq+ZaEUnA3j98dDjJvOgn7mi8ZU2ntsfC3q0D9xw+A7X02dka/M= X-Gm-Message-State: AOJu0YzsfRsjT/e399oAj+PocJr/Aqxyc+pyhYrRNF+LPpuzYpGUjF/r e7fwLMclVgwvNH8YCUgZ50mzy+ub+nbWUMcVjeVcoNRxaZrFemLvSI2a5DPCxdw5V0/XYJIVt2h ex4MNalcr9e4D687wlBHWSU9JSjcYu8bfhWC8IAXNGTq/Z75+ X-Received: by 2002:a17:906:394:b0:a6f:230:b73e with SMTP id a640c23a62f3a-a6f47c9e0edmr58643066b.20.1718180665218; Wed, 12 Jun 2024 01:24:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGA1q7iuoA2WDuKe96aglvJScAbJcl9LmxJfQ259oiHHm3zp6kG7M8iBlW3Pg+ABx1QAfqvBg== X-Received: by 2002:a17:906:394:b0:a6f:230:b73e with SMTP id a640c23a62f3a-a6f47c9e0edmr58640066b.20.1718180664753; Wed, 12 Jun 2024 01:24:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:bf00:abf6:cc3a:24d6:fa55? (p200300cbc702bf00abf6cc3a24d6fa55.dip0.t-ipconnect.de. [2003:cb:c702:bf00:abf6:cc3a:24d6:fa55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f2169fc45sm8386092f8f.10.2024.06.12.01.24.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jun 2024 01:24:24 -0700 (PDT) Message-ID: <17b503f8-5d0c-48a3-9eeb-85b01583f9bb@redhat.com> Date: Wed, 12 Jun 2024 10:24:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] cleanups, fixes, and progress towards avoiding "make headers" To: John Hubbard , Andrew Morton , Jeff Xu , Shuah Khan Cc: Andrei Vagin , Axel Rasmussen , Christian Brauner , Kees Cook , Kent Overstreet , "Liam R . Howlett" , Muhammad Usama Anjum , Peter Xu , Rich Felker , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML References: <20240608021023.176027-1-jhubbard@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6790A1C0011 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: u5hwftdj4ct68y5dqzy8f1e85o3hwnjq X-HE-Tag: 1718180672-301720 X-HE-Meta: U2FsdGVkX19Tf9Kd57GZnqkeW1PImjFryPvyec6E4ToO3pzgwmoLibtdZBXlMr3MsK5rqr561CdXI/nwGurHlQJaiZhJFio1PxxiyQwFi9PwL+OXKapiys4czp/Nhbq7RJ3cw6tfbY1dCm+vPvz9n4aj0elviKO6c1VQow8+RTn5C1HGaexpxjELky/cbKazv6fxGsbgfj0xlnlME9JGBc7uossNYPQiOi1x4CkUuq7DFKzGA24DRr5k/tVDfuLDNBC9WnCvTwNwnOQnyVCTo71zw2+m7YAZNc+mReHCsUgQ19fusYdu72ivXj4jlCHxDErqZvTo1WorS2HpzSnP89E8MZ4c25PoUEJMfokpxm1N0Qt1VqFF+7nkfhxJmmENzqMBD51bTbx/G/C+SCQdv9kBSVDXxc0CaiBZtmYTJHl9I2246q3KOcWlT4eE+WPqalRsmjhVv65IVyy15yR+JRDOAeA4I9c330iB908aCg6mlYYbamC+7WzYJU+sBMwH4u/XEHKwDvjUVSzZRS1g9Irpfrwtp24jLzZb78gkhPHAK1ETBq+RdCsPis/U6SRbHIYS77NCKQdT+ooqucCybCjC+Jma4yyewWxUVN4foaJIzeu5eEJ5MEe7cavKTqvzC9C/HsmGLHkRQkUjZMh2MeoDRu8LwLB/v+lcrTS84Fxp0Vf9MTT16W8MEfiLyybH+CqEB/+bRLkTb183/E/sWInkrrKwdtHiYAaRO7i/Ud9wkFzK5OzhbJ+1tW9R2RDhgZe14XicK9nQqsaB57gkyqXW7N77ImQCbvN39DYCWJR3p9XEz+h6fIF2/pc4udjTqRDC3+SEgvtHnVKq6IzbRQGxcK3VormNOAurSitVQkT8edanTcdcJc2QzLGVcYkquZ1vgj0AgkLLp3QJzqwhKZEgujO3NfO/D9nEgJ/Gd6p2nC9qNewhpDkSN9ZFu0nKJmBIuBhX192AjAuJ8ic vn8W+dDY Mma8EPgZthABzhF/Ahhcbi2F6i8NEd9qjnBa7tgw2aq7UU6+7PrgKkVt/CC/mlHaZcigN0Y/OEdkJP1+tNhfgz6/Tfga0VW5Tu8g9EdYR2Cl109XCCEppklVcJA6t6qzZLsWq7qRgWU1nkRrTinz3HZo5DDnp+qBfisKLcA5t24FTyU2sdPNvL9tpuWCLHoAq9t+o4AUbV/OV7ry1toa/EcwNc+lNsRarw0isdztoiV18CG3BNE0Tl5OPeOfbQALM6gBf05VhRwTs2P6sbvcMjcXJZr49+WSuBCS4wJDfkZbRsc1tGwNa8UqWgjclzh5NlbF+/qrtZZN6i5In/rkAzT6hEr7P53HbwwDHI9GwT1h4qQFIsMVRpKICeGrZmTMwEA5AJQzCngXjb+2JznUhm6Osf3r9zlk8rJWVeCIraF+p/MnnsYwJiTXHwRMwbzFvAsvQESEXoSZ6NQdES0T7UJ0aUHWHvubinizNnEvvvHn/Vb/scS6B+MexG0G1nz1Fk/NBdHuhGkRI6HdC6eKaTKRa0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.24 22:54, John Hubbard wrote: > On 6/11/24 2:36 AM, David Hildenbrand wrote: >> On 08.06.24 04:10, John Hubbard wrote: >>> Eventually, once the build succeeds on a sufficiently old distro, the >>> idea is to delete $(KHDR_INCLUDES) from the selftests/mm build, and then >>> after that, from selftests/lib.mk and all of the other selftest builds. >>> >>> For now, this series merely achieves a clean build of selftests/mm on a >>> not-so-old distro: Ubuntu 23.04: >> >> Wasn't the plan to rely on the tools/include headers, and pull in there whatever we need? > > Yes, it is. You are correct. > >> >>> >>> 1. Add __NR_mseal. >>> >> >> For example, making sure that tools/include/uapi/asm-generic/unistd.h is updated to contain __NR_mseal? > > Well, here it gets less clear cut, because the selftests pull in *lots* of > system headers. In this case /usr/include/unistd.h gets pulled in. If we > force tools/include/uapi/asm-generic/unistd.h to be included, then we'll > get many many warnings of redefinitions of __NR_* items. I think, there is a difference between unistd.h and linux/unistd.h. We want to continue including unistd.h from the distro, but might want to stop including the linux one from the distro. My thinking was that we start maintaining our own linux headers copy in-tree, and start converting our tests from including supplied by the distro to include the in-tree ones. For mseal_test.c, that might mean stopping including "linux/mman.h", and instead including the in-tree one. > > So what's really going on here is that we have this uneasy mix of system > headers from the test machine, and newer versions of some of those headers > in the kernel tree. And some of those are easier to combine with system > headers, than others. unistd.h is clearly not going quietly, which is > why, I believe, the "#ifndef __NR_* " approach has flowered in the > selftests. Right, these mixtures are not what we want I think. But I have no idea how easy it would be to convert individual tests. Maybe all it takes is updating the in-tree headers and then including "TBD/linux/whatever.h" instead of In QEMU, we maintain some (not all) kernel headers ourselves, and include them via "standard-headers/linux/whatever.h" > >> >> ... to avoid hand-crafted defines we have to maintain for selftests. >> >> But maybe I am remembering something outdated. >> > > You remembered correctly, but the situation is slighly muddier than > one would prefer. :) Absolutely, and I appreciate that you are trying to improve the situation. -- Cheers, David / dhildenb