From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27327EA7946 for ; Wed, 4 Feb 2026 21:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64F656B008A; Wed, 4 Feb 2026 16:54:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FCEE6B0092; Wed, 4 Feb 2026 16:54:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DF1E6B0093; Wed, 4 Feb 2026 16:54:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 379986B008A for ; Wed, 4 Feb 2026 16:54:55 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F3CE6C179B for ; Wed, 4 Feb 2026 21:54:54 +0000 (UTC) X-FDA: 84408129750.19.F5381FE Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf13.hostedemail.com (Postfix) with ESMTP id 2A14320009 for ; Wed, 4 Feb 2026 21:54:52 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=To2h+dL0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1770242093; a=rsa-sha256; cv=none; b=uYKYnm/COtBpXg1vxN8d4VSnXjwFuqLAGh0wH6i6nFGY/+dCg4sm849X8MmSlQxco6k3S6 GLJtBhhiyk9gz6AlLZwA+jBd7k6TVuXEcI1WUi5fScD1BqQNh6Tt8fPlycsKpFRPaKHnO0 9naz/F1UgGdcy0270eoZ3AA50iOrfcQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=To2h+dL0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1770242093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jUxWIpARETJakM90EqJOoaJ8AfGytj8zgMfyHiUZm/w=; b=b1L1HNlwSG/hf74PIb/oO3hDzLHReb1Vwb9VoBP3sCemZKGJGX++eVVJf8W7R2NVL/CFqr E8TumhKOXkSeApEpJiIF34ilyBaR7jky8PEcWSACymo1w0Z7Ju1Pw1tN5nGg/fua9CmUtG LdrLjlK94h7iU8+/r4N6EyWBidFp8o4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3C094417BB; Wed, 4 Feb 2026 21:54:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C556C4CEF7; Wed, 4 Feb 2026 21:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770242092; bh=q7Gv2zGZSyVDrHhkYnCxZihsE2w6iP1FgZNVJBvJa2s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=To2h+dL0nKLio9G3q/lE0b2zcXBB+6sbXjaqHo6ilwoMXpCPz9l8X6eDvkE0/bq9z g5kxI++HvbSxaxaU5EA0zDooTtZZNIG35rnLg9LP4tNDuNX/xXQq/UTSrZKE65+l1F RkfGerhlQ8+MbRgiIh25AMqvKwjBCpXBLGAU2uEyQrHgBYNQ0ClTTrhkk1vgsCfzrx v4OoENLloVKPv7xHwMNJAvWpbQPCqrt4clx+JNiafkfumHkgo+anzS1m4xdl4jjuDF uLeyE3mlBcFKGdMPCVbxGDMw1yf1ZI7e23QKXdwTypXIx49ZDHa+wj1njI/vsqZ982 lkwESDvHOHy0g== Message-ID: <17af6fe6-9318-4e9c-ba54-0b6b16ea9c0c@kernel.org> Date: Wed, 4 Feb 2026 22:54:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] fs: hugetlb: simplify remove_inode_hugepages() return type To: Jiaqi Yan , jane.chu@oracle.com, muchun.song@linux.dev Cc: akpm@linux-foundation.org, osalvador@suse.de, william.roche@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260204214741.3161520-1-jiaqiyan@google.com> From: "David Hildenbrand (arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260204214741.3161520-1-jiaqiyan@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2A14320009 X-Stat-Signature: ac8c395rx3fuarqwm4sfg66xrpqpibyk X-HE-Tag: 1770242092-673273 X-HE-Meta: U2FsdGVkX1+7p4CxGsn7uLCen86ohS6EUx6kgD3AOsv75mw0B04rFkBOdgfRo88YUQqHr0YuhUCCLLaJNeX4sVTK5tmwWncqzXtdhKLqfEE+dXsy8k2ykK80Q4dC67jBlTxmPmA1ZLAqPOk2EON+TSdMeWX54Xo2hzlGPGB9tn4uVWMWaRzOXjm/CIBjiUF44juO9bmcb2t2r7ACM1L0JVl+pCuuSdVk9dfWKO/67YYI0Sn6wDnAuG9wVqwqzt8l2eWHogxqqsLpNuNCQ7tcd7zBnm8BcigvFbO2fK/a3EHm/1WEx+uwbIl1TjSx/5So535g0JhAM/60kA67Xe7SJnkb0jpS1xRRnc382/+LrOSJeO7XIGpm8Kiz+junurpVS4Khv5zS6dt+nWLeGRPKrOvEwK2BUQxeMsbLg+vghDRMwQaWBhtM7id6ytWVZ1xl4gV3bq2EVUYmwVZ7miWssbaH33l/JvPYbnRGYxZZ+RNQqfzizWEjOO4n6lVducCrfHBGL6CbaQYnCnQV/tqc55A9YJPWxkyQ/lx5GKHdic4eTz4xAQ0Z1aOIYbK7sh6nEnqFzN7EVQfc38cbE8jNysTc4hVf3BR/aH0VrKCwiaiMqqMzXdtYeCk/22oqs33Fj9uMjspAzkmX43b2lyACEYVzs8SCsogo/1vQHo32O9Zgd28GAzna6r+kUyvbntTLZgCEsy0iNmLy0sXzNJUuMWRTzJcETzyztmja+Un5091luPybXWuwWIk9++VimbjeXaOTLPpkSqse1HBjPIA8E8CXGO636nMItMl0MwIY86X8H1Phv8wlOep7qy3b1ImXi3ypyemarEyHdGS98RSOXKa+u51BMdByAc1bdcOGM1SkcqcnZzhrTfFf5wpMQugE8K/osmm/VL9GmdwIT4VIPkHRsuRGhhy5+oFwqpXVlQd9JQUDLGVF5T/Qa84eQoMLHpQVasSYLvTVx5Js3r4 F97a2RJi +gh0LgDkUM13tpJgfy0JaEKOWC7us4y6/34UQFA4/EHTgZO+6pcQaF5/tLFs+b5kq4xzwsifNqHtQULuYLrg0HrsoWBIWrqXPvM5emvg6EQjGdCo1+qeOu8fd+62dFfgJSeSKcIE5VIWNcO9AibHXrMgolmvcyaCsBC6sS7xNfxHng5OP5NC42Rwk/+2awT8b6Tvy8hHCUldFxgYu0cYpTjgNZ8tuSkp2bbN4RQgBj2gvQeyax96RCQn9eMhPeSnzeIsgtNy3RDt8q/4xk7+GsP4V9N3R+uRS8ZaXhnkehCPgiUM8qM+uXBjpYzzErE6AuEZpvxJ6X/mG4xP3gdaWMzZlUzCK4q+QVLOJp9xW0XZc1rl2uWha7+ToWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/4/26 22:47, Jiaqi Yan wrote: > When remove_inode_hugepages is introduced in > commit c86272287bc6 ("hugetlb: create remove_inode_single_folio to remove single file folio") > it used to return a boolean to indicate if it bailed out due to race with > page faults. However, since the race is already solved by [1], > remove_inode_hugepages() doesn't have any path to return false anymore. > > Simplify remove_inode_hugepages() return type to void, remove the > unnecessary ret variable, and adjust the call site in > remove_inode_hugepages(). No functional change in this commit. > > Changelog > ========= > > v2 -> v1 [2] > > - Use two-tab alignment for parameters wrapped to new lines. > > - Remove return type in remove_inode_hugepages()'s comment. > > [1] https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@oracle.com > [2] https://lore.kernel.org/linux-mm/20260202233617.2350734-1-jiaqiyan@google.com > > Suggested-by: Jane Chu > Reviewed-by: Jane Chu > Reviewed-by: Muchun Song > Acked-by: David Hildenbrand (arm) > Signed-off-by: Jiaqi Yan > --- For the future, the changelog always belongs down here, under the ---, like Signed-off-by: Jiaqi Yan --- Changelog ... fs/hugetlbfs/inode.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) I think I always add another "---" above the file list, not sure if that is required. I'm sure Andrew can fix that up when applying, thanks! -- Cheers, David