From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F709C5AD49 for ; Fri, 30 May 2025 19:17:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BF086B0196; Fri, 30 May 2025 15:17:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36FE76B0198; Fri, 30 May 2025 15:17:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 285D76B019E; Fri, 30 May 2025 15:17:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0AFAD6B0196 for ; Fri, 30 May 2025 15:17:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A2072BEDDE for ; Fri, 30 May 2025 19:17:38 +0000 (UTC) X-FDA: 83500533396.03.960E0FF Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf14.hostedemail.com (Postfix) with ESMTP id EBFAC10000E for ; Fri, 30 May 2025 19:17:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=g6w5DUvT; spf=pass (imf14.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748632657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qVsTDgn88qfDx7zNANB/Wuf3yoMLHegUPd3fH6oz000=; b=sTBTGbaUmWvgnXaht5j77OCEkeh8l5/NChwQ+JDiQ4YZyw5BQRAlYTb7j5ggS7b7Z9eTyM u0rHQHbV4m5d9eHQD47bwnIVigukNbHvT2yU01B3rJ7SvKOPivu27vU3T/kTVyc8srRKBo QKeq3B2+o3wIAGUK0EGm1zVcLybR6H8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=g6w5DUvT; spf=pass (imf14.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748632657; a=rsa-sha256; cv=none; b=Zhq6lzBdiQxHKfkIuSqxx/ZvzQ/RuVAm4HgAcER4iRbwao+CT8MMCR/SPo6ychZSMd9+Ua 6mHc1WimSRR7tjOk8b4GLC1fK4YnT2NI7B298jVTzPcXD+wNTaovWZ0iDo7cQIIwBUkJmF W5t44+elUv4aj2p6ptDOrQtIfp4QP+g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1748631920; bh=FPavw7sqDjydt0KkrExoi1d1jz+U3kS/8aP4jA7ihx4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=g6w5DUvTpdL8zcx969b95fWzFDAExBM3zGbcT5KJh/I7jyjsRRPsjxkCTd4E9B79E yg2pmj9DmZlNoaGZsfEcx36gD6xidMk4ZPfLhfajaogx4IjWmfCRZ+VNuRXMs0kWs7 shszV5ABvs46waSeVhngnjIttRTu7RCwKNJ7qilg= Received: by gentwo.org (Postfix, from userid 1003) id 45F094025D; Fri, 30 May 2025 12:05:20 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 43D13401E9; Fri, 30 May 2025 12:05:20 -0700 (PDT) Date: Fri, 30 May 2025 12:05:20 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Vlastimil Babka cc: David Rientjes , Andrew Morton , Roman Gushchin , Harry Yoo , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm, slab: support NUMA policy for large kmalloc In-Reply-To: Message-ID: <17a999f3-7e6b-17d4-2caf-4912221894ec@gentwo.org> References: <20250529-frozen-pages-for-large-kmalloc-v1-0-b3aa52a8fa17@suse.cz> <20250529-frozen-pages-for-large-kmalloc-v1-2-b3aa52a8fa17@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EBFAC10000E X-Stat-Signature: gkyab577dugannq9ge863qhf4paxkckx X-Rspam-User: X-HE-Tag: 1748632656-596972 X-HE-Meta: U2FsdGVkX1+q7yZbSkINxOv+d2GHBYUZbRTHXXcCO5buzcY/0JVePJE744WQ4MjVN2h25rEzGF9453xxS8bxbfIwzLcxHHJfV7+w9H4hwX3kJyxzpSqCLjiOLpLhaRqroRsXAjJ5IyOs6vJKevshp/bro0TwRobRtesTfClO4ndyLEA9F2kGsCWiUMcjgxt/Mb6poa4XMnOAVdWIlnIU2qlGJpVX/NeAei7DrDsiSo4uxeGtt6lFVrCJRXrrjQaldLXcWF9KbxBc42jhBg19oXhmVQJetfRjMcPqCSO7oOX5l8Cs8/hSfJSCmlyUJzr286Z8aSNE8dXntDD3kFy+z66wtZlyBTPE05eqYgfFNNDpSZDJPboc5/vvLpMay9WH1xoNsBZhGSa06XBaXkwhFgxjUUL0OEzdhfYYVCleouYWTn9niC2a13sgIPXGei0kQEGYfQhhySwuKNaGrhQ1GtnWWY4nV10TtykOOhedU+AJ8GCPqSp54G2Ba20nPytixccVgLFr+bYpemF+vN8vORSdE/x8cj53VJQTHgt975skGy6uxX7K8q1J+jn3NX9EZ3QY84+Yph0D5W88bHrgrCSoJfKRdNZ1TI+e9YOoabOh7acmIUmmPvKB2sJk/LYrnPnfQvdTCcZ7+MElVn2kO/HDp52k7FD04gnmkMvxjTamKa3VamNhBeQei2mlQX08pr/dIGSIOMsc38hr4n/4E2L9Q1SXXh48ODao+Z959lIeV2p4cEREKMmEtfZ3YgXpZVsbCW0I1q5w+buSGZ2OfKq+USbJhIVrKDHDMS2fzAYH/oR3QSkTGK+wvVpVl+Srlj4eg3ntqFREl6xUj5BNkiG7Zr6Uni21xeKga+kLymBk73Tk5I+sNH6lq9vYSSf/vNbvx3LNZoPIzbi5BLfSdQp2h3qdhYMp8SQF8GyRV27ahiFjIorHOsEhWhyN98hAErWiHjUOtkv/WUK2Pfb 4mtgTBn3 I73Oe6qD0643ZxVtW2u6t27B18E7qiAyFdL27ETMtIp859tKm5U5nQv/vQOnn/Qryj8FjIOB3SE/j3U8wns3OMlnez0dvkRQLg3S2N87JKh4fccRe8xm8dNCTDA/v+7AHC6EnJQmqFvaBsYNt/qkzTlSPlbvFoanay0ogBMyXtOgPD6TQ8EpPTZrrWFlNLHkzJgPZrK74Jr3o36OyXRNL7YSh7g4wfBKM+1wMmkazK8LgS9YGYRxKWfqkFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 29 May 2025, Vlastimil Babka wrote: > On 5/29/25 16:57, Christoph Lameter (Ampere) wrote: > > On Thu, 29 May 2025, Vlastimil Babka wrote: > > > >> The slab allocator observes the task's numa policy in various places > >> such as allocating slab pages. Large kmalloc allocations currently do > >> not, which seems to be an unintended omission. It is simple to correct > >> that, so make ___kmalloc_large_node() behave the same way as > >> alloc_slab_page(). > > > > Large kmalloc allocation lead to the use of the page allocator which > > implements the NUMA policies for the allocations. > > > > This patch is not necessary. > > I'm confused, as that's only true depending on which page allocator entry > point you use. AFAICS before this series, it's using > alloc_pages_node_noprof() which only does > > > if (nid == NUMA_NO_NODE) > nid = numa_mem_id(); > > and no mempolicies. That is a bug. > I see this patch as analogical to your commit 1941b31482a6 ("Reenable NUMA > policy support in the slab allocator") > > Am I missing something? The page allocator has its own NUMA suport. The patch to reenable NUMA support dealt with an issue within the allocator where the memory policies were ignored. It seems that the error was repeated for large kmalloc allocations. Instead of respecting memory allocation policies the allocation is forced to be local to the node. The forcing to the node is possible with GFP_THISNODE. The default needs to be following memory policies.