From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41A5C36010 for ; Fri, 4 Apr 2025 20:52:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF29F6B002A; Fri, 4 Apr 2025 16:52:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA5296B002B; Fri, 4 Apr 2025 16:52:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1EC66B002C; Fri, 4 Apr 2025 16:52:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A440A6B002A for ; Fri, 4 Apr 2025 16:52:49 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A5A691C9D92 for ; Fri, 4 Apr 2025 20:52:49 +0000 (UTC) X-FDA: 83297560458.25.2F43B10 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 4E37440002 for ; Fri, 4 Apr 2025 20:52:47 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KRZJS39T; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743799967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bsUh0wvfi4se49z7kUlZqkv4Z+LM4wGz11GPajlP1yU=; b=uYN90LgGJ8EiJkORyOd6XqOlHwa72zW6zLfh+VKZjZSGWnJHRaAKZmGeIB6UcD9QKEf4Yn JrevsF9mbjRnPCJckiX0ZMTO4xXcxJ8Eg77N7tG4T7nmc1CdYZejhoPvGhWllh3o9fHzCx OcXQsEJYW+ImV6HtXr2lrtkyTfsWCYo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743799967; a=rsa-sha256; cv=none; b=INFPwHwiyk6RhSJxoZlDRLZC65a63T86OtkeVF2FLh7eQq/ViYQShtH+ne/jM1kQ/K2Iju 4Uvy5f/M9TzpCAyio+CSX7omMojqFOr39ZPzlCq+8NdURmaSoFcTrMJiWWDetz/lkGJ3kK 7poZDZ1QqO3+htM1Kr/fChrazXlmJH4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KRZJS39T; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743799966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bsUh0wvfi4se49z7kUlZqkv4Z+LM4wGz11GPajlP1yU=; b=KRZJS39Tz7SnwIcozQtjxjv79WClbzrwmTq7OrQsDYYoE58gY6YIKeuEc9g6mkAeGqD5HP Rn/jTU4dl4rTv0k9/2rWVwNMQudJ7BRr3G00c1XCNp8Eb/YrC/EVCSCU0HArl4RfquXgD+ 5t1i6/cECZ7BERQ8otFxlwQavXxNmS0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-520-qps9H03cMN2HAdd9awRUng-1; Fri, 04 Apr 2025 16:52:45 -0400 X-MC-Unique: qps9H03cMN2HAdd9awRUng-1 X-Mimecast-MFC-AGG-ID: qps9H03cMN2HAdd9awRUng_1743799964 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3913f546dfdso1431446f8f.1 for ; Fri, 04 Apr 2025 13:52:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743799964; x=1744404764; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bsUh0wvfi4se49z7kUlZqkv4Z+LM4wGz11GPajlP1yU=; b=aqUqfO0DLH3EyyGnxNFtuBqBQ4haigmykA3WkT8xPKj3rNQXj7PUkiJuTk4ovBrOWU lVV8ltNVUhs5D5Ia5Lk+LgVQTHx9DUoR464MSusXvmSNNDHk0yWR2gDFhRYgIwp0AzlL i1pbTNBkS9ouqtHAFQjiONVsJ09AZEO3ocEPLVXvIQZ0pWEl+BJ4cLu/aC+XiZP2j97K e5TpEYhD3kk+X67vcweMwcPJ/6R3uAWJpxB/fnd0e+OzLqzHbgZCUiUmKc8PsSnxM7G2 CNSHkLHDbfIeg05KnCTbseolj3eeiy2qvWnbtYSn/EJUnqgcoMkUyp+QZHpAgtWh8rGO Yc0A== X-Gm-Message-State: AOJu0Yzzj4ifPuUP1BQhRYlkV5bbuRwstVNGBri+YOj7wBbVvahkFd0O 9JghN2nahrBrEcoZjIu7In+W9fEsU8Kz66drrMOWV3nT+bDMPHzXWnSA2OYotYhKBHVCyLgDKZt cTa0zdNYsh/8rL2v1QbNoqqOvDje0hL3HG4TsUISR6Ho71DFU X-Gm-Gg: ASbGncuULVRHxFnHBHWYzGbipmB8P7SlBObsHnBpa5sVW65hWA96YHw7/O2kiFM2qBH qfwcKjza2RA8mQKg5l/fM3frGyzxKsQ/NY+N9eR2qdFNcwzucxJsXdW1RwRpmBmqojdQsJ/hxD0 xhyWjc7YdJAlPArxQJsBTk1k/6FeaNRWdiFO2Vw4/tdypJimea/4HIhYzsscryROFc2+gv9UPNn IxXZkp06q2ngJSwxQX/6YTjqnhAtqp/g67KhHqTUp31ifFM2hofebEGRA6pv7vJ/NtlGfqFG6Km mRQ1FUUB56VMx+wBlP5lYQM7nZkTIdWCthqaHKCWR/VK5iLGaK9hm+wOh4yblryKfhlqe+5cSvM /RqpC70F1Gvvn2aaGk1Ip+AucI+W53EFfzEoEzfEbr10= X-Received: by 2002:a05:6000:1888:b0:39a:c80b:8288 with SMTP id ffacd0b85a97d-39d6fc83ac7mr495234f8f.33.1743799964244; Fri, 04 Apr 2025 13:52:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErR3GwvekSsj/vbvBk/LnHjlLSjzQzt3WU+jP0oHkYFZ/wK1VTKzJLRlzbfUX/6LhsI+rb2A== X-Received: by 2002:a05:6000:1888:b0:39a:c80b:8288 with SMTP id ffacd0b85a97d-39d6fc83ac7mr495227f8f.33.1743799963920; Fri, 04 Apr 2025 13:52:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7900:8752:fae3:f9c9:a07e? (p200300cbc71b79008752fae3f9c9a07e.dip0.t-ipconnect.de. [2003:cb:c71b:7900:8752:fae3:f9c9:a07e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30226dfesm5264287f8f.97.2025.04.04.13.52.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 13:52:42 -0700 (PDT) Message-ID: <17a7dee4-ed2f-4b09-b020-1cff3be69ad7@redhat.com> Date: Fri, 4 Apr 2025 22:52:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] filemap: Remove readahead_page() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20250402210612.2444135-1-willy@infradead.org> <20250402210612.2444135-2-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250402210612.2444135-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hZsNCRnqVOTPW-z8gs0BgihR3Z2OBAQmKcDIuo4xjI8_1743799964 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4E37440002 X-Stat-Signature: 5613yonyga5fsm6aiz4u8d4k5jtwkukk X-HE-Tag: 1743799967-344963 X-HE-Meta: U2FsdGVkX18gETladlJcSYC7ETGVoY1y4z89hbS/6c6PSgo43483XMoMUuTRqsF1+UH5aMXYdyCYNq1OprJ1h5RDWT+MvCiE0Q5wCxwuAy88fgF58Qeo9AADqHGR0eQL0Lyw2vM4el42eQY1D1D0XK3obyBt//18PinTv1km5iy9vVqvhYqPK6nRco3yJYYxObcUFioijd0r8HL7nnb0HR7GWNjTpmneAoDo2KOd658nILK8fvHFIe3glU2PPTCTVkjX6Z8856KZMa3unK5+Rg8nXi3YZW0y+8n85onmsBtNcw4qgHIkrEy6GBtc7WKqmwnQwXk8PkWOCfDpwGhzhjPDbiQnXmjsw/gzKbavFnruOxfj5HGgrtO64uSM04gXn/3jBkj1BPvuqlo/F3fOQ4vsZFvqLuaFDiRkz2vTd/F+60jeXhXNHjNqlMF2NVTRWhpj8Dp2jqvwoyOaaCxb5Pe+vf2DR75maYhgZAkY83U9tOeIcDPqBkM7ZFz9byCkO3likF5o4kOb7xpoBMxpr67gzBpD4X0euwjOYkVCHyOPLVpvDNDrWNGa+dWfuhTy37J4/fyeqDziB0hC4/fCcXVUgoN3MVPWGh5Uh9W51GuNaWlbRCLyxnbbfwCguqRIm8JRx9FCgFKAdwwjTAGA9vAszD077imPpjmgn+k61sUB94ZnTKOatF5fG7JZSVpkRByIEQyrUyuiBM08Wm00p9CK+voChljcUIj15uoc+eqGS1YfsalCRYnxQ0PMVAn9qYpMQXQoTj+b5O86Jz6FR0yusC8COCrNA6s/7MaHzf2ukCWYiN97MzN4Vc8j1mJ+ZCqfTuurtIIPWWMpBb9GLGCxYRvsAOgIRlAiBlIOMZoW2KKORr/fhtPvdqQcX3gPL+yONu1VdcFSNigTWaeK5iXgIUWZScozmSGX7WcJbtdXZjnTXb3cvAkoXfvGqGP1tmgefgerE6JyAWpJV2i bnC9qh6y C1pox2bcawy6kmB8hfoNW75m032pUei+PaQnenGyNj7Ml15oNu7BTbUWzpqXJ/WFByv+d7j2GBI4/z+pF54lByZ9dfOYe2W5btDe1VtjuXGTGe8Cl9MPGET1QSuQVpwlspGyahM3QubtD7lnmYGuCVIPpUNns7xpuvuJtgq+ldMIlL4jZW5KAXRBNlvWXNF1h9amM0ZSKJi2kdGjhIboOoaxQW1Lhy0fmXgxnp3gZpN3xS0GuJ4BIgGuCLU95I5WAI2aT3uc9nOVcwBPO+ff/JAXc9GPy8RXqBwWk7qShIPaU6s5mYjs2oZTEVq1C4AaDJX44VrMrR7yjkuuaf8jo6cJEgcaFym/OBGmJKIhyzFP5B4nmnDoeUMhZbGdVjKJBAmQsTFJJnYsRd0tSxDGFHbZdoJN1u9JLoEz7A9aDX4Z8rpCGnO5kv7+WAdvQoD17gJb5rbMhoBh6g3AL8hpFdkZ0MD+4NcGHBpDUJabkY+18zyMTohrUvdCtKuiiyWmOqWrOPAVYA4H2RJb/AvX/EKiqdw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.25 23:06, Matthew Wilcox (Oracle) wrote: > All filesystems have now been converted to call readahead_folio() > so we can delete this wrapper. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 22 +++------------------- > 1 file changed, 3 insertions(+), 19 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 26baa78f1ca7..cd4bd0f8e5f6 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -1308,9 +1308,9 @@ static inline bool filemap_range_needs_writeback(struct address_space *mapping, > * struct readahead_control - Describes a readahead request. > * > * A readahead request is for consecutive pages. Filesystems which > - * implement the ->readahead method should call readahead_page() or > - * readahead_page_batch() in a loop and attempt to start I/O against > - * each page in the request. > + * implement the ->readahead method should call readahead_folio() or > + * __readahead_batch() in a loop and attempt to start reads into each > + * folio in the request. > * > * Most of the fields in this struct are private and should be accessed > * by the functions below. > @@ -1415,22 +1415,6 @@ static inline struct folio *__readahead_folio(struct readahead_control *ractl) > return folio; > } > > -/** > - * readahead_page - Get the next page to read. > - * @ractl: The current readahead request. > - * > - * Context: The page is locked and has an elevated refcount. The caller > - * should decreases the refcount once the page has been submitted for I/O > - * and unlock the page once all I/O to that page has completed. > - * Return: A pointer to the next page, or %NULL if we are done. > - */ > -static inline struct page *readahead_page(struct readahead_control *ractl) > -{ > - struct folio *folio = __readahead_folio(ractl); > - > - return &folio->page; > -} > - > /** > * readahead_folio - Get the next folio to read. > * @ractl: The current readahead request. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb