Re: [PATCH v6 4/6] mm/page_isolation: remove migratetype from move_freepages_block_isolate()

[Zi Yan <ziy@nvidia.com>]

On 30 May 2025, at 15:52, David Hildenbrand wrote:

> On 30.05.25 18:22, Zi Yan wrote:
>> Since migratetype is no longer overwritten during pageblock isolation,
>> moving a pageblock out of MIGRATE_ISOLATE no longer needs a new
>> migratetype.
>>
>> Add pageblock_isolate_and_move_free_pages() and
>> pageblock_unisolate_and_move_free_pages() to be explicit about the page
>> isolation operations. Both share the common code in
>> __move_freepages_block_isolate(), which is renamed from
>> move_freepages_block_isolate().
>>
>> Add toggle_pageblock_isolate() to flip pageblock isolation bit in
>> __move_freepages_block_isolate().
>>
>> Make set_pageblock_migratetype() only accept non MIGRATE_ISOLATE types,
>> so that one should use set_pageblock_isolate() to isolate pageblocks.
>> As a result, move pageblock migratetype code out of
>> __move_freepages_block().
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> ---
>
> [...]
>
>>  diff --git a/mm/page_isolation.c b/mm/page_isolation.c
>> index b2fc5266e3d2..08f627a5032f 100644
>> --- a/mm/page_isolation.c
>> +++ b/mm/page_isolation.c
>> @@ -188,7 +188,7 @@ static int set_migratetype_isolate(struct page *page, int migratetype, int isol_
>>   	unmovable = has_unmovable_pages(check_unmovable_start, check_unmovable_end,
>>   			migratetype, isol_flags);
>>   	if (!unmovable) {
>> -		if (!move_freepages_block_isolate(zone, page, MIGRATE_ISOLATE)) {
>> +		if (!pageblock_isolate_and_move_free_pages(zone, page)) {
>>   			spin_unlock_irqrestore(&zone->lock, flags);
>>   			return -EBUSY;
>>   		}
>> @@ -209,7 +209,7 @@ static int set_migratetype_isolate(struct page *page, int migratetype, int isol_
>>   	return -EBUSY;
>>   }
>>  -static void unset_migratetype_isolate(struct page *page, int migratetype)
>> +static void unset_migratetype_isolate(struct page *page)
>
> The function name is a bit misleading. It's more like "unisolate pageblock", right?
>
> Maybe something to clean up later.

Sure. It can be done when MIGRATE_ISOLATE is removed.

>
> Acked-by: David Hildenbrand <david@redhat.com>

Thanks.