From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDB3DC282DE for ; Thu, 13 Mar 2025 17:22:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8BF428000F; Thu, 13 Mar 2025 13:22:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1479280001; Thu, 13 Mar 2025 13:22:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8F6B28000F; Thu, 13 Mar 2025 13:22:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A6AE8280001 for ; Thu, 13 Mar 2025 13:22:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA2571A039A for ; Thu, 13 Mar 2025 17:22:58 +0000 (UTC) X-FDA: 83217198036.24.04496C3 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2089.outbound.protection.outlook.com [40.107.244.89]) by imf25.hostedemail.com (Postfix) with ESMTP id 1C39AA0015 for ; Thu, 13 Mar 2025 17:22:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Q+0qkhls; spf=pass (imf25.hostedemail.com: domain of ziy@nvidia.com designates 40.107.244.89 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741886576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GfDw4p2FarNI6Fl1ia+p2zIKcpR/raoy3aQha2AeXJk=; b=lUV4JpP5DIwtE3CpLmGQBX+m41MJPizDVDBxoErAubyUzxMpEIR7oE/pHaQzFCja9RXdIh kuHjQXV8qgCTtQWNN8kr7qLKbzJAyYAZgYYDk5OJZtnLtZwBZ69JudupIJRdj0EuV7q7Q8 Xjum2q4/6zm5YoaMaxt8kvjGe06Dr7o= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Q+0qkhls; spf=pass (imf25.hostedemail.com: domain of ziy@nvidia.com designates 40.107.244.89 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741886576; a=rsa-sha256; cv=pass; b=A8Etw5QWCv/PqTmohkVLtpHJNLVLrD241sFTaqDx5zG7g67uRE8H0NVzO50Hy6nqJ7GRAG SRNOS/L9qIUr3b0nZbJ5YGS3Mr9R7AQN75K0NCMlWTz41KHj1rC9k4QttS/LpVLEZGnd14 vb4jyQjUXXt36qNsjQJi4VbkHQ4la7g= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gBlWOIjc/qAIViz9RZaGJTipds3uiv2Q+AWMZ1273t/wtxs9RC68i9qHJs0J7lzFphwVm7LBQ1bG4ict+kETJ8b0WdN5qCTxjc29LBBtrjTQ/23qE5aIUIR2oDx19n6XIMYNdeMMDbASdj6urEuzEKz/IanB0XpjvkAVdImW6kOmxsc42PfPmVQht51XqKCWokPhCAVDYzQ6BhfKTS5IX3XhIXSogyaCh7RjTxiWcNqp/E57Idie6td49j2wX7r+aosVkUvuwRDvItL8eRNQNJBEiHqydVwLg+DeZzBvlqjGGIAAQi+qhCx/YFZfzpTpjEflIppxlm/lgzDcfvBEyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GfDw4p2FarNI6Fl1ia+p2zIKcpR/raoy3aQha2AeXJk=; b=XnaXpGK46aimNm342gpnT5jAo2eGC1Tn0tuX6P6Ac30ZQ4LMAWhhHSWkF1jOdDRqd7tVRU0pFlh8C678AC07/EGYznl5PS51hTvF6iRIRl8Ya4L45nUjgsHtvGkyuFwxZYxtDjgeNYUewdsT8zXPjWlfOcBP6BIJzpx64LPrOCScpx5aPW0eJVzSXDAPwUsgKHPlfHRPujG96K+Z4ipNWWIeRy2rhTHCJshTo6t2dT48Z37z2k+iW4S4nTimFWsFaEUVqaOfKPx62WjC1cXdkueebOovampklFKrHtOkCmScQQ5DrDT+tO3Zdcm7D8RzQ5+sByOXvWtVn3OQs3WMDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GfDw4p2FarNI6Fl1ia+p2zIKcpR/raoy3aQha2AeXJk=; b=Q+0qkhlsgAFySDMQfObCX6TC/y0w3AoZaahaxhkmNHJ1JNSeotXiX+gheVrlbbCxN3Y1MTzVYs4Akg4xky2rdgRdt+L2e5c3iN6+ZuGqpIJDN2DqPs7O7aEEVa2wd7noDNOqwfOqu6jqZuobOlc1hU6UGO0hnvhdWlNapNfcljsG8PTQJMFok632x9FyHsMWb5Zo92OWrOPiKLLFgvXxHgcHwYVYZ2zw9Wt7dGjJrBnBqnwqI5oar8UtxEYABpeAOewVc0LkG30wraTsk8sNC6xJStMtywbtL6H7LlWuzIPIolBkv1VgrMMAvaoXS4ZpxtoDWd1BmEeTUrgj5HvNlw== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SA0PR12MB7478.namprd12.prod.outlook.com (2603:10b6:806:24b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.28; Thu, 13 Mar 2025 17:22:52 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8534.027; Thu, 13 Mar 2025 17:22:52 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , David Hildenbrand Subject: Re: [PATCH 1/5] mm: Separate folio_split_memcg() from split_page_memcg() Date: Thu, 13 Mar 2025 13:22:48 -0400 X-Mailer: MailMate (2.0r6233) Message-ID: <17C5C599-B039-49F1-AF90-8ECF0536B4E1@nvidia.com> In-Reply-To: <20250313145856.4118428-2-willy@infradead.org> References: <20250313145856.4118428-1-willy@infradead.org> <20250313145856.4118428-2-willy@infradead.org> Content-Type: text/plain X-ClientProxiedBy: BY3PR05CA0015.namprd05.prod.outlook.com (2603:10b6:a03:254::20) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SA0PR12MB7478:EE_ X-MS-Office365-Filtering-Correlation-Id: cff6317a-f0c5-4968-820b-08dd6253af7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VylSqOk6S6xvaFIQ1hcPNxvfVcTVQshIkAJgpag3Vh8HA7NqPSwCD9AOHn7m?= =?us-ascii?Q?8f/RzE1Q/fdPZNYcBioeKKYOnWWtArX3Qp+zJfOHAlsZ+XsdiGNW6E5h5LKT?= =?us-ascii?Q?cCPjA6Wc4r3ywUs8Y5dZOCsacjKkQaaDpCc7QJUfUjkfYEeDmVsAZHV3HZE2?= =?us-ascii?Q?YYpft7NbiH18+RUQqZTab0TinX+H8bEN8gcyZ6JapyC0uQQ55JvQ4RKHjWFD?= =?us-ascii?Q?us34Jvwr1yjQAzQ09XCPNAmJpNPldLpPslDgMPk9vmy4FEiygDLx6F25VzR8?= =?us-ascii?Q?ckkW3+pNtApuGBe0p8plVQLUGlNSdJi33PJTutLLNXTTf2FO2Jl8B7acDlTz?= =?us-ascii?Q?O8Rhzduj+pp8sSaXABmv957/PDPsqU0BY9Z5O/0oH1p6eEH6Z+xGDm00aX2v?= =?us-ascii?Q?hxh6SqyzUKIyA7yn7hKGVksR1QN/kP71YknpmNC7H7+nqWg9dhfk3iiduxa3?= =?us-ascii?Q?pBZbJaW0v2qekOGX+Qc+xFxH2uUmRdd2LUaGD1uSr803weF63ZSyfJJiq3if?= =?us-ascii?Q?AOas9m9hTsbZyU1vH4wXWBDKbUsN8jI6wk0TAD3QQPY9AhSyBl9/cWurFyHD?= =?us-ascii?Q?r7anieLiMjxBn08I/JVRLhm89N+KzGDYD6+FBKS1dUTUnwqxVc46cy1q02N4?= =?us-ascii?Q?DMdRlUzERirQrRhXz/HQ4X4eBiGoEPsKzO1Pct2FuxqUySg0zzIFpSPY4rsl?= =?us-ascii?Q?dnDYEGv0itacUCS06bPRzsCuO4NvomqptJUgqW6IalHSZ5F9q1mHyZY4Jr4h?= =?us-ascii?Q?sY4pFCiUBhwgYYh0NCzNi3sbrfRs5TxFBHQeA4Bqx7Ew3VTBL1NCoeMUZS48?= =?us-ascii?Q?be+O4Jrp0vsT8WlW9ChmNrYGmSygCIZLffcyTTIlzGmEptsZQjMSnZIcwHYd?= =?us-ascii?Q?lRh/jF8CB+2Jhj3/sUMvclS4DDhMbNVmiiOv6mdEnZ52a9pTtK2BuTu2XM7x?= =?us-ascii?Q?Jz2XevKWuG6uj27XmnYSLysRZ5xy4iwPrWXATtMb+FtWFRBnw1RfGy5te23W?= =?us-ascii?Q?zCLVzMJhwIpXbS+Jnmd58hit95TERHarp2PlDs/w3y7ADt3VTB5dMkBtJVti?= =?us-ascii?Q?nFAzCd033gnyZ71EH+ceXG4YrJoo1NQypm5B2o2zAaxGezupUhKLcEqLt0QX?= =?us-ascii?Q?9ZzthR35Byl6WqB3kUQXZL86NI9r0uOBmvfJuEw+zAGkt/v7knNNd7fxA4jW?= =?us-ascii?Q?MVKjDoCpBlL3eeALo7MCosjj/4+jbUIvMPbWl+I7ZHH5f7G7M/CwH09U+ApA?= =?us-ascii?Q?SIDtaIrSAHMonZPhaMxCIPTfGr3lslU7Wz1GBGuADEdN2qelIjWs/p/xNJR5?= =?us-ascii?Q?3SgjeQtpteEZRAEJWFr3V6rPBMThOuPrqm7mOWOP6xWEERdCJEzJHg4Y6/K+?= =?us-ascii?Q?1VKMdvu5lzOhcWR+aRbi03OPZ4z8?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZnZ7K+E82WNmLXQNgxEKjNQfATQdXpdaG0JNEYuYrK89nJGiKPYnOGX77o35?= =?us-ascii?Q?qcvWiyObsMCfI3IZPou/IFXAdBxpu43neUyeOenQuubzXAqL3rAYMfN/jHZW?= =?us-ascii?Q?C8JQA4FIv8edig1oXpkASh+dqhqwuewhKrfagru3d1csosHlp9ex9KANusqZ?= =?us-ascii?Q?70nzaH+OtSEEVz0/urUpLYbE7ZCCZn+HCdHOZj5GowJbeDqB5RyI34dXTLKk?= =?us-ascii?Q?l8mfhJ4HhQ9fDxYUZ9MwSkYCRkX8DydMo9O3IXbPyLY3LOkpEP8/84lXVLMD?= =?us-ascii?Q?RmcSebpR8C3GQPVdCiVRrYnoUuR8zrrMUGHGxaTSDJsS1xkLrI2Eh/7cwAag?= =?us-ascii?Q?yAAeNtERUvQgL9pOAJ4nkMFrhFpTAgf4ubr/XSlCJnW0ar765JMSaS4Ywsjh?= =?us-ascii?Q?hXlmD+HF0oaVMwh/kLuQQnQjPC9q9sBSLbQ/Mui6iGn7YAun/oP2m+GHKl/N?= =?us-ascii?Q?nZP9W4YtkQkfSxOwqbTRM+4L51gEIvE781kO6/wQSjhBX1hpYp26jQF7okdF?= =?us-ascii?Q?Joi0BpEfSNjy5yhWB5aGxHD40y0n5/pJafRcPhbKmbrWDsSrTNKd2AXahu3O?= =?us-ascii?Q?K/eysO4nenRmyGqDyK0owUW2KPnEJsIAb19647GJOwPUTNXDNWgTiNrjGIlL?= =?us-ascii?Q?MiaxvgJi2+3+awRCNJAIuBcXMwyEbQLVsAWnN6x4y1z90utn5i7aKbNc/CG4?= =?us-ascii?Q?ZS+w2/D2XGoXGXIIlgFyPcqMlPLm02yWsr47pfj8EE5ZaUNtky6anU6a7FyY?= =?us-ascii?Q?LVAdmZdYVfXVpFayuhOu47zabfXHxKHmx+Gz0pawrRsrJ93SX+myIDmvkQB0?= =?us-ascii?Q?exHJ7ZUsof4QSXb67fWs6S6joMsUd+z6r29/3x4X8s/qr8q1Blbc399qMt6u?= =?us-ascii?Q?qHwL8QzdTY3kVk43walzhUjMP9ylXQPgBRz/Rh1ysKm7YrdxWjorAT5W22dR?= =?us-ascii?Q?+pOAzLfn/kABnPoUp8ONmf8jS27tFwxW5qGTs/RBNh9pBJH1x5zn+6q6MNNp?= =?us-ascii?Q?XT+1vR31FFmAQXRXVrdQhu7bcD0dFIamOmUvlGczUcGxWXrTaYTL5auY6F0Q?= =?us-ascii?Q?ovACHWt1kuEAnJANYjViyyjpmH1YWym0YxPK8zEwQfjlYWgwxxSYVnhSY4Sg?= =?us-ascii?Q?8i0vdfNMd8jBLDMNKO4f26Up0iTLQM/eDLgf7RH7NuorwxIYkzgPXinJ1EZ1?= =?us-ascii?Q?U43VN6Q8Tc2U9Y1at/+epACh/ceFcwmOXi6Y6N+yMBjJsuBqD+mM1MRLeo+A?= =?us-ascii?Q?CVlHsxU8UKWJk4DFbnBm+ck7K9jmNNwtRJy4pW6Qh9vX9qdEc5ksCtHTo7yv?= =?us-ascii?Q?s90fSyCXC+17SRGFPhBV8Ldy653y3PgNJxAhTSWIoTJEoTiZpPRPJXHTB0YC?= =?us-ascii?Q?FjP6uXItrnFofHlUeRgvsI9aZaVKWY79Zsc/6QlA8ekqAKJKZGndo2iA+ITg?= =?us-ascii?Q?Vbch5S3vgC8CwTwO9znMTQG8HEBUMaLJDcHwTw1abPXnvDp2DvkaJsUsqFuv?= =?us-ascii?Q?qoZAmn0prDvrbsO/1yg4sGMO9/2CA1X4bnqfiicoclJaa+dMQmCEVdokO0un?= =?us-ascii?Q?OnJptBfThTjZXJ3Mbtw=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cff6317a-f0c5-4968-820b-08dd6253af7e X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2025 17:22:52.3672 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YZsYP3aQ8N2BvEq2VM6OHpVOUKmx413F+ghUE/AyxIo+T+qJ1vg99/p+G9RVqCr4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7478 X-Stat-Signature: a6rzwe9fj8675sswje1c5dhqkg5wtkqm X-Rspamd-Queue-Id: 1C39AA0015 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1741886575-896398 X-HE-Meta: U2FsdGVkX1+r/D1YWxHtCjrnt+oBoCUBekUz2K1tyroWhPmd7XqD1b/9ORNdrsE7Gbkrjckchzv7viSJ0T8oESpl5D+uR3Js2QjmuZHonj/BjElkInBE/bjbIrMQJJo5eCIg4ZGCKpBr1skD0TXZe1NiiVJ0E0Sm4+7b8oDeIRl4F9As648n+GannVYEsorL9PrUt/jXukuHkN3Pt3x52jCJr18tQRR7nWowlQQLi91Pe00xi8N2pD+G6dciiOknYRp3lGL2Yu06dzTAUgGHL9AhUrPA9tHYo6p0TVZxaxgggdl6zEZqf/wEFestVZw2gGS7+5woeDDQGA8gdgFebjclkYThyCK2fTX9FsVavuFygygOeTpux8Ubxz3TtLkXcv2urKP/LjRRs2T6CrG/aavBvTfiV3oWlmlexOCFwWHcL/ehtq6M4s9Dsd1YCyzqCjBsNKNl/AYZUk97a1ssLQ/SsViBEtCaB4qyNEfPoVD1UuB64aqDYUfWyTZrQ3WPk1/bmnniWJT/TFKyFM5Rxk63WyL72EaoQ4Kz6401Vg0AvhOtaPPcK+tqwyNG3hdATt3p/9KE3KaD/o6DIsySkLrIWk7aTPFV1JQX6/4EcsKkCQ38zULY+J5Y3+IfU+GDjts9pJdglH/u+V42VLoQrFBioRfZXfDMpghesy3RW7ucnLcPUtETdNGC0VSQmutiz/OnthKH8tkoMkHM79HlzW+/5rxYcjuNe1S9n6DmXxnmF8PnsQuLFZ2dQTP1b7V3b/x5ogM2wl5hNyvHafhfupvVDAKtlSkl4sAUbjE5WW134Fp6Pe8XMnAOunrA9PVDXmLbKsa29WSuzq1ol5GZmMGr8NPZTw1GOnPm2/CZsLseBWnB1igiPB3NreJT5cyB5s7Kdl7R4WYBzfSKNaOc0VO0K33YCIPJ4v5hT7lOye9MCQl27ZJWSVKtg0+68n1jtuFmxgH/eIob/lV3lyF ofjqfuQ+ J6uM5+dgCPIbeH2ZJURNnRjn0fg/RkRcEm7jC5a2fCVpmTGm8EwmsSRG6wzRrcuNFD1oAU41cJ+duD/jCflIyRd3OZLBllIDwSrOkfFlsTVXYWyFUQIWzrAJj5C+JjBONs42iBdgQkdGY2YqgMLm7Jk2YDsMSmq2ByqWbG08+rXApwU2JVOI60fWROQUeKw+rgps1pJFWNh0hA/ctWNOGmgqTrpVUXdAr8pAQv6aJG9EENB7yQdoKw0F8e8+7VrC/+Ho55oteMnVuboXX/Vux8r9VWsqyaYtTtIeIVpUROqBj35F7ieWnB5ajPS7dptPhtZ8sLZkd146bk2S1O925gv6D3EWDfy0ymEj1MQ6CHSUwlej4tCTDpzgIR70JY9acXEiMaAgLu6PD6Ef0oXqdmMtiE4Bu28w5pM5gIenf8FZIwM8T/dC+DO/tDBR3U/AG3k9jLr4zwET2N58= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13 Mar 2025, at 10:58, Matthew Wilcox (Oracle) wrote: > Folios always use memcg_data to refer to the mem_cgroup while pages > allocated with GFP_ACCOUNT have a pointer to the obj_cgroup. Since the > caller already knows what it has, split the function into two and then > we don't need to check. > > Move the assignment of split folio memcg_data to the point where we set > up the other parts of the new folio. That leaves folio_split_memcg() > just handling the memcg accounting. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/memcontrol.h | 7 +++++++ > mm/huge_memory.c | 16 ++++------------ > mm/memcontrol.c | 17 +++++++++++++---- > 3 files changed, 24 insertions(+), 16 deletions(-) > Acked-by: Zi Yan Best Regards, Yan, Zi