From: Zi Yan <ziy@nvidia.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 1/5] mm: Separate folio_split_memcg() from split_page_memcg()
Date: Thu, 13 Mar 2025 13:22:48 -0400 [thread overview]
Message-ID: <17C5C599-B039-49F1-AF90-8ECF0536B4E1@nvidia.com> (raw)
In-Reply-To: <20250313145856.4118428-2-willy@infradead.org>
On 13 Mar 2025, at 10:58, Matthew Wilcox (Oracle) wrote:
> Folios always use memcg_data to refer to the mem_cgroup while pages
> allocated with GFP_ACCOUNT have a pointer to the obj_cgroup. Since the
> caller already knows what it has, split the function into two and then
> we don't need to check.
>
> Move the assignment of split folio memcg_data to the point where we set
> up the other parts of the new folio. That leaves folio_split_memcg()
> just handling the memcg accounting.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> include/linux/memcontrol.h | 7 +++++++
> mm/huge_memory.c | 16 ++++------------
> mm/memcontrol.c | 17 +++++++++++++----
> 3 files changed, 24 insertions(+), 16 deletions(-)
>
Acked-by: Zi Yan <ziy@nvidia.com>
Best Regards,
Yan, Zi
next prev parent reply other threads:[~2025-03-13 17:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 14:58 [PATCH 0/5] Minor memcg cleanups & prep for memdescs Matthew Wilcox (Oracle)
2025-03-13 14:58 ` [PATCH 1/5] mm: Separate folio_split_memcg() from split_page_memcg() Matthew Wilcox (Oracle)
2025-03-13 15:52 ` Johannes Weiner
2025-03-13 17:07 ` Shakeel Butt
2025-03-13 17:22 ` Zi Yan [this message]
2025-03-13 14:58 ` [PATCH 2/5] mm: Simplify split_page_memcg() Matthew Wilcox (Oracle)
2025-03-13 15:54 ` Johannes Weiner
2025-03-13 17:08 ` Shakeel Butt
2025-03-13 17:23 ` Zi Yan
2025-03-13 14:58 ` [PATCH 3/5] mm: Remove references to folio in split_page_memcg() Matthew Wilcox (Oracle)
2025-03-13 16:01 ` Johannes Weiner
2025-03-13 16:05 ` Matthew Wilcox
2025-03-13 17:59 ` Matthew Wilcox
2025-03-13 18:03 ` Johannes Weiner
2025-03-13 17:10 ` Shakeel Butt
2025-03-13 14:58 ` [PATCH 4/5] mm: Simplify folio_memcg_charged() Matthew Wilcox (Oracle)
2025-03-13 16:03 ` Johannes Weiner
2025-03-13 16:15 ` Matthew Wilcox
2025-03-13 16:57 ` Shakeel Butt
2025-03-13 17:10 ` Shakeel Butt
2025-03-13 14:58 ` [PATCH 5/5] mm: Remove references to folio in __memcg_kmem_uncharge_page() Matthew Wilcox (Oracle)
2025-03-13 16:04 ` Johannes Weiner
2025-03-13 17:12 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17C5C599-B039-49F1-AF90-8ECF0536B4E1@nvidia.com \
--to=ziy@nvidia.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox