LRU_GEN v2 & v5.12 build issue

LRU_GEN v2 & v5.12 build issue

[Alexandre Frade]

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]

Dear Yu Zhao,

 

 I 
don't know if it's a known issue with the 5.12 kernel released 
[9f4ad9e]: 

 

 LRU_GEN v2 & v5.12 final:

  



In function ‘nd_pfn_init’,
     inlined from ‘nvdimm_setup_pfn’ at drivers/nvdimm/pfn_devs.c:842:7:
 ././include/linux/compiler_types.h:320:38: error: call to 
‘__compiletime_assert_349’ declared with attribute error: BUILD_BUG_ON 
failed: sizeof(struct page) > MAX_STRUCT_PAGE_SIZE
   320 |  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
       |                                      ^
 ././include/linux/compiler_types.h:301:4: note: in definition of macro ‘__compiletime_assert’
   301 |    prefix ## suffix();    \
       |    ^~~~~~
 ././include/linux/compiler_types.h:320:2: note: in expansion of macro ‘_compiletime_assert’
   320 |  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
       |  ^~~~~~~~~~~~~~~~~~~
 ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
       |                                    ^~~~~~~~~~~~~~~~~~
 ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
   50 |  BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
       |  ^~~~~~~~~~~~~~~~
 drivers/nvdimm/pfn_devs.c:794:3: note: in expansion of macro ‘BUILD_BUG_ON’
   794 |  BUILD_BUG_ON(sizeof(struct page) > MAX_STRUCT_PAGE_SIZE);
       |  ^~~~~~~~~~~~
 make[5]: *** [scripts/Makefile.build:271: drivers/nvdimm/pfn_devs.o] Error 1
 make[4]: *** [scripts/Makefile.build:514: drivers/nvdimm] Error 2
 make[4]: *** Waiting for unfinished jobs....





Grateful,



Alexandre Frade

[-- Attachment #2: Type: text/html, Size: 2914 bytes --]

Re: LRU_GEN v2 & v5.12 build issue

[Yu Zhao]

On Sat, May 1, 2021 at 8:31 PM Alexandre Frade <kernel@xanmod.org> wrote:
>
> Dear Yu Zhao,
>
> I don't know if it's a known issue with the 5.12 kernel released [9f4ad9e]:
>
> LRU_GEN v2 & v5.12 final:

Hi Alexandre,

I think I hit this problem with Ubuntu too. Does your config include
the following?
  CONFIG_MAXSMP=y
  CONFIG_NODES_SHIFT=10
  CONFIG_NR_CPUS=8192
If so, then it's the same problem: there are no spare bits left in
page->flags. Disabling
CONFIG_MAXSMP should fix it, unless you really want to use 8192 CPUs
and 1024 NUMA nodes :)

Please let me know. Thanks!

Re: LRU_GEN v2 & v5.12 build issue

[Yu Zhao]

On Sat, May 1, 2021 at 8:39 PM Yu Zhao <yuzhao@google.com> wrote:
>
> On Sat, May 1, 2021 at 8:31 PM Alexandre Frade <kernel@xanmod.org> wrote:
> >
> > Dear Yu Zhao,
> >
> > I don't know if it's a known issue with the 5.12 kernel released [9f4ad9e]:
> >
> > LRU_GEN v2 & v5.12 final:
>
> Hi Alexandre,
>
> I think I hit this problem with Ubuntu too. Does your config include
> the following?
>   CONFIG_MAXSMP=y
>   CONFIG_NODES_SHIFT=10
>   CONFIG_NR_CPUS=8192
> If so, then it's the same problem: there are no spare bits left in
> page->flags. Disabling
> CONFIG_MAXSMP should fix it, unless you really want to use 8192 CPUs
> and 1024 NUMA nodes :)
>
> Please let me know. Thanks!

Sorry I forgot to clarify that this option should be disabled
regardless whether you want to use the multigenerational lru or not.

This option is for debugging and will bring unnecessary memory
overhead to production systems.

Re: LRU_GEN v2 & v5.12 build issue

[Alexandre Frade]

[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]

Hi Yu Zhao



CONFIG_MAXSMP=n worked!



The main distros are with CONFIG_MAXSMP=y. It may not make sense on desktops, even for an amd threadripper, but in datacenter / HPC, for example, it is interesting to add maxsmp compatibility that virtually removes the n cpus limit.



Thanks,

Alexandre Frade









---- Ativado Sáb, 01 mai 2021 23:45:11 -0300 Yu Zhao <yuzhao@google.com> escreveu ----


On Sat, May 1, 2021 at 8:39 PM Yu Zhao <mailto:yuzhao@google.com> wrote: 
> 
> On Sat, May 1, 2021 at 8:31 PM Alexandre Frade <mailto:kernel@xanmod.org> wrote: 
> > 
> > Dear Yu Zhao, 
> > 
> > I don't know if it's a known issue with the 5.12 kernel released [9f4ad9e]: 
> > 
> > LRU_GEN v2 & v5.12 final: 
> 
> Hi Alexandre, 
> 
> I think I hit this problem with Ubuntu too. Does your config include 
> the following? 
>   CONFIG_MAXSMP=y 
>   CONFIG_NODES_SHIFT=10 
>   CONFIG_NR_CPUS=8192 
> If so, then it's the same problem: there are no spare bits left in 
> page->flags. Disabling 
> CONFIG_MAXSMP should fix it, unless you really want to use 8192 CPUs 
> and 1024 NUMA nodes :) 
> 
> Please let me know. Thanks! 
 
Sorry I forgot to clarify that this option should be disabled 
regardless whether you want to use the multigenerational lru or not. 
 
This option is for debugging and will bring unnecessary memory 
overhead to production systems.

[-- Attachment #2: Type: text/html, Size: 2557 bytes --]