From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C65AC282DD for ; Wed, 8 Jan 2020 19:29:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 09ADC2067D for ; Wed, 8 Jan 2020 19:29:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09ADC2067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=deltatee.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 81FB28E0005; Wed, 8 Jan 2020 14:29:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CEB78E0001; Wed, 8 Jan 2020 14:29:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695EA8E0005; Wed, 8 Jan 2020 14:29:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 54F7F8E0001 for ; Wed, 8 Jan 2020 14:29:23 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 053BA2C1E for ; Wed, 8 Jan 2020 19:29:23 +0000 (UTC) X-FDA: 76355455806.25.balls71_6ef41827c0659 X-HE-Tag: balls71_6ef41827c0659 X-Filterd-Recvd-Size: 4527 Received: from ale.deltatee.com (ale.deltatee.com [207.54.116.67]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Jan 2020 19:29:22 +0000 (UTC) Received: from s0106ac1f6bb1ecac.cg.shawcable.net ([70.73.163.230] helo=[192.168.11.155]) by ale.deltatee.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ipH0r-0006vH-74; Wed, 08 Jan 2020 12:29:06 -0700 To: Dan Williams , David Hildenbrand Cc: Linux Kernel Mailing List , Linux ARM , linux-ia64@vger.kernel.org, linuxppc-dev , linux-s390 , Linux-sh , platform-driver-x86@vger.kernel.org, Linux MM , Michal Hocko , Andrew Morton , Christoph Hellwig , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Eric Badger References: <5D5ED235-EB67-4072-8CCA-C046B7EC031C@redhat.com> From: Logan Gunthorpe Message-ID: <1786a855-de7e-f9f9-d9b1-9dbe081e7360@deltatee.com> Date: Wed, 8 Jan 2020 12:29:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-SA-Exim-Connect-IP: 70.73.163.230 X-SA-Exim-Rcpt-To: ebadger@gigaio.com, peterz@infradead.org, luto@kernel.org, dave.hansen@linux.intel.com, bp@alien8.de, mingo@redhat.com, tglx@linutronix.de, benh@kernel.crashing.org, will@kernel.org, catalin.marinas@arm.com, hch@lst.de, akpm@linux-foundation.org, mhocko@kernel.org, linux-mm@kvack.org, platform-driver-x86@vger.kernel.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, david@redhat.com, dan.j.williams@intel.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2 2/8] mm/memory_hotplug: Rename mhp_restrictions to mhp_modifiers X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-01-08 12:13 p.m., Dan Williams wrote: > On Wed, Jan 8, 2020 at 11:08 AM David Hildenbrand wr= ote: >> >> >> >>> Am 08.01.2020 um 20:00 schrieb Dan Williams : >>> >>> =EF=BB=BFOn Wed, Jan 8, 2020 at 9:17 AM Logan Gunthorpe wrote: >>>> >>>> >>>> >>>>> On 2020-01-08 5:28 a.m., David Hildenbrand wrote: >>>>> On 07.01.20 21:59, Logan Gunthorpe wrote: >>>>>> The mhp_restrictions struct really doesn't specify anything resemb= ling >>>>>> a restriction anymore so rename it to be mhp_modifiers. >>>>> >>>>> I wonder if something like "mhp_params" would be even better. It's >>>>> essentially just a way to avoid changing call chains rough-out all = archs >>>>> whenever we want to add a new parameter. >>>> >>>> Sure, that does sound a bit nicer to me. I can change it for v3. >>> >>> Oh, I was just about to chime in to support "modifiers" because I >>> would expect all parameters to folded into a "params" struct. The >>> modifiers seem to be limited to the set of items that are only >>> considered in a non-default / expert memory hotplug use cases. >> >> It=E2=80=98s a set of extended parameters I=E2=80=98d say. > Sure, we can call them "mhp_params" and just clarify that they are > optional / extended in the kernel-doc. Well pgprot isn't going to be optional... But I'll add something to the kernel_doc. Logan