From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31861CD128A for ; Thu, 11 Apr 2024 07:10:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADC9C6B0095; Thu, 11 Apr 2024 03:10:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A65976B0096; Thu, 11 Apr 2024 03:10:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DFED6B0098; Thu, 11 Apr 2024 03:10:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6D5546B0095 for ; Thu, 11 Apr 2024 03:10:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2AF03140AAF for ; Thu, 11 Apr 2024 07:10:05 +0000 (UTC) X-FDA: 81996376770.02.D7A4FB3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 482051C0023 for ; Thu, 11 Apr 2024 07:10:02 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FHDwA4vY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712819402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5NgjUa+lwKskPLBb4G2miG3MSH6bZPhgAN2v8MXqMrQ=; b=FGWyCH16hjoHFTigMqCkdSk+9R7G7jZ5UsiFSFip7e4dpOACFRs3xjlfWKKmfFQTy5q8Ma nN5QGJMeLiL7mAebsOQFBIXqN+iCKuEMaDbNK3gaZelissHZsfQTkQMBsdk28a6DmKA+Fa IkiaPyvCricsE8m0ebjOTFi7Ul1TWa0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FHDwA4vY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712819402; a=rsa-sha256; cv=none; b=emZGQSxBIW0GLYtvf3pUx4Hoaz2qolOqMsiN6jlC+RQlvwwpEUg6ICJwZhje/V/ImUdBtM fGR+1pitPH7XvgvOGL+8IC+vcd4lDv+bu0tjQyByDC4U7d1mobw9wiw+AQtgdZHuJ4KUqw hu63mwNAN3rlbuTt+Jef19DwgSwBT5A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712819401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5NgjUa+lwKskPLBb4G2miG3MSH6bZPhgAN2v8MXqMrQ=; b=FHDwA4vYBXO6tUFoTzeFPJebu7+0jDtrOOYkcmfbKT8bG54CcjFbmtCrfzy1LONMJedRjq bIe7AXelR4OcVLG028GrOulUq2jmDF4jMCwhXwc8uweWEtKeacA9/aPWmohnyD2jdNqk1J 3c/TaGNQBh5+2H0vWZ0/1RZCwsx5kNE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-Lr1cEV93NVGDpSocSvNLIw-1; Thu, 11 Apr 2024 03:09:56 -0400 X-MC-Unique: Lr1cEV93NVGDpSocSvNLIw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CA3F310499A0; Thu, 11 Apr 2024 07:09:54 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F2182166B34; Thu, 11 Apr 2024 07:09:51 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240410173815.GA514426@kernel.org> References: <20240410173815.GA514426@kernel.org> <20240401135351.GD26556@kernel.org> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-27-dhowells@redhat.com> <3002686.1712046757@warthog.procyon.org.uk> To: Simon Horman Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 26/26] netfs, afs: Use writeback retry to deal with alternate keys MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1780363.1712819386.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 11 Apr 2024 08:09:46 +0100 Message-ID: <1780364.1712819386@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Rspamd-Queue-Id: 482051C0023 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ktjeimgp6j3oxpw5npqdy7arttendoha X-HE-Tag: 1712819402-320825 X-HE-Meta: U2FsdGVkX18m9wN5469KviyQgAS4spddx2FW6F5fwCzKAFW7AO0HqdiMu2TUw/Bz5tuGeYBfe08qeh3a0S0gaZHI4EMhjv2tAovcAsIJzevMXBtHg8HCxrHLgrPTtsiRX0+SvqK5LL/6XKgUdYJkuoPH5A9jm6dxVZnpaNF2TYf1A2X0ZpR+PQYIa3IZanCCqH4UWMGcJKqsPbG0F1f/gGcJusyiglPcyNiQ9uwwXJCCPytUq0fVQtTwCXvENs3acsQrNZiTXD0RBWk3j2ClQAt63QoK3ukL/wxN3pSDjJTwUgnfnjjwG4YPJlOY+uzkjy/n1noviMfi0Itb6hX5DCdJp0Iaj6g6ys0QcrqumSeozmL8gHMKn9ZO5sUOazvcFkuBllRArFzOUOvQSRO08xjnbuGZl3KbNnl5SWeYGPiC4NLA+PhPUs1TAtSFMbiXyBLGFLCI/Ao0iu1mNB2cHLgBcpYuDUbeLWqDsrjh1wNFkatxpbcJst6lPLFsSCgYgymmYmvA8CDuUJTpeLa9vkgpCi43v6WyE991SVf1NKYxkK4J7XTxQkyn3xeg1Wo+ldLj0yhRzIWVpw9NMv/shDroBn/leavkyWYAVW4/uD3970Sm4Ed2j5ZwmLZ6wXSTzHkpH6FS+CcY1FGr4SvIZgte2P8h5KdzblAq0VRSoMvbgWO7sU4Ns9em1Gt5Cjv2eK+Z1A86lJV9J6HJLjlWwatLRltUXsFZHdNT/OeaOsfG+T8DQtQe95WE73IWHbzNWD2mXHbn0WKxkMjMnofckjB3xIRWFuB5+PYcfFwOIkPGZzzC0yr0vrX4EHIZ2kV9Wc88g7fXPNRouNLorwGxF1zLe0I0mp08MNeVuI9NFSq0Azsm2DTZ3a3UuoF/R61Au0WYO8NOYNnUbS88LlkoBBSnrW3p8ZMKaabSqI/IYtlpaS7aYRoTR+Ap1Kgh30MBSbz3IjXDeNFftTtWJ9y EsEZbkYW 4Bf2bIGZJ1tgNBKHt7N5Bze2Qx+BL51MtdxVlXs1LCB6Qr/hE7TeBthPSDaUdkYyfGry4mx6vS207vtFAzS18zwxuGzlDki2AyaxRFa/UXidH6994RJQKGqZce5CwhAzInzHKVQGKU2TVUtnfbHWpJAYOX8QuRgmLg5cLfmE9wGxSOuWztPknsnBI0bdZDw3hLsHRTGAFOWN1VTM9X1OK/NAy+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Simon Horman wrote: > On Tue, Apr 02, 2024 at 09:32:37AM +0100, David Howells wrote: > > Simon Horman wrote: > > = > > > > + op->store.size =3D len, > > > = > > > nit: this is probably more intuitively written using len; > > = > > I'm not sure it makes a difference, but switching 'size' to 'len' in k= afs is a > > separate thing that doesn't need to be part of this patchset. > = > Sorry, I meant, using ';' rather than ',' at the end of the line. Ah, yes. That makes a lot more sense! David