From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55232C433EF for ; Tue, 7 Dec 2021 16:54:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC3D76B00AE; Tue, 7 Dec 2021 11:54:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B72A36B00AF; Tue, 7 Dec 2021 11:54:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A628A6B00B0; Tue, 7 Dec 2021 11:54:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id 991BD6B00AE for ; Tue, 7 Dec 2021 11:54:32 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 564D1876F0 for ; Tue, 7 Dec 2021 16:54:22 +0000 (UTC) X-FDA: 78891596364.11.15D4ECD Received: from serv108.segi.ulg.ac.be (serv108.segi.ulg.ac.be [139.165.32.111]) by imf11.hostedemail.com (Postfix) with ESMTP id BEEA3F0000B0 for ; Tue, 7 Dec 2021 16:54:21 +0000 (UTC) Received: from mbx12-zne.ulg.ac.be (serv470.segi.ulg.ac.be [139.165.32.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by serv108.segi.ulg.ac.be (Postfix) with ESMTPS id 9FC7E200DF98; Tue, 7 Dec 2021 17:54:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 serv108.segi.ulg.ac.be 9FC7E200DF98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uliege.be; s=ulg20190529; t=1638896060; bh=n5h8FzeGgzXEqqQle82qpupLUwzcL7koe3AYUv3UNDk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From; b=nMMt76n+/2Z6BjwN9U5sMmP/pcRIFuhMHIgrumaxeHH/PidKx1I0BJGc4pjQn53zg VuOlsGEXqHuuThQ8+XPRD6mnaOtdXvthRL3+5fwWEfa/sFz6okLBImSEaXgS2Zk390 AWGec4bAO/rQ/hj5C20RdW5jxRxy237/j8R4O6BhvB9W+ZELeSRtCclNUcZZZxOnCF 9HVGESpgadjpKQRitdsYKfDSAv0v9721WnOr1whk8pxnxIqgbvDryuWEnh9QdXfG2V ijHtxyY9dUqOwRuVDp1TBrYEYxjGUiypuDKiZVCB/Bmcn/CV9cckv3/9N8yDWwd07v aGuAuJv5Bn8wA== Received: from localhost (localhost [127.0.0.1]) by mbx12-zne.ulg.ac.be (Postfix) with ESMTP id 92C2160309F57; Tue, 7 Dec 2021 17:54:20 +0100 (CET) Received: from mbx12-zne.ulg.ac.be ([127.0.0.1]) by localhost (mbx12-zne.ulg.ac.be [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OJ4IGATe_JN0; Tue, 7 Dec 2021 17:54:20 +0100 (CET) Received: from mbx12-zne.ulg.ac.be (mbx12-zne.ulg.ac.be [139.165.32.199]) by mbx12-zne.ulg.ac.be (Postfix) with ESMTP id 749226008D842; Tue, 7 Dec 2021 17:54:20 +0100 (CET) Date: Tue, 7 Dec 2021 17:54:20 +0100 (CET) From: Justin Iurman Reply-To: Justin Iurman To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, dsahern@kernel.org, yoshfuji@linux-ipv6.org, linux-mm@kvack.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo kim , akpm@linux-foundation.org, vbabka@suse.cz Message-ID: <1780306528.220542320.1638896060436.JavaMail.zimbra@uliege.be> In-Reply-To: References: <20211206211758.19057-1-justin.iurman@uliege.be> <20211206211758.19057-3-justin.iurman@uliege.be> Subject: Re: [RFC net-next 2/2] ipv6: ioam: Support for Buffer occupancy data field MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [81.240.24.148] X-Mailer: Zimbra 8.8.15_GA_4018 (ZimbraWebClient - FF94 (Linux)/8.8.15_GA_4026) Thread-Topic: ipv6: ioam: Support for Buffer occupancy data field Thread-Index: OPnAWXSx+qj8/fLoEdzv0hG4gKW+dg== X-Rspamd-Queue-Id: BEEA3F0000B0 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=uliege.be header.s=ulg20190529 header.b=nMMt76n+; spf=pass (imf11.hostedemail.com: domain of justin.iurman@uliege.be designates 139.165.32.111 as permitted sender) smtp.mailfrom=justin.iurman@uliege.be; dmarc=pass (policy=none) header.from=uliege.be X-Rspamd-Server: rspam04 X-Stat-Signature: s7y3hi9yomfcxbwhp5sj1pmf3gcopqjz X-HE-Tag: 1638896061-496625 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi David, >> [...] >> >> Signed-off-by: Justin Iurman >> --- >> include/linux/slab.h | 15 +++++++++++++++ >> mm/slab.h | 14 -------------- >> net/ipv6/ioam6.c | 13 ++++++++++++- >> 3 files changed, 27 insertions(+), 15 deletions(-) >> > > this should be 2 patches - one that moves the slabinfo struct and > function across header files and then the ioam6 change. Agree. I didn't do it since it's "just" a RFC for now though. > [ I agree with Jakub's line of questioning - how useful is this across > nodes with different OS'es and s/w versions. ] See my answer to Jakub. Also, as the draft says: "The units of this field are implementation specific. Hence, the units are interpreted within the context of an IOAM-Namespace and/or node-id if used. The authors acknowledge that in some operational cases there is a need for the units to be consistent across a packet path through the network, hence it is recommended for implementations to use standard units such as Bytes." Therefore, what we define here is the behavior of the Linux kernel regarding the way it handles the buffer occupancy for IOAM, and the meaning/semantic of its value (in bytes). Having different OS'es and s/w versions across nodes is not a problem, it's up to the operators to bring more context to their own domains.