linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Justin Iurman <justin.iurman@uliege.be>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	 dsahern@kernel.org, yoshfuji@linux-ipv6.org, linux-mm@kvack.org,
	 cl@linux.com, penberg@kernel.org, rientjes@google.com,
	 iamjoonsoo kim <iamjoonsoo.kim@lge.com>,
	akpm@linux-foundation.org,  vbabka@suse.cz
Subject: Re: [RFC net-next 2/2] ipv6: ioam: Support for Buffer occupancy data field
Date: Tue, 7 Dec 2021 17:54:20 +0100 (CET)	[thread overview]
Message-ID: <1780306528.220542320.1638896060436.JavaMail.zimbra@uliege.be> (raw)
In-Reply-To: <ca0f1801-8bbb-6013-cda5-8cf924d51fc6@gmail.com>

Hi David,

>> [...]
>>
>> Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
>> ---
>>  include/linux/slab.h | 15 +++++++++++++++
>>  mm/slab.h            | 14 --------------
>>  net/ipv6/ioam6.c     | 13 ++++++++++++-
>>  3 files changed, 27 insertions(+), 15 deletions(-)
>> 
> 
> this should be 2 patches - one that moves the slabinfo struct and
> function across header files and then the ioam6 change.

Agree. I didn't do it since it's "just" a RFC for now though.

> [ I agree with Jakub's line of questioning - how useful is this across
> nodes with different OS'es and s/w versions. ]

See my answer to Jakub. Also, as the draft says:

   "The units of this field
   are implementation specific.  Hence, the units are interpreted within
   the context of an IOAM-Namespace and/or node-id if used.  The authors
   acknowledge that in some operational cases there is a need for the
   units to be consistent across a packet path through the network,
   hence it is recommended for implementations to use standard units
   such as Bytes."

Therefore, what we define here is the behavior of the Linux kernel
regarding the way it handles the buffer occupancy for IOAM, and the
meaning/semantic of its value (in bytes). Having different OS'es and
s/w versions across nodes is not a problem, it's up to the operators
to bring more context to their own domains.


      reply	other threads:[~2021-12-07 16:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06 21:17 [RFC net-next 0/2] IOAM queue depth and buffer occupancy Justin Iurman
2021-12-06 21:17 ` [RFC net-next 1/2] ipv6: ioam: Support for Queue depth data field Justin Iurman
2021-12-06 21:17 ` [RFC net-next 2/2] ipv6: ioam: Support for Buffer occupancy " Justin Iurman
2021-12-07  0:16   ` Jakub Kicinski
2021-12-07 11:54     ` Justin Iurman
2021-12-07 15:50       ` Jakub Kicinski
2021-12-07 16:35         ` Justin Iurman
2021-12-07 17:07           ` Jakub Kicinski
2021-12-07 18:05             ` Justin Iurman
2021-12-08 22:18               ` Jakub Kicinski
2021-12-09 14:10                 ` Justin Iurman
2021-12-10  0:38                   ` Jakub Kicinski
2021-12-10 12:57                     ` Justin Iurman
2021-12-21 17:06                     ` Justin Iurman
2021-12-21 17:23                       ` Vladimir Oltean
2021-12-21 20:13                         ` Jakub Kicinski
2021-12-22 16:13                           ` Justin Iurman
2021-12-22 15:49                         ` Justin Iurman
2021-12-07 16:37   ` David Ahern
2021-12-07 16:54     ` Justin Iurman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1780306528.220542320.1638896060436.JavaMail.zimbra@uliege.be \
    --to=justin.iurman@uliege.be \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kuba@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox