From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15BA1C83013 for ; Wed, 2 Jul 2025 09:05:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4CE08E0005; Wed, 2 Jul 2025 05:05:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FD8A8E0001; Wed, 2 Jul 2025 05:05:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C56C8E0005; Wed, 2 Jul 2025 05:05:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 74E808E0001 for ; Wed, 2 Jul 2025 05:05:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0C5A9807E6 for ; Wed, 2 Jul 2025 09:05:26 +0000 (UTC) X-FDA: 83618741052.26.D417ADE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 9C27540007 for ; Wed, 2 Jul 2025 09:05:23 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=esNouFNn; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751447123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UrTPZM52qS9q9n/aNzUQYR15Up7gBd3SfXHwk5IXyck=; b=jCEcJQwIOSchweg9M10huHwrF8XS5B3RaaLqSKn24ZhSoygZViEsiP8OcOb8SxR8W5wfYT C/g4tLHMrd0/PbuoifdifIU0zd6xzGJviLkoUBB/1G4Lz2imgTmipFPmUo6B1NEXfODYe+ Md8slLjLAtf2B8jlTDRWXiXAKW9mU0A= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=esNouFNn; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751447123; a=rsa-sha256; cv=none; b=ZKBh01YsUC2HpXw4TrBDF/nBqpES+T8f4N4cSivrGpbuFtgTsWTSlAe+/QvZ0SvNYfwOgk kllWnin85ZzlSgld/7W27BI3pdpOv5nc4CPCu4yqgJOVbF+lAwhTHCRNN9vq7qdGU86UC2 0xULScWJiAe1S3CjSFK916vb68m40aM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751447122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UrTPZM52qS9q9n/aNzUQYR15Up7gBd3SfXHwk5IXyck=; b=esNouFNnIk90ROlMBMuO2d4eItXQe9PI60WLhbK9bTBjppoTCF2PHR7VUY5ndJ97Wl0NYo MCEvLWkwWbBIFeWHKXoSe+w0QZ5YGeoZ/b0MKMM9Dv8r2DKaOU6NTo+Sxweg3K+x1aVPCN giO4PVJEkQsv7j3SzawDvA4BAcs8NfQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-O2TNuGyAMgOOkZb04Qh_5w-1; Wed, 02 Jul 2025 05:05:21 -0400 X-MC-Unique: O2TNuGyAMgOOkZb04Qh_5w-1 X-Mimecast-MFC-AGG-ID: O2TNuGyAMgOOkZb04Qh_5w_1751447120 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450d64026baso35273995e9.1 for ; Wed, 02 Jul 2025 02:05:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751447120; x=1752051920; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UrTPZM52qS9q9n/aNzUQYR15Up7gBd3SfXHwk5IXyck=; b=qmSNySi1BjREwlSOoRGwcZ6xkbwBo82SFHsxzMO0XAMTmcbboPPLipf9KAMupbMARS 6z/1oNr253+TRpj0NVjbonKxmEmCIQLiFzr9xnZCt9YxebdjP/OuEfCVcR0nvyN/0fs5 1BAYDTczJyWGr5zR3D+fDuKO+v5BX7g3QINrmjiOxKsy+kGSgJAi293h1H9MxgwlG6o3 2qAAtmMtiKrLv+nMSj27+gXW5gdL0cpMGponjHeYLOKoPsphliWB1mtYNssgs1niKwjr PLzuq81LFm0DQsZPaeZhvtCIWC5EDl4u2fSIGEhpRMWERw9rOT8HnPxdGbMB3FE88hej DhMA== X-Forwarded-Encrypted: i=1; AJvYcCU2j35HXkrrJUhIM9D+L+qBuDMVecX4eIC5rti/nCgcL+0S2X6W0DtsriITio5jQDHRK/uyfxgOrQ==@kvack.org X-Gm-Message-State: AOJu0YwQvzmCPPaQpcXu0R1UOCKASksZXEygWjiwEqFawaK0NXgjanBn vaMdevNXbWkC06lt/C55kMYA6AJpyFRmuWAD7zsvZPurE8MNc3fYVA81tH3K+bef6hJOaFc9dCk 42tEPVgr+fDWUnKO05A3uuQT8Y/1KZgKXeBrcZgaidFBh4ziILOZX X-Gm-Gg: ASbGncuXo0GmB+12yYXHCrrJQDpXWxoSIMktORe9DmbADAaLpRYz2CxV85xtspgnhMc D8hfaox7ItDQ/1Ce9oUyPZcGHML+n8+UwCeNca/om/8+HshUeJULnaOkMnLPqU0/W6WsDArzenv Xv6JXZ/WiW5SPNRMkQjGxK2ujgQJB2ArX4s3tWLoASktINsGA/P0mFDbHK5emA8+kZMiYIzC0Ka fY67x444za4L7qK1oBbqCsUzEl0pJ/0MGf+RkV6fnSrNsWpt4HHifxnvJTUBnuXfymltRg380pR fcfXj3f66G8UaNEyH1QkTC3eMzFl07IAxJiLYaTTmLLXDkqODXfkPrs= X-Received: by 2002:a05:6000:490d:b0:3a4:dbdf:7154 with SMTP id ffacd0b85a97d-3b200e2a077mr1469896f8f.54.1751447119878; Wed, 02 Jul 2025 02:05:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzCdEgUymscyusw/8NK48d6wkfe1lKLwo8hfN7RsLT+sS2rYBbIp2VSowfg5jJF5eFRrZb9w== X-Received: by 2002:a05:6000:490d:b0:3a4:dbdf:7154 with SMTP id ffacd0b85a97d-3b200e2a077mr1469867f8f.54.1751447119443; Wed, 02 Jul 2025 02:05:19 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233bd14sm225463345e9.2.2025.07.02.02.05.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 02:05:18 -0700 (PDT) Message-ID: <17777b93-41f0-4943-963f-0330489b01bc@redhat.com> Date: Wed, 2 Jul 2025 11:05:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] mm: split folio_pte_batch() into folio_pte_batch() and folio_pte_batch_ext() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-4-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yhaKWl7ZJfNJo-1TPbMWFAHTTk9uQvCO4jLhcRQtHnU_1751447120 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9C27540007 X-Stat-Signature: cffupdbq7nxn83a5xysh338864hkxzu7 X-HE-Tag: 1751447123-906305 X-HE-Meta: U2FsdGVkX1+4qeHW3Q4GdFwr3EvePJXCxPfYn0mrDb1oVlc791bJlepoMFb0f/YBZD7vy2em/fuuIdJsA0PTxvIsMM5pCcDzHrn6M8n3/UkQ5srr7GPvccSCA4oP3+iBw74iz2gM9hPHsrpn12JQ96/sBiA7jS4tIIiQY5n9BsvzFMXS/QtMUpGenrmoGslDLTY+DEsctF9s4u0q/f0wZyNjwF/k4gRz7SaKRHA20vb2Pir6hEp/J2VoOvqSlSW5KD1YE/iP/azVe27bnIbh08Jqwas8FlchvgF7fIl/Y8pHtYpi3/lFyFHmhLHMk2JneHWbDPWDgIuwGlthtFpANEFhKZt09r0VFTmyiEUX/yRNc9PR6+auvpUjEnUEHXjEStL3IFGnPMlFDT6ZIKFnIAM8jND36XKgd8qNr+wp1/ik6J6qTrB/XtwC2PaHp4UZhpm9fR8D8qS/TPzGS6zMlTHHPWLjrDk2x8lK/S471LAkG2kUfq2kGv43RUSfCoK1pYnGSU+Z3BrmxJmye0U8hCrXsthzKv7+qMH9Y0Nxy+hu2LsUeXJK+jibhn1itCOW3gj4PNe556aeSzBk7E5+E6jKnFVk0qtGDGda0ibg+VGU3KulBQ4SUyCVJikQZPspbF4rM+BHoETaTfyk7/v5NeLFRPajx1jpKpvmDe1SZaXsDwuECshKHhb+OWRhWC/EZT4nYdXJkCX2vuH+QcaKuUWgCBsLmLOt2cqnTQH+tL5spKqXMJVLwNMAhhAC2eskS8Fz2WzVeQA9hbNRdrAWQs01DNVEXgSDgv/DA4QLK63kiaBnaO33qff1e0oMbeFn8r7xTN1FQN1wFZmJWLMHQqACIxgAs/GcpFFtGBfNkp28RfQIk0o7pgwLlK6laY+KDjDVZD7Rr44XAb3MGJ/09UeG8zsjMzXS3YRswZ78LqVlGrz/Qr2/BOv5K/ngSJUD/3Oet2B70vb85sNpsGc o1Z+Z9jn DZ/MpSlmxu19PDQ8DRe+ZPEfpHBNu0WsP6XYX4TtxXscOTEqTsIPk+rOuGRl2esoMhcdissshiA0efcRPNIhBMnBdyVMbQC0qM0gj9HWwn622zyip7irfzFnIY+FpmGljQIhKxpsRL5R8Mjipk62eKQmbKNzrO7VM0DBJRg/U5lL5QeTW7TlzXhMe4QnVs1qm5u+UfK4zyw+mM1XN+sNDvp6Q87BN+znqfE/2BxT55H+wsn84zZAEmQ9PLGvG0hPsqG/k2F2KYIaPApR/o4iqFOtviIMyJ2OyxZVXjoCp5mHbRb3adFC2SIlPUU519MjL/n1CPQv416SLr60MdOEJg8A4x5vNSVjGkjj31Wv5gjOjC9GgVuyKW3PNvIPSkSdhr+uhBfwgUByyKUW4aW3hdlaXfy3kQ8Hpoyia/yr1aJQQjXVbzEwp7+oLYzBJstYH5E5vCvfOdpHq/8BSHHnYpXY3r+k353CRFEnKGJ7bNDnBXMtvsuDn+by1KAigFzYQx6fFE00SWkWBHsthpo3nbjUwMxjelLrr9k2JkHZS5Q54XuL55/5YPYZoOrfLRs1omE1n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 11:02, Oscar Salvador wrote: > On Fri, Jun 27, 2025 at 01:55:09PM +0200, David Hildenbrand wrote: >> Many users (including upcoming ones) don't really need the flags etc, >> and can live with a function call. >> >> So let's provide a basic, non-inlined folio_pte_batch(). >> >> In zap_present_ptes(), where we care about performance, the compiler >> already seem to generate a call to a common inlined folio_pte_batch() >> variant, shared with fork() code. So calling the new non-inlined variant >> should not make a difference. >> >> While at it, drop the "addr" parameter that is unused. >> >> Signed-off-by: David Hildenbrand > > So, let me see if I get this. > > Before this, every other user that doesn't use the extra flags (dirty, > etc...) will end up with the code, optimized out, inlined within its body? Not necessarily inlined into the body (there might still be a function call, depending on what the compiler decides), but inlined into the object file and optimized by propagating constants. > > With this change, a single function, folio_pte_batch(), identical to folio_pte_batch_ext > but without the runtime checks for those arguments will be created (folio_pte_batch()), > and so the users of it won't have it inlined in their body ? Right. We have a single folio_pte_batch() that is optimized by propagating all constants. Instead of having one per object file, we have a single shared one. -- Cheers, David / dhildenb