From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05BE4C6FD1F for ; Tue, 2 Apr 2024 14:14:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 637F66B008C; Tue, 2 Apr 2024 10:14:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E7BB6B0093; Tue, 2 Apr 2024 10:14:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 488196B0095; Tue, 2 Apr 2024 10:14:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2BBB96B008C for ; Tue, 2 Apr 2024 10:14:29 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DB16B1601C4 for ; Tue, 2 Apr 2024 14:14:28 +0000 (UTC) X-FDA: 81964787016.14.73B8C20 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 75467C0010 for ; Tue, 2 Apr 2024 14:14:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D9E5pNIW; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712067265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2JLn1owCc/szPDktX3u/BgafQ42qH7URBw20CKsDE2k=; b=dShVME6ZIo8eZF8bHo+5dxUpAE8EAW2Kryx6rJteVOqOHyOm0wa6vN9EU2rlCytlO3zEt+ 9TX1Z0PiNu8DlCtmyUjHJp9u6R6op/Ypo1bM7aQm7L3iZsLJmeZUgVt8utBu5PLEyV3XjG tW6PoAzTNKqCcsPx0DZbbZn1+fiXdHM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712067265; a=rsa-sha256; cv=none; b=XHFnLp2CbGWpP1UiRdemwDb8P2i10UeqZMvsoiCQHlghjfMStIk3ynaVLVxPYQU/cLF+HN Ox1bIXKFO4sC7usVw+wrm/7yfbPX2qZRlh9lCwb9AsbB3fwp1gZDv+ZDvIdyDwGG0YjtJJ TS0CGpfUc7tJEdMfYU75xRQ0SZQYbcE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D9E5pNIW; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712067264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2JLn1owCc/szPDktX3u/BgafQ42qH7URBw20CKsDE2k=; b=D9E5pNIWzmR/jZa8DyhIu0q+rBWru/bfAF4Yu/jLI8eSkHxmku3f0GrDXkFFOFyiuWjiuh 40o53X76p+sXMnh82XRWXSEE8k9gyIqZTvVzFaARaQZxH2SYKu5Pv4sxgzpWDeaYnnJnNq S+Qp+/v3aegb95lXm2tflKNO5as0tjY= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-sD9EI6dbM96wOk8h4_24Hw-1; Tue, 02 Apr 2024 10:14:12 -0400 X-MC-Unique: sD9EI6dbM96wOk8h4_24Hw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d4a0c99d66so35289741fa.3 for ; Tue, 02 Apr 2024 07:14:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712067251; x=1712672051; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2JLn1owCc/szPDktX3u/BgafQ42qH7URBw20CKsDE2k=; b=u9ziKdI7n+9TRenxhTZWaPlhPftrvbBBrEFedSTYcQKb6Flho6rwQlme8xJrF/34k2 w24VYwq1xY0wdxZDo02dWxvNGQxs9Lv8kOMGOx7xWUgPvPIkSYgs33YTEPTZzE3PMifD Huo2VqSWfQuuE1N4qSYMJHSVTWmIGahvQJSnH6E+nCgGvo0sKsetqE765lVX4t2ZEMSv 5pJRZNbF8lfHvNSUi2Alg7mPrVACmuIrn1oH3gbkDeW3cxdhe8xp2dUOBMHUtyuA5P2v K5EsCa/bNKQyL26Wd+oBS8/0m4tudmVsurnK+xDaFba+F2uviduN79b5L1/g4h9EjzfS EdRg== X-Forwarded-Encrypted: i=1; AJvYcCVcIJY7sZEW48owvce4LMkwbYzpZGS8V32yXrEW7Xva8pd/QTOdNyN9CspO52qkFgVzf9VTL4Rjc/UFdTHFVYLgu0U= X-Gm-Message-State: AOJu0YwkPgJkWixk3fp6x++GdVelFlmYpiFha8q7ztA9MPG6DKdIkMmF LN2tVG0BBWj0Zy+C0Rbs41ul0e0qkGSzd1pGXqo/48Es1gFwyQ9/ES8gGJF50EcumAK9rHfNbvk CPx/yJ2vFEWU06fHJXw69kVCgs+e3rTjwN8Rhkf9X4G6F0OM4 X-Received: by 2002:a2e:b0ed:0:b0:2d8:1249:a047 with SMTP id h13-20020a2eb0ed000000b002d81249a047mr5766858ljl.41.1712067251192; Tue, 02 Apr 2024 07:14:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1pJhE8Jw0opzwPiJYg69uUNKw/UmEEjarbvxgKL/u2GymOP8Qih825dO/Gh9D/1YPFeggQg== X-Received: by 2002:a2e:b0ed:0:b0:2d8:1249:a047 with SMTP id h13-20020a2eb0ed000000b002d81249a047mr5766831ljl.41.1712067250737; Tue, 02 Apr 2024 07:14:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c732:e600:4982:2903:710f:f20a? (p200300cbc732e60049822903710ff20a.dip0.t-ipconnect.de. [2003:cb:c732:e600:4982:2903:710f:f20a]) by smtp.gmail.com with ESMTPSA id k35-20020a05600c1ca300b004156afd6843sm4887490wms.18.2024.04.02.07.14.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Apr 2024 07:14:10 -0700 (PDT) Message-ID: <17756b00-b051-40de-afa2-c3df97de755f@redhat.com> Date: Tue, 2 Apr 2024 16:14:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 1/8] mm/gup: Introduce unpin_folio/unpin_folios helpers From: David Hildenbrand To: Vivek Kasireddy , dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Peter Xu References: <20240225080008.1019653-1-vivek.kasireddy@intel.com> <20240225080008.1019653-2-vivek.kasireddy@intel.com> <54381897-35bc-442d-951d-b9a89f16b1a5@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <54381897-35bc-442d-951d-b9a89f16b1a5@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 75467C0010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pjzhodgxyefe8j88ggjhdxoo45wfk9ot X-HE-Tag: 1712067265-415768 X-HE-Meta: U2FsdGVkX1+misPvhn/yTENzXdG+HUnfKJsCT4M6hSoHGhvFhRSj78VZZymNp5N6RuU6xTz4YuFU0FWa1Gt5SN2u/k2aoQSLCodaz8PzpZVHXxLUZ9K6LodnuPIH7wIwpWOPY/Btg0k49zCU29q0IQkm7xulc4aDmK2MvO00GPcPXofv+QsXED+YCx8kDaJ+2tPvIO3myv8xKi+fvvDRDzXbpD/Z3AteceKf360UMr8z99fE7VxkWb0KTLHmtQCRj6ONp6lUBejdjtghBoNghvXZeqt/BerbmL5sdjEXbG4Ox5p/g2RT7epc0RwFhUJd43cXbTCX05+Kbj9wpSdT3P20BQaju87LbRG9c8TjZue3X74Gto9lIMippentLbWTDpmbRYF1kanGh82J/gbQXxAHps1K1XqauZp4sSSCo+MAjuTmCMPY33LuguehOuqT4BGc67icVYKNMcyjZ69DDT7U5p85ZmD2Jw7qx7qRFhUmT5X6Mk+m8k08o2WarRMDoX01j8nCnUPYM7j6Y75i/B1xRh9tbPSLx8+mm8hQn+WwWBjWFoU4BlHix8UtmC8arQN3L0nIrCFm8K6sEppTveoOWeg5zkYogETYbC1neCnrLwpXEA6MiUorYCOensrxkjFJWaGQTv4DgQh26hXdpdO3HC5UG1lbWx5yprW1e6nKUCayC6SSTf//a9yO+kUGe9jDUj/9y03dfLlYY6hyOTzh0FC/z7hRgN7bAUvwOB0LMGgy5B+f3RQ05FbI3xoDB2ENhwH9pSeI1LgZ2LcOZWObHEuDJr3pTcZstcyOgf66ka3ha5olUKuJvMSCQ5HMS8x7DBYVdVthGHR+rfJRovCWvcdde84qXt87iLTSbusZ6UOrQQOdoxWoHB6y45Cyl5LfUwh7ujoARwDxcrPDtYgG2OGKGZijzQtqTEd+OkJzgiTBfxvGaJ5eNp+IKlkYu7TGmnKKW5F1lpJVjN5 34XePX4W U51Gsb17zT46K1dq1HaPMQ8l/uVw1ydoOOL4C5Hua8PKZR6v+2d4edldMlN1U5HIeYQedAFM1UV9iFEvoOa0iJSvY1g9mBH8K8CcbB3taTTLDKNgRWE7Fz9wmHZELK2mPSbhaz2Z02zxnHs05XWKilOC0/FTErcYeaRBShBIb9iCvTxZcLUklaqcjd4VoiMcxocQhXOxuw6ky6/cJ44YYDNZm4lPxpHR/iaAAgl2ARRVDMXwvMwK6ActXq56p2i1yRDqtw+6M8F1J0h4ELQHfyLVPl1MRwnfoFr5U/HoQXQGRFxlGyZDtCbyuRJIKFm9ctHDeL8JLVV70BAHXkyoMzTPB8u+Gxon0tK7tMdkfzX8wVkX0jsYTF8Dj4YZOqSZFjEHqw5H3EZNTdVGFxUPUu0Pfk0cTFyW2DxnoKGcg99V8BU8uvccQrfZz8Vwcm1Uq0lObEDhqXgk3QmI3kfX+QllFrpI8F10/v4VeBMIFMEEk6A6w5xLSaQHa25CyAL94tT47/j2YwRZ3UGM2VHfkjKc5o2igqz5pGvk7hv9MVc7HQZwOdYmu6JndOBeJwhw5F87HZQqia9ZUqnNARt3yP+kMPMNMfGCV9w+H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.24 15:52, David Hildenbrand wrote: > On 25.02.24 08:56, Vivek Kasireddy wrote: >> These helpers are the folio versions of unpin_user_page/unpin_user_pages. >> They are currently only useful for unpinning folios pinned by >> memfd_pin_folios() or other associated routines. However, they could >> find new uses in the future, when more and more folio-only helpers >> are added to GUP. >> >> Cc: David Hildenbrand >> Cc: Matthew Wilcox >> Cc: Christoph Hellwig >> Cc: Jason Gunthorpe >> Cc: Peter Xu >> Suggested-by: David Hildenbrand >> Signed-off-by: Vivek Kasireddy >> --- >> include/linux/mm.h | 2 ++ >> mm/gup.c | 81 ++++++++++++++++++++++++++++++++++++++++------ >> 2 files changed, 74 insertions(+), 9 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 6f4825d82965..36e4c2b22600 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -1601,11 +1601,13 @@ static inline void put_page(struct page *page) >> #define GUP_PIN_COUNTING_BIAS (1U << 10) >> >> void unpin_user_page(struct page *page); >> +void unpin_folio(struct folio *folio); >> void unpin_user_pages_dirty_lock(struct page **pages, unsigned long npages, >> bool make_dirty); >> void unpin_user_page_range_dirty_lock(struct page *page, unsigned long npages, >> bool make_dirty); >> void unpin_user_pages(struct page **pages, unsigned long npages); >> +void unpin_folios(struct folio **folios, unsigned long nfolios); >> >> static inline bool is_cow_mapping(vm_flags_t flags) >> { >> diff --git a/mm/gup.c b/mm/gup.c >> index df83182ec72d..0a45eda6aaeb 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -30,6 +30,23 @@ struct follow_page_context { >> unsigned int page_mask; >> }; >> >> +static inline void sanity_check_pinned_folios(struct folio **folios, >> + unsigned long nfolios) >> +{ >> + if (!IS_ENABLED(CONFIG_DEBUG_VM)) >> + return; >> + >> + for (; nfolios; nfolios--, folios++) { >> + struct folio *folio = *folios; >> + >> + if (is_zero_folio(folio) || >> + !folio_test_anon(folio)) >> + continue; >> + >> + VM_BUG_ON_FOLIO(!PageAnonExclusive(&folio->page), folio); > > That change is wrong (and the split makes the check confusing). > > It could be that the first subpage is no longer exclusive, but the given > (sanity_check_pinned_pages() ) subpage is exclusive for large folios. > > I suggest dropping that change, and instead, in > unpin_folio()/unpin_folios(), reject any anon folios for now. > > So, replace the sanity_check_pinned_folios() in unpin_folio() / > unpin_folios() by a VM_WARN_ON(folio_test_anon(folio)); After reading patch #2: drop both the sanity check and VM_WARN_ON() from unpin_folio()/unpin_folios(), and add a comment to the patch description that we cannot do the sanity checking without the subpage, and that we can reintroduce it once we have a single per-folio AnonExclusive bit. -- Cheers, David / dhildenb