linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: CaoRuichuang <create0818@163.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	Liam R. Howlett <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Mina Almasry <almasrymina@google.com>,
	CaoRuichuang <create0818@163.com>
Subject: Re: [PATCH] selftests: mm: capture write_hugetlb_memory.sh exit status
Date: Mon, 06 Apr 2026 05:35:12 +0800	[thread overview]
Message-ID: <177542491250.2079.13359792600713218361@163.com> (raw)
In-Reply-To: <20260405132057.c1ae7267911c5657cd5a3fe9@linux-foundation.org>

Hi Andrew,

Thanks for the review.

I re-evaluated this after your question about the backgrounding model,
and I don't think this patch should move forward as-is.

In the async branch, write_hugetlb_memory.sh is invoked with -l, and
write_to_hugetlbfs prints DONE and then deliberately sleeps until
cleanup_hugetlb_memory() sends SIGINT. Waiting for $write_pid in that
path therefore blocks before cleanup runs, so my patch can deadlock
instead of reporting a meaningful exit status.

So I'll drop this change for now rather than push a flawed fix.

While validating the test on a minimal Ubuntu VM, I did find a different,
reproducible issue in the same selftest: cleanup currently depends on
killall from psmisc. I sent a separate patch for that one.

If there is a clearer direction for simplifying or tightening this async
flow after -rc1, I'll follow up on it.

Thanks,
CaoRuichuang



      reply	other threads:[~2026-04-05 21:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-05 19:46 CaoRuichuang
2026-04-05 20:20 ` Andrew Morton
2026-04-05 21:35   ` CaoRuichuang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177542491250.2079.13359792600713218361@163.com \
    --to=create0818@163.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=david@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox