From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F99C00144 for ; Wed, 27 Jul 2022 02:10:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E22726B0071; Tue, 26 Jul 2022 22:10:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD1C16B0072; Tue, 26 Jul 2022 22:10:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9A296B0073; Tue, 26 Jul 2022 22:10:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B9D7E6B0071 for ; Tue, 26 Jul 2022 22:10:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8E4561A0720 for ; Wed, 27 Jul 2022 02:10:17 +0000 (UTC) X-FDA: 79731250074.25.915FEE3 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf10.hostedemail.com (Postfix) with ESMTP id ED0A9C00AE for ; Wed, 27 Jul 2022 02:10:15 +0000 (UTC) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LsxyZ2NvrzmVDK; Wed, 27 Jul 2022 10:08:22 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 10:09:51 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 10:09:51 +0800 Message-ID: <1774d0f6-9607-0111-c940-f0bd2b4f7c75@huawei.com> Date: Wed, 27 Jul 2022 10:09:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mm: memory-failure: convert to pr_fmt() Content-Language: en-US To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: Miaohe Lin , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20220726081046.10742-1-wangkefeng.wang@huawei.com> <20220727011203.GA3346517@hori.linux.bs1.fc.nec.co.jp> From: Kefeng Wang In-Reply-To: <20220727011203.GA3346517@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658887816; a=rsa-sha256; cv=none; b=ERgJkQe1WPZOTnTPIR+8r6fAjulfwE3b+av/Csn+hq9yHwLtzCmgqwxgzq8zAZP2obXpAf MD7NoeJA0rPyxDYtEVHwKA18n2maZ1BgCrKxywaZFPCM0u6M5fKewr+u4bhqPTX+7Gs5Ee Ri7YBOOL8A0gPW7LL2MPmseP+tJOVfg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658887816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xJLkHqsnmmLgWmD2TphrM1rQUsTWKtR87aqCg7Vs/fg=; b=kHKii9gvrF9MFkEzO3Mf18ZyKOpDQTKOM3K13D7VBkjQ2eJ1EXNEAPyUax53bTK/SqTK9V FBB9Q2SWhXJcVEvF0B1zy7kQFkuv42ZMuiCtq87kaZPhkrsD3MHxEGPh1Q950g818EzD5I nq0cR/+nXXekP25V+W0bWGx9Ve9kG9c= Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam04 X-Rspam-User: X-Stat-Signature: 6hobfbeqz8f91gwps6wtmaggfbsmgjz1 X-Rspamd-Queue-Id: ED0A9C00AE X-HE-Tag: 1658887815-695978 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/27 9:12, HORIGUCHI NAOYA(堀口 直也) wrote: > On Tue, Jul 26, 2022 at 04:10:46PM +0800, Kefeng Wang wrote: >> Use pr_fmt to prefix pr_ output. >> >> Signed-off-by: Kefeng Wang > There're other classes of prefixes like "Unpoison:" and "soft offline:" in > mm/memory-failure.c. So simply adding subsystem-wide pr_fmt() changes to > print out two prefixes like below: > > [ 1479.892348] Memory failure: soft offline: 0x1b8200: page migration failed 1, type 0x57ffffc00a000c(uptodate|dirty|mappedtodisk|swapbacked|node=1|zone=2|lastcpupid=0x1fffff) > > [ 1486.871130] Memory failure: Unpoison: Software-unpoisoned page 0x14f00 > > Do you intend this change? Firstly I think they are all in memory failure, with this prefix is no bad impact, soft_offline_page() and unpoison_memory()  are used by error injection, but soft_offline_page() could be used in memory hotremove, so let's add '#undef pr_fmt' before unpoison_pr_info definition, options? thanks. > > Thanks, > Naoya Horiguchi