From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B0BC433FE for ; Wed, 23 Nov 2022 23:12:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01AD36B0071; Wed, 23 Nov 2022 18:12:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0CE06B0072; Wed, 23 Nov 2022 18:12:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD4C36B0074; Wed, 23 Nov 2022 18:12:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C9BF36B0071 for ; Wed, 23 Nov 2022 18:12:18 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 50D2C1611C8 for ; Wed, 23 Nov 2022 23:12:18 +0000 (UTC) X-FDA: 80166257556.25.B065C55 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id B27DCA000F for ; Wed, 23 Nov 2022 23:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669245137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TkxA1cIIATavm/iPtlXYSGrzNrGGRTB0SyxFP73JEEI=; b=UdKJMxMhuGQmgJAVVb/Mf9IsYGAdgjOVx5Ba3TxDu5BIH/+O5VbKYVLxjbvQ+nm6j8tRkN jBPIreIn6vpSCAYM25/cike3+Suh53kRYWRq9izQsC72MXWXOzDqAQzsCLGN7S7sKjOM6k EVXx9fV2JN9Bm+jETZ/NIkl9EUDF8vo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-WtuaIJijPBK1sk1Q4hzqrw-1; Wed, 23 Nov 2022 18:12:13 -0500 X-MC-Unique: WtuaIJijPBK1sk1Q4hzqrw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9662F3C0D193; Wed, 23 Nov 2022 23:12:12 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69F811402BDA; Wed, 23 Nov 2022 23:12:10 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <166924370539.1772793.13730698360771821317.stgit@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, Ilya Dryomov , Dave Wysochanski , Shyam Prasad N , linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, Dominique Martinet , linux-mm@kvack.org, Rohith Surabattula , v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, Matthew Wilcox , Steve French , linux-fsdevel@vger.kernel.org, Jeff Layton , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1774226.1669245127.1@warthog.procyon.org.uk> Date: Wed, 23 Nov 2022 23:12:07 +0000 Message-ID: <1774227.1669245127@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UdKJMxMh; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669245137; a=rsa-sha256; cv=none; b=oaL7yEXvo9iXjBq7Pm0FIR+UNzqbkJxJSB+y/gK/vAJ46yq1buHmbWrZWJMu6JtcSKhPqM GsFAO4LKpwcJHxEJ0zBCo/fx/D8IkIl5YAjdPRSGKEvWKkqcnK3mETSee89xkKs3aJzHfl CviNsBimbsu1xAz2u2mjKBwxu1RDg3w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669245137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TkxA1cIIATavm/iPtlXYSGrzNrGGRTB0SyxFP73JEEI=; b=ub70dGwQnuMthV4dLLvUiEUo+iZeHB5SlbR+l2HxMlQJtL9lXZIz7Px+/beLdW8+P5Y4oh SuCnnvEuH7hNvRsG0Ck9ph0PftKk31cC5cYXWb1a4X8EEMvMYNkGgv+q7H/cWHqNP47x+j h4Q9C8onzXxL/KeIch5rLuSTp+LLLq4= X-Rspamd-Queue-Id: B27DCA000F X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UdKJMxMh; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam06 X-Stat-Signature: a935ypf8hgxp7yr1etiw7h6y1u6kz59o X-HE-Tag: 1669245137-741276 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Linus Torvalds wrote: > Well, the patches look superficially cleaner to me, at least. That > "doesn't seem to be necessary" makes me a bit worried, I meant that it doesn't cause a splat to appear in dmesg saying that an unexpected flag was left set. David