From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4A9C36008 for ; Tue, 25 Mar 2025 19:22:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D71BC280022; Tue, 25 Mar 2025 15:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D21CF28000B; Tue, 25 Mar 2025 15:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9B38280022; Tue, 25 Mar 2025 15:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9CFBE28000B for ; Tue, 25 Mar 2025 15:22:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 97AFEC0D93 for ; Tue, 25 Mar 2025 19:22:10 +0000 (UTC) X-FDA: 83261044020.17.3615A0C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 2572F40008 for ; Tue, 25 Mar 2025 19:22:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CNKs7I7U; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742930528; a=rsa-sha256; cv=none; b=jMozLNrLRkxUkMH1U7i35/XkkDOTgfD2KIyaKsKA0nK/Jl3Ia3SlSLqsRA3SQ9VKpplHGX CQ5R1yGy/n9gAUl94v2idRiu5YYbLzUY0/nHm7t9hSes3D8guB2aWFcJwfAcL45LdtjK6P kZTnt8PQUBGALyL7Q78OFZwGBFEzwXg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CNKs7I7U; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742930528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4uusw5Mfq776t99OEEpC16y3um4OcX5n1LocwgSdxeo=; b=3aP+wWs2TJcZZHAYlfaIUYz0tLSG0cQXh85IpUpQFbouzHpHV/WbunVHRrIQhyeTSuHcEU Yu6vob6PU8YKCG3ZIOhcljE6qVjy9fALmvWFsbbOP6lR9NdCcAqZ2YidezgTXCRiGAuDdp LH67xIddIjaOQYoNgYQSo8rT/cazuxY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742930527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4uusw5Mfq776t99OEEpC16y3um4OcX5n1LocwgSdxeo=; b=CNKs7I7UhFhCn24rWHS0dFIBNww+U+zrRW2SBVma4fkzWydf/rne754cWHLkzpF/TkHW5z l2HTtb7sMvD4GPwSdelcrLIMLm8u3tcCvOC6mkvaPEOiA1FXXmbOXHAnp/uks8bdyp5JMj QqjsRi3S4HxDZk4HBayAlrGxvVSQ51s= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-382-Z0_ffp95NZqljRqSHXCj7Q-1; Tue, 25 Mar 2025 15:22:06 -0400 X-MC-Unique: Z0_ffp95NZqljRqSHXCj7Q-1 X-Mimecast-MFC-AGG-ID: Z0_ffp95NZqljRqSHXCj7Q_1742930525 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c54e9f6e00so25444785a.0 for ; Tue, 25 Mar 2025 12:22:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742930525; x=1743535325; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4uusw5Mfq776t99OEEpC16y3um4OcX5n1LocwgSdxeo=; b=OvRAStMShp4UeEGGdNUVuMQKjinFKenYTC8kdJUD3iNR592qHjT86/YlY4l2jAhnE9 8kLCvm+u0epoKGgZTgutxwK1IljpeTeh8Iv2Rarcfr4eWzRYZT+K5F84RcTb53P7mZPH bS7C82K7kDVb0q+itp5K2ZBFdIBETaELL73wjvDHY/N3PI/EL0jgZm7RIqKqHt7Enu/0 kmkXTAvWAiabuLGBcMm76z5tDn+Va82Xp/adD9Eq9N3wu3p7mJUAl4ZeZmuhVEOH4bWc L1kpwHZRNZ8A9J8Xqzbyp8FPoqaOS+6Czfn4899g9/Z87/ley1ZzW/mZYYGb3VWhoSfY sPig== X-Gm-Message-State: AOJu0Yyh8mAjRYcsQvHb+xFOs1bDp+qlf7uCZZPzXyuaRWwoFB6PUJje 80J8acF9fAdqY1YfjINSAs0xoJSqnvQT3FYMQSRwE/xKmynUqI92Xod6yr43qydzu0WZCUELF6n d5cLejRQWkaG8GCZ5ku7ZhKsuBFcoBThMc90UYP9wqAS1+v8T X-Gm-Gg: ASbGnct3DDi2EGDgUAsAV0H3oaRoYtvkvfzDn5T9hlnHhzvEq9E5pjtgMr3tTsbUX95 Y4hoe94OI8YECJf7RtmnX7hCBFzf7u+CHK+jCmki7gUuIZwSXh3aAVOckmT3n+N0mLSlFdFgKBT DY5ilxy6dtZMVz7dvu1j90qmLiMBdj058X0GPvhsNC2QCD5Zxg0uM2M2r6BxPbLkLfvAL6j3Nxg UJdTqOy2y0m+Gtf555rvVZti41iSIhTe6sUQLVtBlmCUe0rAgq9obVmzmU7XpCnBy/dksgK8tGV Y0hyC/8BG+6o X-Received: by 2002:a05:620a:1d03:b0:7c0:a264:4de1 with SMTP id af79cd13be357-7c5e494b431mr151018785a.24.1742930524605; Tue, 25 Mar 2025 12:22:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEXSfDMRz0JKf36Wpss30g3vtLjnFK8ezZQX4sG9FZ6Z+Fvfb2FbRMSHP6VydBgJHZ4ZfB+g== X-Received: by 2002:a05:620a:1d03:b0:7c0:a264:4de1 with SMTP id af79cd13be357-7c5e494b431mr151015185a.24.1742930524235; Tue, 25 Mar 2025 12:22:04 -0700 (PDT) Received: from [172.20.3.205] ([99.209.85.25]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5b92ec63dsm668951985a.62.2025.03.25.12.22.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Mar 2025 12:22:03 -0700 (PDT) Message-ID: <1767a68b-cb2e-425c-86bb-bc8e5289ee99@redhat.com> Date: Tue, 25 Mar 2025 20:22:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: mm: Correct the update of max_pfn To: Zhenhua Huang , anshuman.khandual@arm.com, catalin.marinas@arm.com, will@kernel.org, ryan.roberts@arm.com, mark.rutland@arm.com, ardb@kernel.org, yangyicong@hisilicon.com, joey.gouly@arm.com, quic_cgoldswo@quicinc.com, quic_sudaraja@quicinc.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com References: <20250321070019.1271859-1-quic_zhenhuah@quicinc.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250321070019.1271859-1-quic_zhenhuah@quicinc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: I7hwchdbKVpWsNXKWwUxHbrriKl7YNdHgWtvKGdnIxs_1742930525 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2572F40008 X-Stat-Signature: rfoarh6edqewg795trhf7r5pinmk7hp3 X-Rspam-User: X-HE-Tag: 1742930527-101047 X-HE-Meta: U2FsdGVkX1+fVyYrb2qQoXHUofO0W7HAYA3W2INCUjtLvUAgsTDehBAJjpgHl2s4bfQ9zz1wVD0detkHIJYQtewdZALlg8eybIEcyIxDmCHAJKgbD8oox6LEpLo8bxqSHt3/ZzG3+f0qKGJBkwV/eFtYsFvvQjRrDbjP7da8jN5Q13N+e2URGqwB1SuAQ5e/vP17h0hoED7fpgOwe7jmumHZ0oHgwuD2o4ASShBpca1pn+bTB6YiM8xTaYRX0fWgvlVSkP16/8U0sKVy3M+zq8PnciMbin3HwjpoJ+18K0IG+hyqt3pARULylflfyvdXAZP5Rh9k4ZzBqpJXpv03wjHDVWhDpSnGkHW/FZNLOm7tuOOVCm1lAIuQiM37m9vrHrOFJtRf1J2jSuWR+31+s/+xKTutkfYu9VLboUWJh4rUcvJJJXlJAtdq2qcYbYiWN3mbkBLzT8YQlGaO+ZC1FytBOewb8sTnFSSKLeyJt9rsqrBVf1KePOrfNi0eHUeCwd+DWJOsVp+9eYfOQSsF7h82r2jpj7H7vF23+JYyioLHdR49AD72AL3L20LFUn5ntGEYh6s28FdgpM4sG1zImYGFx57fb9/MVm3wDDq3PpjVY1KJPtqrTY62ppYdMOXRKuDghvR+bn0KbPCvA3LajPgLtDOcMt0O4456+FXPn6k7Rf2pt0kpcwcmccGhu5rtG+t65AiCxuKz3/NoNpLu2ajQFa9nI6RiMuLgMBiqSn5+jp4Vey+mW/LNt+D+C9wZXkTsrgz0eL4BElIVeyxYJ5oly8JNQYMvcP3TkWn9ifmklJyyBDWUWvtRXYIDTHcjzODLCa4ZV2rjYadH2i/T3YbHeXFL3VFVdme2wqa8rRxCuBwTPwbfV71EfdN8TLJkGnycW45oYojU+K149jFbCm02QhmbpvzbZYfBeYT83K1GWqnw2lmDaciGv3QO12tJIVKdMifWQl2MMYv4Tdb NWA62DjL /M3BW0XRLd8E/bEOE7OJpmZTfhCgrXZSGroVS4bvp+siY5vkj1lq7hpeVuVAy/g8MLOTvJ8ktW5m0aaZ0gXtUINtCvGcVwigSaphHR+8ItjPWvc6m+0kSXAzHMjo/DI3Rys7v/+wYulhNohZCbmAhTQTwzoF11QKBJKaAvGts10W8nFxMwh1HV1duSQ2Tgk3QD2wYedzO3SrpC9GJe7TH4zC4T0S7M3NX7OJ4lTPJVHKpJvRidkvUSCjKeR11pbwr97mozpbaURd/MMODussqj+1NoT70iWzLx4wg9c/7rFtu8c30kVj7S+Tkoqb21bfcQk568yCmHWAqMHRxEDoASp21IeamfeKe4DlV5ClkMeAosaddGWupPHauglG0w/p7JE39fIFqKN0xB8D8F1G/zZSeSHUqoNImHBqsyW2Syqa12zTlAwv0QGhDJdAKG2T8ikwTkVn83IMTLif0twZUTn8bF5CX+r7sdv77BdeU8JKeoFQKFEyN/fY3f4yvPCuA8zkfdkbwMdI4sllA097OUj86AZbQnHJGHcXsEmSRIlXhm/YEuqKM4SswSsSJ5li+T9s2JzK+K5YE/RD8oQqksyrrzA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.03.25 08:00, Zhenhua Huang wrote: > Hotplugged memory can be smaller than the original memory. For example, > on my target: > > root@genericarmv8:~# cat /sys/kernel/debug/memblock/memory > 0: 0x0000000064005000..0x0000000064023fff 0 NOMAP > 1: 0x0000000064400000..0x00000000647fffff 0 NOMAP > 2: 0x0000000068000000..0x000000006fffffff 0 DRV_MNG > 3: 0x0000000088800000..0x0000000094ffefff 0 NONE > 4: 0x0000000094fff000..0x0000000094ffffff 0 NOMAP > max_pfn will affect read_page_owner. Therefore, it should first compare and > then select the larger value for max_pfn. > > Fixes: 8fac67ca236b ("arm64: mm: update max_pfn after memory hotplug") > Signed-off-by: Zhenhua Huang > --- > arch/arm64/mm/mmu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 1dfe1a8efdbe..310ff75891ef 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -1361,7 +1361,8 @@ int arch_add_memory(int nid, u64 start, u64 size, > __remove_pgd_mapping(swapper_pg_dir, > __phys_to_virt(start), size); > else { > - max_pfn = PFN_UP(start + size); > + /* Address of hotplugged memory can be smaller */ > + max_pfn = max(max_pfn, PFN_UP(start + size)); > max_low_pfn = max_pfn; > } > Yes, that's the right thing to do. (I always wonder if these values should be atomically updated ...) Acked-by: David Hildenbrand -- Cheers, David / dhildenb