From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE3D7C02181 for ; Mon, 20 Jan 2025 10:43:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D24B6B008C; Mon, 20 Jan 2025 05:43:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 482936B0092; Mon, 20 Jan 2025 05:43:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FAAF6B0093; Mon, 20 Jan 2025 05:43:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 10F916B008C for ; Mon, 20 Jan 2025 05:43:43 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C7D981A29F1 for ; Mon, 20 Jan 2025 10:43:42 +0000 (UTC) X-FDA: 83027494284.13.997C710 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id 545E3A000B for ; Mon, 20 Jan 2025 10:43:40 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=moRGY5rB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bdCWdIuQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=moRGY5rB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bdCWdIuQ; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737369820; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ciL894RNwZ6L87CNo+rK+xBrJ0vrSFIJHYIK07Mtjv0=; b=jDnnSrgG9UhXSu1dXAOuh1CrLkCuKDjWDjQX+5BJ6Yt0v4qkk2ZNd4QufY0sgHqZaiF6en gtcY2QH6dz9fvaUY4trLL+4LmicEzU+t/QPcMKiJKuyLC30KFqzevzdK9be2GOMLkBIL5z f3gdlVtSgrBmL+VSFtjrwI4tnlW10WA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=moRGY5rB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bdCWdIuQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=moRGY5rB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bdCWdIuQ; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737369820; a=rsa-sha256; cv=none; b=UWxuYxhLUw06eNM+8jUzCaPaKbnbzUczGx4K2LEkbRSWedZrE/8/V+hmNbnipHTCeLBgGf UmBPCFIpx2BCBGqhB0T/B59K0ugvtsP42ZB9U41xuV4hxU39DC8h72uVKqh6QQ6T10Q5fe 3TWQcFs2f9defHZOm8JISYUgj7d/eRo= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 786841F7A4; Mon, 20 Jan 2025 10:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737369818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ciL894RNwZ6L87CNo+rK+xBrJ0vrSFIJHYIK07Mtjv0=; b=moRGY5rB+hezygYkYydERGekqefjftbAaPba33TjbE4HGCSv1AgwTWqSLtH0kHWZOaxJ2z oPrt4NKA4VQ4SK4Ff46v1leOxVRAubqGKnArw0jtrdCA8DTfpG7evtuZLMLSCXasG2O99S otlZ/kS4yR+IL3ngZ/3fv1orro7VvHE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737369818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ciL894RNwZ6L87CNo+rK+xBrJ0vrSFIJHYIK07Mtjv0=; b=bdCWdIuQ+jWgdfSvxCVfgkYCcLPIyevnpN4LabHZRc2809ZrZ6d0xeRZh+c6xPgMPzNSv+ K21+6DTkITGR3+BA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737369818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ciL894RNwZ6L87CNo+rK+xBrJ0vrSFIJHYIK07Mtjv0=; b=moRGY5rB+hezygYkYydERGekqefjftbAaPba33TjbE4HGCSv1AgwTWqSLtH0kHWZOaxJ2z oPrt4NKA4VQ4SK4Ff46v1leOxVRAubqGKnArw0jtrdCA8DTfpG7evtuZLMLSCXasG2O99S otlZ/kS4yR+IL3ngZ/3fv1orro7VvHE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737369818; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ciL894RNwZ6L87CNo+rK+xBrJ0vrSFIJHYIK07Mtjv0=; b=bdCWdIuQ+jWgdfSvxCVfgkYCcLPIyevnpN4LabHZRc2809ZrZ6d0xeRZh+c6xPgMPzNSv+ K21+6DTkITGR3+BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0A494139CB; Mon, 20 Jan 2025 10:43:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4+exANoojmfLOQAAD6G6ig (envelope-from ); Mon, 20 Jan 2025 10:43:38 +0000 Message-ID: <176781cc-75b8-449b-bd56-06d1c25e2276@suse.cz> Date: Mon, 20 Jan 2025 11:43:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v5 01/15] mm: Consolidate freeing of typed folios on final folio_put() Content-Language: en-US To: David Hildenbrand , Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com References: <20250117163001.2326672-1-tabba@google.com> <20250117163001.2326672-2-tabba@google.com> <0f588655-62c0-46c3-bd15-01016615953f@redhat.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <0f588655-62c0-46c3-bd15-01016615953f@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 545E3A000B X-Stat-Signature: e91xngpkqafr9uy7aztetjabqfx66q7r X-Rspam-User: X-HE-Tag: 1737369820-664896 X-HE-Meta: U2FsdGVkX19il//UZB0Tl1hem8fABH5S1VndjmIoUL2zXDleSI6w0a4F5eI5FBxOznS3tmscpOAS2H5tGpgJKj9EmThSIAOhhaoEIN3geDn3a/4x0unQ2zmK8Vioc2DeDzUGryWa/LAkSmkJpxUFfWkHbx6DiMUWmOtGXPyJhjI1NTQiZEHJqfsuhFtY46ax3w9uhpRT7yVJ9seXbwdGzwMVd0sKIY9avGDkivM/mBI7f+OFRlFTMwG/xGiMHwij9bAi8GD3QBu6uDm5tXXZmmy85fP6KFP+psEk+yhSWavo7JFFf0uVy1c8FX2hOtLsnl+CWzCu34MAf4Pm9lVGS7+n6EZThJTPnoLJts08pbl1lGl2IorhgmCeBB9tqt+v3FX490k6Av/RqP0DWHe2ajXZTSugYK2WmsDlggh6n0h0vAjWtFAKYZNKGcWC/lvox+c1abk0+9UmKPaR6JRspB9dX9MKS5Rcrlg0bbe/B7E5rbSq0rl/8Nh88srNK6y6QT50RV60THRiWLot78KVj2MRgP3SwsNHnCbhgp0LuMU+A5slvJf59FmpW4fSYcbMBtdTqHuWU1ML9IqjTkMXPrCa6NQXFMTqObJ0ZAHT2/WSWyRqTGfgofYEP5Vkqwr0lN/l25RfnY6O7vdCNaRLwpsp2Qrbe9oCmL/hqmuskNOUkYiHh3kfmAiSZfpUPu3DVRXaaQAGBFbWbcaWLhJRiys+zug0Yl9hUrJconOUQn6c9cY/uIEbdi8YVVP92zV34hIPzEra8LEl3b9VQkA+Yk59Lg82BPaogAugz46vSBPGaZZ9ZRN34AEi67sVZ4hA+J3OQYY6CrftpB6JbsCXJkuasNT26IVT7gWnEsvXofspZdrfKnpd0iJTe+Jd3PK0XDdCJRgEzoRrZPtm4C7Bxe6Iej6LiwF+lRWF7+ZhsGKTtI+5Eqi++S+WWs3wuWKY05zqTMNIb4oKeVT3unZ kvUpV7IZ oTdBkUeDXMy11xIUQmPn2fcDfGqJ0a5sXFUT9O5jJUSKbhaFcag/wW3u51O61exbwk5JC+++x/pS+ghnlUtLRrrC2ApweJsoPhgKNPHx9gOsxN3tVM6W5R1tJzJTIiZY9HjgxVyCL1HU8+M7/JQTH0ncdlKAmQJe9huBgPq3JdK8NIceOyZ6cRjjM1GO44a8qgEPn6/dtizn/aaCctUfe7VbCLAJsA/SKKZL0soPSmxCED3z/+3Ao8DkvsB8Ltmui77x6/VmGZcztMCwLCeUhCgaoa4LmdTJJWurMVFwExDqhWsFWFBX8uD9uCF8BfRznf9PP4kJm5ohQ5FbiSC/rRbKT6AdM26q3MVgv1CaBZ71E49l+r2SYq9ueZBlZ9DJ5PNC1wGUGrlI8qBMeNmq/QYBKwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.012750, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/20/25 11:39, David Hildenbrand wrote: > On 17.01.25 17:29, Fuad Tabba wrote: >> diff --git a/mm/swap.c b/mm/swap.c >> index 10decd9dffa1..6f01b56bce13 100644 >> --- a/mm/swap.c >> +++ b/mm/swap.c >> @@ -94,6 +94,20 @@ static void page_cache_release(struct folio *folio) >> unlock_page_lruvec_irqrestore(lruvec, flags); >> } >> >> +static void free_typed_folio(struct folio *folio) >> +{ >> + switch (folio_get_type(folio)) { >> + case PGTY_hugetlb: >> + free_huge_folio(folio); >> + return; >> + case PGTY_offline: >> + /* Nothing to do, it's offline. */ >> + return; > > Please drop the PGTY_offline part for now, it was rather to highlight > what could be done. > > But the real goal will be to not make offline pages > use the refcount at all (frozen). > > If we really want the temporary PGTY_offline change, it should be > introduced separately. > > Apart from that LGTM! I gues you mean the WARN_ON_ONCE(1) should be dropped from the default: handler as well, right? IIUC offline pages are not not yet frozen so there will be warnings otherwise. And I haven't check if the other types are frozen (I know slab is, very recently :)