From: Mike Rapoport <rppt@kernel.org>
To: linux-mm@kvack.org, klourencodev@gmail.com
Cc: Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v2] mm/memtest: add underflow detection for size calculation
Date: Tue, 30 Dec 2025 15:36:44 +0200 [thread overview]
Message-ID: <176710174243.4000193.7433666118508467327.b4-ty@kernel.org> (raw)
In-Reply-To: <20251229161321.9079-1-klourencodev@gmail.com>
On Mon, 29 Dec 2025 17:13:21 +0100, klourencodev@gmail.com wrote:
> The computation: end = start + (size - (start_phys_aligned - start_phys)) / incr
> could theoretically underflow if size < offset, leading to a massive
> iteration.
>
> Add VM_WARN_ON_ONCE() to detect cases where the region size is smaller
> than the alignment offset. While this should never happen in practice
> due to memblock guarantees, the warning helps catch potential bugs in
> early memory initialization code.
>
> [...]
Applied to for-next branch of memblock.git tree, thanks!
I massaged the changelog a bit and moved VM_WARN_ON_ONCE() down while applying.
[1/1] mm/memtest: add underflow detection for size calculation
commit: acd8aed2f2b6ce4bcc4f20e48ae88882b1b29fc3
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock
branch: for-next
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2025-12-30 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 15:10 [PATCH] mm/memtest: prevent arithmetic underflow in end pointer calculation klourencodev
2025-12-28 19:56 ` Mike Rapoport
2025-12-29 15:47 ` Kevin Lourenco
2025-12-29 16:13 ` [PATCH v2] mm/memtest: add underflow detection for size calculation klourencodev
2025-12-30 13:36 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176710174243.4000193.7433666118508467327.b4-ty@kernel.org \
--to=rppt@kernel.org \
--cc=klourencodev@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox