From: Mike Rapoport <rppt@kernel.org>
To: akpm <akpm@linux-foundation.org>, david <david@kernel.org>,
shengminghu512 <shengminghu512@qq.com>
Cc: Mike Rapoport <rppt@kernel.org>,
"lorenzo.stoakes" <lorenzo.stoakes@oracle.com>,
"Liam.Howlett" <Liam.Howlett@oracle.com>, vbabka <vbabka@suse.cz>,
surenb <surenb@google.com>, mhocko <mhocko@suse.com>,
linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"hu.shengming" <hu.shengming@zte.com.cn>,
"zhang.run" <zhang.run@zte.com.cn>
Subject: Re: [PATCH v2] mm/memblock: drop redundant 'struct page *' argument from memblock_free_pages()
Date: Tue, 30 Dec 2025 15:35:12 +0200 [thread overview]
Message-ID: <176710164796.4000036.11847815060413161135.b4-ty@kernel.org> (raw)
In-Reply-To: <tencent_F741CE6ECC49EE099736685E60C0DBD4A209@qq.com>
On Mon, 29 Dec 2025 21:52:27 +0800, shengminghu512 wrote:
> memblock_free_pages() currently takes both a struct page * and the
> corresponding PFN. The page pointer is always derived from the PFN at
> call sites (pfn_to_page(pfn)), making the parameter redundant and also
> allowing accidental mismatches between the two arguments.
>
> Simplify the interface by removing the struct page * argument and
> deriving the page locally from the PFN, after the deferred struct page
> initialization check. This keeps the behavior unchanged while making
> the helper harder to misuse.
>
> [...]
Applied to for-next branch of memblock.git tree, thanks!
[1/1] mm/memblock: drop redundant 'struct page *' argument from memblock_free_pages()
commit: 42496efbfba1741fd4f1278366249bce9d34884a
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock
branch: for-next
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2025-12-30 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 13:52 shengminghu512
2025-12-30 13:35 ` Mike Rapoport [this message]
2025-12-30 20:16 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176710164796.4000036.11847815060413161135.b4-ty@kernel.org \
--to=rppt@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hu.shengming@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=shengminghu512@qq.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=zhang.run@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox