From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7967C433F5 for ; Fri, 22 Apr 2022 04:45:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CDF76B0072; Fri, 22 Apr 2022 00:45:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 157F56B0073; Fri, 22 Apr 2022 00:45:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F132F6B0074; Fri, 22 Apr 2022 00:45:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id DC0426B0072 for ; Fri, 22 Apr 2022 00:45:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B366760367 for ; Fri, 22 Apr 2022 04:45:39 +0000 (UTC) X-FDA: 79383276798.05.AF6390B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id B5DA8C0007 for ; Fri, 22 Apr 2022 04:45:38 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 586821570; Thu, 21 Apr 2022 21:45:38 -0700 (PDT) Received: from [10.163.40.48] (unknown [10.163.40.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EEC4F3F5A1; Thu, 21 Apr 2022 21:45:30 -0700 (PDT) Message-ID: <17625223-cc3d-d62a-57db-f7bb5274369f@arm.com> Date: Fri, 22 Apr 2022 10:16:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH -next v5 1/5] mm: page_table_check: using PxD_SIZE instead of PxD_PAGE_SIZE Content-Language: en-US To: Pasha Tatashin , Tong Tiangen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andrew Morton , Catalin Marinas , LKML , linux-mm , Paul Walmsley , Will Deacon , Albert Ou , Palmer Dabbelt , Linux ARM , Kefeng Wang , linux-riscv@lists.infradead.org, Guohanjun References: <20220421082042.1167967-1-tongtiangen@huawei.com> <20220421082042.1167967-2-tongtiangen@huawei.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B5DA8C0007 X-Stat-Signature: ynwgatn88nokukmfwsucjo6fwkfdxhrd Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-HE-Tag: 1650602738-29734 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/22/22 00:10, Pasha Tatashin wrote: > On 4/21/22 11:28, Pasha Tatashin wrote: >> On Thu, Apr 21, 2022 at 4:02 AM Tong Tiangen wrote: >>> Macro PUD_SIZE/PMD_SIZE is more general in various architectures. Using >>> PUD_SIZE/PMD_SIZE instead of PUD_PAGE_SIZE/PMD_PAGE_SIZE can better >>> support page table check in architectures other than x86 and it is no >>> functional impact on x86. >>> >>> Suggested-by: Anshuman Khandual >>> Signed-off-by: Tong Tiangen >> Acked-by: Pasha Tatashin > > To avoid similar problems in the future, please also include the following patch after the current series: > > ----------------8<-------------[ cut here ]------------------ >>>From cccef7ba2433f8e97d1948f85e3bfb2ef5d32a0a Mon Sep 17 00:00:00 2001 > From: Pasha Tatashin > Date: Thu, 21 Apr 2022 18:04:43 +0000 > Subject: [PATCH] x86: removed P*D_PAGE_MASK and P*D_PAGE_SIZE > > Other architectures and the common mm/ use P*D_MASK, and P*D_SIZE. > Remove the duplicated P*D_PAGE_MASK and P*D_PAGE_SIZE which are only > used in x86/*. > > Signed-off-by: Pasha Tatashin Absolutely, helps in minimizing arch specific stuff wrt to page table mapping.