From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2FCFCCF9F8 for ; Wed, 5 Nov 2025 21:24:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F1638E000C; Wed, 5 Nov 2025 16:24:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A2338E0002; Wed, 5 Nov 2025 16:24:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06AF08E000C; Wed, 5 Nov 2025 16:24:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E02898E0002 for ; Wed, 5 Nov 2025 16:24:08 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8AEE0140488 for ; Wed, 5 Nov 2025 21:24:08 +0000 (UTC) X-FDA: 84077831376.24.1EBF5C0 Received: from flow-b6-smtp.messagingengine.com (flow-b6-smtp.messagingengine.com [202.12.124.141]) by imf30.hostedemail.com (Postfix) with ESMTP id 5D5088000B for ; Wed, 5 Nov 2025 21:24:06 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=ownmail.net header.s=fm3 header.b=HmU5hGoP; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="q SmEJgx"; dmarc=pass (policy=none) header.from=ownmail.net; spf=pass (imf30.hostedemail.com: domain of neilb@ownmail.net designates 202.12.124.141 as permitted sender) smtp.mailfrom=neilb@ownmail.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1762377846; a=rsa-sha256; cv=none; b=4Xp2TR9oj7BNoGNqr7IuV8d3bsGlYTdcwnN7JKb5Z29+Bln0eWX0NtpAyaLNU2yNnEzBo7 fD7uO2jt469exx3xzohtJvM+MLy4t3nuC8B9VtyyP6Ja1j8b2UV4HYpG7MDGQvBy/d+oFP tlcYlI4njXPFO3KOs1iNA8fwOZnUOSU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=ownmail.net header.s=fm3 header.b=HmU5hGoP; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="q SmEJgx"; dmarc=pass (policy=none) header.from=ownmail.net; spf=pass (imf30.hostedemail.com: domain of neilb@ownmail.net designates 202.12.124.141 as permitted sender) smtp.mailfrom=neilb@ownmail.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1762377846; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EVCZm+k0TFnzyISAYv/ad61W8yGyS+GgtniecPh35bI=; b=EWJ6d8L+M3vFrD6e0642OVvnQX9fbRrUq4V3QB0qiaiMlLKRORgoE1BbCuI2sGzKNtHOAA qs3lpnYlSPYXbra7aoc8LsfaKphFzZuxID+cNDPK+NSF5N2VgemvgiEilafBMZlu9e1aC4 JQtriuVWZ3FJh7WdXgoipMCk3XlHZh0= Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailflow.stl.internal (Postfix) with ESMTP id 1739B1300C2C; Wed, 5 Nov 2025 16:24:03 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 05 Nov 2025 16:24:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ownmail.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1762377842; x=1762385042; bh=EVCZm+k0TFnzyISAYv/ad61W8yGyS+Ggtni ecPh35bI=; b=HmU5hGoPqokqzJCeAqGf4BLGNy0MGNPv7gplJ67n7ajHRRuR5XU QACgC7SBMngKWRr4nVPjJJgBKA3Q8lvkyUIGSJ1J47cOcYiClbPU1pS4MppGb5wh 2U2/xgadcENW/jgHJsJTyYYdk+1XjojR7/TQqmLQq3cUPGl27XnIya4CBHC1wN5U B+nehvMy/L9Mb2tEVTuU62Q/a0ARwc5MO2szCGIyxpVtm6vXzecjyFmyuGF+NoPC aDoFRHfQnTUA0wUc9ga83EokX5Vq/Y4zVF59Z0IqpO5AZkbSr//2iHDO/uH6Mdle v+KzAJeRAhAF2PY5f//xFYICp+6h/EtUY0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1762377842; x= 1762385042; bh=EVCZm+k0TFnzyISAYv/ad61W8yGyS+GgtniecPh35bI=; b=q SmEJgx4M8dlmgTjoUZkSr8FLucgLUEVlbd9odWDFkQcMJ+PFRsH9Y//0VRWWOa2P Ww7Nr0XlQSokRvZEPNvVMlDa6wHjsBAaK17Tal0oudel/kBoVldVw56udPXn9uh7 Mczp91CekHgkQQrSfj7GW2ikHW7rCR3uH+ZZqm5byT0S1cyww1zJkHKJ+SuERDBe UBNUFH0g9LBeW66OTxBJSBU1+z1R+WJlAHRefWLPYecfVMfJsDxhw/7LXOajVkRK EY0gezm21MwMMJYPZofen2+s3eL3i0IyTk0/RNQdye2aRU/x2B6K2Dlf35uwcujj UVMV0x49c00E0JFs7mDIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddukeegleejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurheptgfgggfhvfevufgjfhffkfhrsehtqhertddttdejnecuhfhrohhmpefpvghilheu rhhofihnuceonhgvihhlsgesohifnhhmrghilhdrnhgvtheqnecuggftrfgrthhtvghrnh epleejtdefgeeukeeiteduveehudevfeffvedutefgteduhfegvdfgtdeigeeuudejnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepnhgvihhlsg esohifnhhmrghilhdrnhgvthdpnhgspghrtghpthhtohepleegpdhmohguvgepshhmthhp ohhuthdprhgtphhtthhopehvihhrohesiigvnhhivhdrlhhinhhugidrohhrghdruhhkpd hrtghpthhtohepfhhrrghnkhdrlhhisehvihhvohdrtghomhdprhgtphhtthhopehlihhn uhigqdigfhhssehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugi dquhhnihhonhhfshesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhn uhigqdhnihhlfhhssehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinh hugidqnhhfshesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhig qdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuh igqdhhrghruggvnhhinhhgsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohep lhhinhhugidqfhhsuggvvhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: iab3e480c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Nov 2025 16:23:32 -0500 (EST) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 From: NeilBrown To: "Jeff Layton" Cc: "Eric Van Hensbergen" , "Latchesar Ionkov" , "Dominique Martinet" , "Christian Schoenebeck" , "David Sterba" , "David Howells" , "Marc Dionne" , "Alexander Viro" , "Christian Brauner" , "Jan Kara" , "Tigran A. Aivazian" , "Chris Mason" , "Xiubo Li" , "Ilya Dryomov" , "Jan Harkes" , coda@cs.cmu.edu, "Tyler Hicks" , "Jeremy Kerr" , "Ard Biesheuvel" , "Namjae Jeon" , "Sungjong Seo" , "Yuezhang Mo" , "Theodore Ts'o" , "Andreas Dilger" , "Jaegeuk Kim" , "Chao Yu" , "OGAWA Hirofumi" , "Miklos Szeredi" , "Andreas Gruenbacher" , "Viacheslav Dubeyko" , "John Paul Adrian Glaubitz" , "Yangtao Li" , "Richard Weinberger" , "Anton Ivanov" , "Johannes Berg" , "Mikulas Patocka" , "Muchun Song" , "Oscar Salvador" , "David Hildenbrand" , "David Woodhouse" , "Dave Kleikamp" , "Trond Myklebust" , "Anna Schumaker" , "Ryusuke Konishi" , "Konstantin Komarov" , "Mark Fasheh" , "Joel Becker" , "Joseph Qi" , "Bob Copeland" , "Mike Marshall" , "Martin Brandenburg" , "Amir Goldstein" , "Steve French" , "Paulo Alcantara" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Tom Talpey" , "Bharath SM" , "Zhihao Cheng" , "Hans de Goede" , "Carlos Maiolino" , "Hugh Dickins" , "Baolin Wang" , "Andrew Morton" , "Kees Cook" , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-efi@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, gfs2@lists.linux.dev, linux-um@lists.infradead.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, linux-hardening@vger.kernel.org, "Jeff Layton" Subject: Re: [PATCH] vfs: remove the excl argument from the ->create() inode_operation In-reply-to: <20251105-create-excl-v1-1-a4cce035cc55@kernel.org> References: <20251105-create-excl-v1-1-a4cce035cc55@kernel.org> Date: Thu, 06 Nov 2025 08:23:24 +1100 Message-id: <176237780417.634289.15818324160940255011@noble.neil.brown.name> Reply-To: NeilBrown X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5D5088000B X-Stat-Signature: s5gk7x9bt89gsaueagqb6wf9ofic3xpu X-HE-Tag: 1762377846-550117 X-HE-Meta: U2FsdGVkX18P02AE+iTMlsHH6MgFT8aBPnHkIXMEL/8KjpQRureEKkY0aWhKx3+rtQMkLDQMnXRKHbLE2NLhDbrP845W7ZJDckxJ3hmozDS2VtEvX8DNMSpZ/TO22jmlJ+4maZ9vmtEmCJrmf2WWjmawkTVlC6DWwKrb5WPsluvoBpt+tY1SC5BuaN9lLRq1EDm3Lb28XhEoNnTTB/b+gdemYZ/ac9matNhpQPe7HoerkrUF0yzrvw7qeKBx4tvdynFEjEAe41DCMUo+v1E0IZlD2yyBRzECuG7a9Bf8O9V2nZ+Zg+P6zZnK5g6mKomfN6YpJuLvSvjBq2QXLonRz1yXaR8j4iJZT+htMBbDHFlBDUsZPRmFfNXUszgpvuiVXLgB20V4ILsi7A7D62TCMHua4ECvBxqEVyHL7w4RMg5aqRkF+wWeRzvzqcWXHXhz2RZn9rjRH7zIqRV1HX86DixAVhcBzpTSJIiE073vz0gVMRnawkZ1zNjzvI/482MUKRwVSVRK5T/xsPZxc0+emflN4YIj2vd5yIrWLw26YmX5VUilqVnTyzMNENgNr7H5QJ4/R9mpdAuJ8ShztdhHuImnTR/iWx4kyIzxgbpU+Hp+5zndgtpMGht5K0M+x9AZ1ETVJM1visNTaTcoYymCkfnpXnKEkXfabtddiIvuglDEpEQImw0vUxZnxCGIgWUrQB1P1jaiJrdDbXVpHG2v5mrAhPAjXluleBN/vQuevBUswKi53MtgAgNmtIBpa238x4l2n6SQ7eaOm0hYd9t7NHlETIK5mh89SAUaDNIIYqYm2ec0eS3731c5p85oP4OEjQzASVCZSotofcqBskgUNxuISyxOwi82mUwzh86I0TqrEgkaeNnUCnZJKb60bWh2flB4W8tC09CocJHebwxsNsRbkd3ka9tS2xuVJhqq1to4wWVsoGkgvVXRB/f0oCbh9tL1IY3GEHD1k7V1SY/ UlhPrD4N GYW1krYpKZGcc7QEOF5+j7U8667zuZb9xaChd5fzP8xrb7Jv0mF4EcJSTAyzDfCT7jf/6ri15ioWPxhuNy9A3JaNen4HMF/woGCJWKPiiidTZVyXP8yNehrfb4fVO1hbgVIv2uD2gs3tgTPHTzJ+BlwHUtid8Nh5AV26gImlg6vXgHHjmwjGCZVO+VmR4WzKjz+ttp/Ug2lxxQffmCa9ErgQVDwk7vma9J4rlTV2bB/ED4J6QMkWVcIUdccF0KXRvoeIrLEGLoUUTHDj19nzcIGDnInK8e5I367YEC9w3uQjHWX/seQUldoYtBOFcDOKMgPA04PaIn7LOdNXMtLfwFuHV6OYXBMhtXmosBY+qXDANdLhPvNgZcgzeNMzeTp9RHHEZ1SefarrxzJLwGoh1Py9WVysb3LF8ebxqdoHUuf1AOcVpcZBhms9EB0RYbFsh0QAFLnR8ggcYAAKlNM/6HJsFa73HxCTl4MUMYYE2wS8/rlHvC1s3eovsaK2/y1b8hw4U+jnKDwAh3Am+E8IKWNri5oLOs8Wuj4IJEk5E7siwcPQWJW1LjcgKYSFbjjPqx3PcwbG1H0OPTWT1VSzC8vze2kCjmfOpNtd3JJGZYc6BUejBvGjMto02AfvG5Oth25XAZ2CH4CVoHTClN3p6I74xxPy0+ZedSpyyoCBNWI+kqTX0Ie5gsVAj20Ixxob9KlYs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 06 Nov 2025, Jeff Layton wrote: > Since ce8644fcadc5 ("lookup_open(): expand the call of vfs_create()"), > the "excl" argument to the ->create() inode_operation is always set to > true. Remove it, and fix up all of the create implementations. nonono > @@ -3802,7 +3802,7 @@ static struct dentry *lookup_open(struct nameidata *n= d, struct file *file, > } > =20 > error =3D dir_inode->i_op->create(idmap, dir_inode, dentry, > - mode, open_flag & O_EXCL); > + mode); "open_flag & O_EXCL" is not the same as "true". It is true that "all calls to vfs_create() pass true for 'excl'" The same is NOT true for inode_operations.create. NeilBrown