From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966C4C7EE23 for ; Thu, 8 Jun 2023 03:43:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9DCD6B0074; Wed, 7 Jun 2023 23:43:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4D216B0075; Wed, 7 Jun 2023 23:43:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1458900003; Wed, 7 Jun 2023 23:43:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AEE036B0074 for ; Wed, 7 Jun 2023 23:43:27 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 71AC71C77C2 for ; Thu, 8 Jun 2023 03:43:27 +0000 (UTC) X-FDA: 80878185654.06.80122C7 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by imf09.hostedemail.com (Postfix) with ESMTP id 6FAE8140006 for ; Thu, 8 Jun 2023 03:43:25 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=k2FOWi+J; spf=pass (imf09.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686195805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HRRRAPdSVzI8M9rvQggGQiRbSztg9qbVFhL3kk5Uitk=; b=WcS4/9aDeF2OuzBoB2A+t0xMA0+p35UMat3Wi3nKeUgmt3InWk1d8TTpWdKvMiZqnrZPF6 wo17UwXsBJEThJ70Y/FOTIc1tQgNdAn2fQ5Em8wKua1gFm4Faby2A52FuZAqEcAFJJ73is Kln+BYMmPfMVRb3/6De7/uKvW9i8YFg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=k2FOWi+J; spf=pass (imf09.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686195805; a=rsa-sha256; cv=none; b=4UEUZagOElRiocZ18+1v4HuEFOY88mGLzD8smtXPHQLolduyDRng055j6GswXcPHkIRdu5 F4ezV0gFppCXBezc5w9EkT8wbmFCUromaypOC/DecoK5B3Nu/e6FoiG3kFxxGzTjYfs7oE tjETBVR0gBrn+yJaBO72nwstgtuyAvM= Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-39c84863e34so27033b6e.2 for ; Wed, 07 Jun 2023 20:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1686195804; x=1688787804; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=HRRRAPdSVzI8M9rvQggGQiRbSztg9qbVFhL3kk5Uitk=; b=k2FOWi+JcACAzDU+ZGQT9P9bnpZyTJkHxuw1hF6HSsmvpxmeqzvbdcZBeqC9HxgrkC PsxfaXw+kQ1k/ct9ZviD+ZV2ELL0q3m3P0r37TJA7UAISodYQ1LNyppf2rVG141oTg/C B0plzjKcFdAfc8oEnppR7Vrr4HE5JMsphgPnzaDoLfVU0WmSSYYmelH12WXJmqWx1cbB Le47SFQ1BJxXsv1fjtFNzJmF3JjGAUk/b5/5MaXBPDcXXNVFpMXhDbWV9xfpnIZNuM+t y6ZT8BdxNVsYXj4bxlhb/0LSukso7wAHl+2FMcNCn6ULIpdJQQ2q6I/5df9ZAJhdiI9R pwrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686195804; x=1688787804; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HRRRAPdSVzI8M9rvQggGQiRbSztg9qbVFhL3kk5Uitk=; b=SIv8xzFCNC3qvjmlpESo6TxN0yA3TFEJw7sd4vUD72geUb7fGlyNUGjKsbYOL6GLTY hWr07ucgTXF+vhVDe3fqfor/0hNYCwipSpF3/Ze+1kxgGiR+KiPqBgyR4YRjX2Jklimu 1cVtSTHjieVTZKJG7j7kLutG8uakHDZYZBpb9g2i41x609tWg/17rAwfdS3MYNGDavc2 0UHgJlOxnyP2LokkRwLDR2lppXqAPm3dcUtYaOcit14otN5hRuwXOwBsdYtFmRkVPip5 uxpngtycVrmXka9a+Hy3vd+A3AgmWKeZSqwpMZJs9seNorwJMXDGmbENPrKoPRhbA3PN BvhA== X-Gm-Message-State: AC+VfDycbA7O/4CxxOLTjDHC7VehtQDdXHPSQZ6ZxwIgS2N+JiLTR1MI xfd34ppCIGUxULyHtZF7UAPtCw== X-Google-Smtp-Source: ACHHUZ4gsJ0M9aOZJ2VO4EhOiSSGeFEKY1ZAvD1n9gGanEgCz9OJe0JyECSr5LSSQuWazSMWS4ATqw== X-Received: by 2002:a05:6808:5c1:b0:396:40c4:a2ef with SMTP id d1-20020a05680805c100b0039640c4a2efmr6960714oij.11.1686195804558; Wed, 07 Jun 2023 20:43:24 -0700 (PDT) Received: from [10.54.24.10] ([143.92.118.3]) by smtp.gmail.com with ESMTPSA id bk24-20020a17090b081800b0023a84911df2sm253263pjb.7.2023.06.07.20.43.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 20:43:24 -0700 (PDT) Message-ID: <17614a28-aabb-5c9e-5840-8fcbbd0b0e91@shopee.com> Date: Thu, 8 Jun 2023 11:43:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone To: David Hildenbrand , Michal Hocko Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230607090734.1259-1-haifeng.xu@shopee.com> From: Haifeng Xu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6FAE8140006 X-Rspam-User: X-Stat-Signature: fwch3oe57icph35kshnr5j3xoax8k976 X-Rspamd-Server: rspam01 X-HE-Tag: 1686195805-495251 X-HE-Meta: U2FsdGVkX1+yxtmTSaTJCvh7cwea0h33CMtdd9BcQZUBNLBpobTrJ0ylECT2aYDGVya5TDmxDq94So/Mk6BmBM9/EOK/t3ACERWW6QcyqOJY54h2tGLAF6Afxdu32xR3vm5vKA3qvnhapSsnW6ApyVKlhPNjOg/BG+bX3ZCsSK0YSdmSRpdsyK1oZd5tJjmpoSKp6d3XeZ6Fd5r6S99HnDdst413FRTVik2Hne8u7zRUK7direzauWtvwfMhD5MMoT5PvD0bLtUyE0xqcDeNYpvVOqSi+jrgdL4YgapPoxFGygubNrupUXzaveT4vkr70Icqy+U3MzF43qGGQN7vVcxWsqKLL9DIpTnjXI6497Q3WSaPdsKFMjDhmEzjy7cUDng/xb5K6qxbqPWxphmxl7ttPbmJNb0XPHCNgv/0Dxf/LV7F9R+V+z6RPug0gnAI1T1dDEtgybZfP73xc6KF3uo64v/hwQZSNBubyqcfJyQORXaFTkujMlXMSeNPH3xWJdqblBNIybpsw/lM6cBlttTxY4KoqL0jxhdknY+cFnTiFrWXo1DspYvtd9reglyD245ovONmbsAZaPwuUCo2gXf2pojQ2NYcle53f17Q99yvxT5clcYLFpC/lHBCekwFd3uO1v1wqOunEw8gHPHsjO69JND7fmGIPy9PrXN8G5o5LrBFmBUcnvgsVy2Ef4qvtmzz208VtBFFnYN4KAmrJOhNoEBzWlfjbK/J2/x1gvyo24ADqmT2WRVhOqVD33U12DIMJfq0K6jyeBdjcykbPvf0eYETvn5qqYJFREcbTkJVXaPB/RTSRFdLvuZk804ruXlZ3MMFJ/+18DBa44WHMM6VoHW0oqasv2e21L8xb+oAMHlRMUFlPtgb/Lmbf+GwT2lcvmdypUjVQNzf8dkgDZX5RsPM8GbUJwubPSinreatBRx22NbfUfrZQECW0fe9Vc7laZNhcd8Sjln+6Op j37aCdY4 buJ3sSvNFr6RdLjvaW/sd7GiEG0Jkrx2OiBc2PYfbJfSlskyomfqG12zTxkDk1xV/0JR0svIItafRQbrq/CWkpPujzCfq9cUWlsYT+Z3R8exCnmaT1+/olEJ0S0PZKWaSQox/z7IjLZtb28uXFqR7E3LGZFsB+J73r/khldk8zUsbfoKJhIR8s0tb0ATKz0HYdJ5K2LPzmXO01vdWnjCyavDgwMYvoa7seFQskNm9iPFr0d49ZZ3YWlj6ZFXxIf4llqRZSwuGuhCOdIPVL+ZjpmtZDRQW8NcAu4ZqlCMtmI9U3U/S1SM/k2x3m7lLz6SnUgB+L+UsdhGomNdEqT2mnPdY4gO5UCJ03WKYZxI+LrxnuOx4+rL7FVal/G+5Wf6uEFo/IDYM2ziQgFBXfxd9FOS5TmkOVbp9THPWiBF0pwZEC0s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/7 18:22, David Hildenbrand wrote: > On 07.06.23 12:16, Michal Hocko wrote: >> On Wed 07-06-23 09:07:34, Haifeng Xu wrote: >>> If freesize is less than dma_reserve, print warning message to report >>> this case. >> >> Why? > > I'd like to second that question, and add > > a) Did you run into that scenario? > b) What can an admin do in that case with that error messages? > > If it reveals a buggy situation, maybe a WARN_ON_ONCE() is warranted ... but maybe only if anybody actually ran into that issue. > I didn't run into that scenario, just from code review. I think the account for reserved pages is similar to memmap pages, if freesize is less than memmap pages, it print a warning message, so for dma_reserve, it can also does the same thing.