From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA88C636CC for ; Mon, 13 Feb 2023 10:11:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A73B66B0073; Mon, 13 Feb 2023 05:11:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A221F6B0074; Mon, 13 Feb 2023 05:11:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E9C06B0075; Mon, 13 Feb 2023 05:11:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 79C856B0073 for ; Mon, 13 Feb 2023 05:11:15 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 56AABA13C4 for ; Mon, 13 Feb 2023 10:11:15 +0000 (UTC) X-FDA: 80461850910.21.2936538 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 87402A0006 for ; Mon, 13 Feb 2023 10:11:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J2P1MYEj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676283073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mxvg2WeSSYepNmRAeMMprQgzHEYhBBIJc+RnE/mAhL0=; b=oz5Y1PzmLDPRSJvKnlKKGeM6VENXWeJokhFIZW/R+anh1JvlNWbz2DiDlVs8yQESer65MC X/v3GBINGM8mlvRdz6OQxa4Y1mnOGyTgNGipWWvL3AheFG1qqscuzW5TSu6JFW/46nFbcR x9p9HDb8icOeOLXU+WPDHnv9SyFN4io= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J2P1MYEj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676283073; a=rsa-sha256; cv=none; b=q+NiIVLPb83QDXD7vwf8ZaiSEh8HJRENe8VbNcOFgZrXQFtyRqAvC07ZHg6mnM7up4XEjI frcqJ2mYkHBC7XnL/cezlphYdZi6wlttNQMlA4LDog2iQ2w9eNKkvWxFjUY5qkgJuP2Nx9 WgNSxeGk+AZ3gCiD8SClyceNvt72SEQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676283072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mxvg2WeSSYepNmRAeMMprQgzHEYhBBIJc+RnE/mAhL0=; b=J2P1MYEjGVUdDUN+G/Uvv9wNATyKfoCIViudDJKoa9v/OwsqCW/JDDHcNZYN3Lf82PxSrY A5je5g5+4X3cwrQ1uDBvNArVOFn/YcgLqM7CyqKal1rMFjOWTx6rUFvGD+GRp+6n4oM7Vm PlcWlRgzTYTpfYwcN3gsGqpMtXwa/YA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-321-KbKwODwGPUWbTKJaN_2DPA-1; Mon, 13 Feb 2023 05:11:05 -0500 X-MC-Unique: KbKwODwGPUWbTKJaN_2DPA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3C53D29ABA1B; Mon, 13 Feb 2023 10:11:04 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1085E2026D76; Mon, 13 Feb 2023 10:11:01 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-4-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1753988.1676283061.1@warthog.procyon.org.uk> Date: Mon, 13 Feb 2023 10:11:01 +0000 Message-ID: <1753989.1676283061@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspamd-Queue-Id: 87402A0006 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: e4bpbug9rfgq715xsf13xciikfc7pdza X-HE-Tag: 1676283073-41814 X-HE-Meta: U2FsdGVkX1/asDVP/d4m7pxpprHfQpxvQ+T+T/GjJXb1pWP7B0B1RJ/z3pz46UzOc9u7AR7dZGqqpZ8arde6HwHNLaqtwB/t1c077SRTj9VfibdFxKk+0BpHb+7XQH7s5/O6FV/zc+35z2Zuw5R+9xElaB8xvr6I+7nuPn8zynMd8QmKZl7FY4n+ktJ0OHeAT6bC/tfmF/YcvVsOOZvAUvfrgwLKE6bE+422jNuqROQViPqogmC0rrQ5XxPqa8V9gutwex71iYr5/PnMHGZ9y0QlureSkPCN5ZSXb09+O7lHTeiMMFZunogOskdmShwiJwqXIg74DljGDlgzswEngv/Qu5h+jlJNB06SbaZ+ie45wIN9RDNhcvEi2C8y7V6/AzwfrO1QxjPmR/FJQWp0J5RheODHUN2imUS2NdS6n92TOFXPO9aVI78p9ziJjJE0YwU9oB19VY3MoyWyxXd/q1oFyy6oD02F6n7V0Lx//o8gabnDWE9Z7ZyGGsuB7dBTqovnpqYqo646k68x9W2FQFIGjo9OL+1ixNaHpTzvBbi/5c4I90/fCAOS0xfXbXDzdGlkpaU27bY2u7jfYLvgFaCb5LBtkc8rj+1rUZaRZSOr7cwd2WAmTfZe2tGLu0wPoNWkTtpc94LGVrPh3nRcSCvhyveKhVf9kry+ireg6Ja5COp4siU89NtE6RwADhz3LrgRJHe3NIgjPcBOSnIUIj5cXSccZTvEn+wQ4ZYci3OKvQ96Z8nLnfqtLooTqjnILGty4OYqTcEUJUNMdQpZqYxmgugTspn58BrvUScZwk4/flbjYcrI2NBDjkTXsrZdalrfjWg/AAIEwtQlwFUJhJuF9sGAUzdF2fXRTi6z3atIuop7tWi+TbEomTUR78/Pm+TFKCGUmDg0iFJ5VRVqAo1RkjVl8HxkFH3BqXYgLjIQrTyMthHYh1RxtyzHcMWqgPJkIYhbjRbIlIsFN6M lh4eDIFY FlZq4cM4q5NxrMd21X/o4kSTPfr1X7yLL6gEzMBmJ7Knc2lo8J4S4Qk1zTIhGcM9563rFkYWT/+p1+102cpiJAi4wfE82vE7FXx6VN2ZobzB4RybeT0eW3YNoxqK9WhXQoNGFuypa8X/WDXpg+Dy8urMclyjDMqQ6Gqn8ISGv7rLTWeolkUnCEXYub7gNCP5tGfSoHLdL+2/AfduRSFtxae0AYyM1QkpEip04PYMTXao4n/hufMgdxpdqxQK+UP2595g7D4kf6FHT0nKKOOfrXkRXVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > Also why doesn't this use init_sync_kiocb? I'm not sure I want ki_flags. > > if (in->f_flags & O_DIRECT) > > return generic_file_direct_splice_read(in, ppos, pipe, len, flags); > > + return generic_file_buffered_splice_read(in, ppos, pipe, len, flags); > > Btw, can we drop the verbose generic_file_ prefix here? Probably. Note that at some point cifs, for example, running in "unbuffered" mode might want to call [generic_file_]direct_splice_read() directly. David