From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
"David Hildenbrand (Arm)" <david@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] mm: make lazy MMU mode context-aware
Date: Tue, 14 Apr 2026 16:30:10 +0200 [thread overview]
Message-ID: <17505ac4-c5e5-4046-b362-830369b8d401@arm.com> (raw)
In-Reply-To: <584f0f88-aef9-4a70-b0bb-abc797f741ed-agordeev@linux.ibm.com>
On 14/04/2026 09:53, Alexander Gordeev wrote:
> /**
> * lazy_mmu_mode_enable_for_pte_range() - Enable the lazy MMU mode with a speedup hint.
> * @mm: Address space the ptes represent.
Not sure that makes sense, maybe something like "Address space the PTEs
belong to"?
> * @addr: Address of the first pte.
Isn't it the address of the underlying memory rather?
> * @end: End address of the range.
> * @ptep: Page table pointer for the first entry.
> *
> * Enters a new lazy MMU mode section; if the mode was not already enabled,
> * enables it and calls arch_enter_lazy_mmu_mode_for_pte_range().
> *
> * PTEs that fall within the specified range might observe update speedups.
> * The PTE range must belong to the specified memory space and do not cross
s/do not/not/
> * a page table boundary.
> *
> * There are no requirements on the order or range completeness of PTE
> * updates for the specified range.
> *
> * Must be paired with a call to lazy_mmu_mode_disable().
> *
> * Has no effect if called:
> * - While paused - see lazy_mmu_mode_pause()
> * - In interrupt context
> */
Looks reasonable to me otherwise.
- Kevin
next prev parent reply other threads:[~2026-04-14 14:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 7:41 [RFC PATCH 0/2] s390/mm: Batch PTE updates in lazy MMU mode Alexander Gordeev
2026-03-25 7:41 ` [RFC PATCH 1/2] mm: make lazy MMU mode context-aware Alexander Gordeev
2026-03-25 9:55 ` David Hildenbrand (Arm)
2026-03-25 16:20 ` Alexander Gordeev
2026-03-25 16:37 ` Alexander Gordeev
2026-03-31 14:15 ` Kevin Brodsky
2026-04-11 9:31 ` Alexander Gordeev
2026-04-13 10:01 ` Kevin Brodsky
2026-03-31 21:11 ` David Hildenbrand (Arm)
2026-04-13 13:43 ` Alexander Gordeev
2026-04-13 18:32 ` David Hildenbrand (Arm)
2026-04-14 7:53 ` Alexander Gordeev
2026-04-14 8:11 ` David Hildenbrand (Arm)
2026-04-14 14:30 ` Kevin Brodsky [this message]
2026-04-14 16:08 ` Alexander Gordeev
2026-04-14 17:38 ` Kevin Brodsky
2026-03-25 7:41 ` [RFC PATCH 2/2] s390/mm: Batch PTE updates in lazy MMU mode Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17505ac4-c5e5-4046-b362-830369b8d401@arm.com \
--to=kevin.brodsky@arm.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=david@kernel.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox