From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBAF3C001DE for ; Fri, 18 Aug 2023 11:42:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A00B94005B; Fri, 18 Aug 2023 07:42:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44FCF940053; Fri, 18 Aug 2023 07:42:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F04794005B; Fri, 18 Aug 2023 07:42:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 22A19940053 for ; Fri, 18 Aug 2023 07:42:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DA19A14117A for ; Fri, 18 Aug 2023 11:42:41 +0000 (UTC) X-FDA: 81137038122.21.1748EB9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 11F7640019 for ; Fri, 18 Aug 2023 11:42:39 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OkyeevQv; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692358960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nIJDtceJEvPvpHYLAnup+4KqtuQicSCLwPh42Fs8LnI=; b=KtbhXsbgwP7kRDn3ZaqOKVW5VCrFwquVIr3j5nbDoca20JJY1HJ8yQ3pYwH0RpNla0IJQX OZayp62I+/cZF/ujzlj6JklEH/FWCBKG46n5bCklcOQe20mVJX4wEE+T0WrMDVBDdfn+lL 8miskRjjK9sLHxeYn0+sg9zFBNiHD/g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692358960; a=rsa-sha256; cv=none; b=x46sUf06ASKDMzX9wrPoDHWqbteSZJfxHvU1gR9DhO3Ij/8QtWwoMWQqO3C+rDIHexxOzA A6Yvn/lTmbS6lpgwdpm2KXQrBtFBcl/me/LlZLNQGQmkzEQ2HlUPVvETK0xKZZmxvzLqjk OIXB6HI7+SzV8CnOdTzZiS/x1w2doXA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OkyeevQv; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692358959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nIJDtceJEvPvpHYLAnup+4KqtuQicSCLwPh42Fs8LnI=; b=OkyeevQvQAiPKznAJBhce+Wjn+8sBWAPiC/zpcDC0fXdsRDPEnTI2rTCKN64AXcYE4OEva GDUFMcM9ElM2RtFk2rB0Yh2oEa6Q3H+WBfEPTaKXO4g0FBiyaUGDM+pkHGUZ69nlYV7ybp Yws6rf0mP1epQm5igSigiwF2T2BMUfE= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-Js43KPOeMVmCnPjUHe8Lfw-1; Fri, 18 Aug 2023 07:42:36 -0400 X-MC-Unique: Js43KPOeMVmCnPjUHe8Lfw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 691DE1C0755C; Fri, 18 Aug 2023 11:42:34 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA67C1121314; Fri, 18 Aug 2023 11:42:32 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <03730b50cebb4a349ad8667373bb8127@AcuMS.aculab.com> <20230816120741.534415-1-dhowells@redhat.com> <20230816120741.534415-3-dhowells@redhat.com> <608853.1692190847@warthog.procyon.org.uk> <3dabec5643b24534a1c1c51894798047@AcuMS.aculab.com> <665724.1692218114@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, David Laight , Al Viro , Jens Axboe , Christoph Hellwig , Christian Brauner , Matthew Wilcox , Jeff Layton , "linux-fsdevel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 2/2] iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1748359.1692358952.1@warthog.procyon.org.uk> Date: Fri, 18 Aug 2023 12:42:32 +0100 Message-ID: <1748360.1692358952@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Queue-Id: 11F7640019 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1d3ui8rjakspzqfcf4qb9oez1iag6sby X-HE-Tag: 1692358959-671241 X-HE-Meta: U2FsdGVkX1+DZ42/dHOgDZrNJW+a9R35404PZxW9fiwx36AlWDugJHXAvovPix8r3MVyxTpxUpvPi1jZ3tuTeMfC24MyIfb1wLXBVqRVoeyjxP+Xtoj85sdH84gRNarEPrU6nEg44tvuWIMbTDtF2UQLyh9rAviSKBFsc93e919opSW7yXMwLQpUl2QkZQlyIi+8ornNU7KdMDnshMNTtC6LRmeIBA2+wCFB8wXLNEHwxvt+DZGchdy29CyQFaJKURG2NVPA6UXpLGW/S3SciT3/x2ym4lnWeF+mjtQt9QlFpU1re7SvrWUkrkXAoGB8pAmiC38Z7sVEbV/Zh6PWVwzwAoyhiLSzLOBHcE+u5/HNqWsAw0qpuLANGRMK6y6PzyFyXe1hn7guC+ya1JvLHj7+FBBVZ2LiNNE1o7UK73FXN0E8wv582EbKLck44cemKZbc/+a9lAl1/QsoGX7pxAiHIVR/KK4Dou3gQuK1UvoJpugoXxyyM8PB60Bwi+TqwUFAn1PPmxJ9wVe0z+EQMuNnGoihpnbdzRYYYyzbRlqWRvk3SssjJEamqhMHqtxG0uMCadv4R6BZKOrhLqzN4k2uF6JpJupmtNOF+zYz2CsbtH7iFW62XncUpdbcPIxrvIwukrAhPTk7SNcFj+HhtRk/3Xf8sgdiAcaM4k7rf4IwhPavZr/tYJOTXCzhcl3g6XkCTFfrwS9d832kX1evTElOZE9xkezkxZPDIp9dWni6PEA5vYih+9TJ7AXns5GZMF0GdbkVZatEmdkLkN8sS6sbWBYbZG/LlBwwOx2Cwc2krQZ+KzhdakU/GQEwlVRJmBWsDeDcimWffzVjDmkmfT80GBiyR3rPO2ein5yBNpwkI96hU6mNVa4BWzvZUtEC2y5vXfHi6i9fY4l6e2j9K5EgCiZ6/RzN2VcsAsfEA5p615/qcyp+2v4oulrRZ27WlJHaq/WGqhDnGGzoJXI YIysDsty d//olJpm6yWtypT7Fy4QBJ5KaxLWXYE8QfGsceNK/EmvnJlogNP7hW7Rsc9P/DXJP6ntjyHuvyBkWAKMXwUgem8zfZ1CtP1fRmCWCejUJdMmWCDSVFYiocrF2Y4A2jTlg01sxL5dCL1pA1j/kKoJppxYIncIEcgAURhv32r1j9nPbdX5X2nT+8HU/6vQxIQ+RQm1GKREPMnNsLIkV816jGLwxR0uucKC7RjSUTSmgsY94+STJKar1oBhn9KIMOWcGlg7BQLnb5VdzM+3psOL2dtyoNBJxz38p3TnNqMdVao+L3Tk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Linus Torvalds wrote: > Well, that part is trivially fixable, and we should do that anyway for > other reasons. > .. > enum iter_type { > /* iter types */ > - ITER_IOVEC, > - ITER_KVEC, > - ITER_BVEC, > - ITER_XARRAY, > - ITER_DISCARD, > - ITER_UBUF, > + ITER_IOVEC = 1, > + ITER_UBUF = 2, > + ITER_KVEC = 4, > + ITER_BVEC = 8, > + ITER_XARRAY = 16, > + ITER_DISCARD = 32, > }; It used to be this way, but Al switched it: 8cd54c1c848031a87820e58d772166ffdf8c08c0 iov_iter: separate direction from flavour David