From: Gary R Hook <ghook@amd.com>
To: Andy Lutomirski <luto@amacapital.net>,
Eric Biggers <ebiggers3@gmail.com>
Cc: linux-crypto@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Andrew Lutomirski <luto@kernel.org>,
Stephan Mueller <smueller@chronox.de>
Subject: Re: Remaining crypto API regressions with CONFIG_VMAP_STACK
Date: Mon, 12 Dec 2016 12:45:18 -0600 [thread overview]
Message-ID: <1747e6e9-35dc-48cc-7345-4f0412ba2521@amd.com> (raw)
In-Reply-To: <CALCETrWfa5VJQNu3XjeFhF0cDFWF+M-dPwsT_7dzO5YSxsneGg@mail.gmail.com>
On 12/12/2016 12:34 PM, Andy Lutomirski wrote:
<...snip...>
>
> I have a patch to make these depend on !VMAP_STACK.
>
>> drivers/crypto/ccp/ccp-crypto-aes-cmac.c:105,119,142
>> drivers/crypto/ccp/ccp-crypto-sha.c:95,109,124
>> drivers/crypto/ccp/ccp-crypto-aes-xts.c:162
>> drivers/crypto/ccp/ccp-crypto-aes.c:94
>
> According to Herbert, these are fine. I'm personally less convinced
> since I'm very confused as to what "async" means in the crypto code,
> but I'm going to leave these alone.
I went back through the code, and AFAICT every argument to sg_init_one() in
the above-cited files is a buffer that is part of the request context. Which
is allocated by the crypto framework, and therefore will never be on the
stack.
Right?
I don't (as yet) see a need for any patch to these. Someone correct me
if I'm
missing something.
<...snip...>
--
This is my day job. Follow me at:
IG/Twitter/Facebook: @grhookphoto
IG/Twitter/Facebook: @grhphotographer
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-12 18:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 23:08 Eric Biggers
2016-12-10 5:25 ` Andy Lutomirski
2016-12-10 5:32 ` Herbert Xu
2016-12-10 6:03 ` [kernel-hardening] " Eric Biggers
2016-12-10 8:16 ` Herbert Xu
2016-12-10 8:39 ` Eric Biggers
2016-12-10 5:37 ` Herbert Xu
2016-12-10 6:30 ` [kernel-hardening] " Eric Biggers
2016-12-10 14:45 ` Jason A. Donenfeld
2016-12-10 17:48 ` Andy Lutomirski
2016-12-10 5:55 ` Eric Biggers
2016-12-11 19:13 ` Andy Lutomirski
2016-12-11 23:31 ` Eric Biggers
2016-12-12 18:34 ` Andy Lutomirski
2016-12-12 18:45 ` Gary R Hook [this message]
2016-12-13 3:39 ` Herbert Xu
2016-12-13 3:39 ` Herbert Xu
2016-12-13 17:06 ` Andy Lutomirski
2016-12-14 4:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1747e6e9-35dc-48cc-7345-4f0412ba2521@amd.com \
--to=ghook@amd.com \
--cc=ebiggers3@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox