From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC362C369AB for ; Mon, 21 Apr 2025 21:30:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E8D36B0005; Mon, 21 Apr 2025 17:30:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 396F96B0007; Mon, 21 Apr 2025 17:30:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25FEC6B0008; Mon, 21 Apr 2025 17:30:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0ADFB6B0005 for ; Mon, 21 Apr 2025 17:30:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7CE681A0EFE for ; Mon, 21 Apr 2025 21:30:52 +0000 (UTC) X-FDA: 83359345944.25.9383D2B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf02.hostedemail.com (Postfix) with ESMTP id D2B7380007 for ; Mon, 21 Apr 2025 21:30:50 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ovisxryp; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745271050; a=rsa-sha256; cv=none; b=HgrPhoEwD0GTTBtAKkTOP5AV27o0oZNKWREOV22r64UDglAOPZDbNfq6WST0MxumdkJWSl JCZ8rt8Uq7nqlmQtwjGEiP4U+Al4+wxdm42TD1f2no2gRfS1vMW4nirwacnvWRzBsXiaah QilheyDfjxLfxm6JBIAhY5ch7N9lHxc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ovisxryp; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745271050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OBx4Bw3gQhoFLy0yr/uU/+Zqe6fazjtvUpxjOm7/fGI=; b=YIRXqzY7k2ZoJMgcrPq85/wzsb8X0PgjGrfrj8N2qE99otmNcT7m92wxufgdJeOm1E6nSH 59WWz2gJY1OXAkYpYJE6h5XUwz073aQpK+0ti4NFdumHIYTRzfFOuvhFDlUnDKKSLZlufe b2JzQEEmmwaeMXJNx1JHVKkuGPvrhM0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1FB5EA439C5; Mon, 21 Apr 2025 21:25:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B85EFC4CEE4; Mon, 21 Apr 2025 21:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745271049; bh=6T/GDJH5/bTv1NCnAu3j4ghfQs2StTuGKdbf8ISr+oE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ovisxryprkhugTTXuEtolnUSpQ9pH46a1Gk/2mdmbcLHjgw8Z+4JkD+CMMjl+0CA1 dtLTYJKgwoczoBPVNKYf3l/VCZzPt1kf9lHT7Y4S0tcJY2NkMJkb5Ps0+XnbOpNXeI FbzDDb2IzTd++0z2gMJbOKT5KcT4wAZQ0l41WuTyKHayxmWjaLDqsZjzWVTxM78rUs UVP0hCxK+8BELCSr9RsynvfNCrM98t7kqFAuCn1Ok3uVeZjAnkFcjNxu6f8VirjuNu e3ceCXvIbWH3YFEDlUuOdFeHKtyKVJVYEyPbMG9FvOlEeHXwCcPDXRDpRMyeLtzRp0 dTPbbi8mZZ7jg== From: Kees Cook To: Christoph Hellwig , Kees Cook Cc: Masahiro Yamada , Andrew Morton , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] kbuild: Switch from -Wvla to -Wvla-larger-than=0 Date: Mon, 21 Apr 2025 14:30:41 -0700 Message-Id: <174527103909.545282.5440977919378383304.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250418213235.work.532-kees@kernel.org> References: <20250418213235.work.532-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D2B7380007 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: yskmtzdtewfrg6ghaba48bnowcspgqme X-HE-Tag: 1745271050-111072 X-HE-Meta: U2FsdGVkX1+wKt2NtFXAUCy+O+FpGm+xgBJx4RmdChEuorMHWEVNNpUIyTYAwf/3YdSHAh0sIG6MqcwGtodXeaIz1H2N0Ah9GrIbrbM/DwdJftMCm6OeuOKfIHC3RfeqL2L08LyxdUNlbk9XR9pxqMCHou7LuhN/T/FJdhQEhuJ7zfbgTwGEkCdNL/xElvjQbZUjMiA9lWJ40Sr/4M/IAuB/fj1ezyzsrGvSqIejamm/qqEXNeMQXuVC6a/GgtRGSXbYoxy6hkvxe4bxDY4/MRqwyTGbbfBl8R4zePUGZZLMLiaNIAqzEraj66XpSxVgmy3+58KBri21IhgJurGCdIKBca1dVBNdUB5DcJdmCw8TEn/DlmT4vJEhw9rgv8naFtteJwu1Ji3OqB0YRNhtJ+eGibU5oW4OzyHpqFdyUhSzrS6+SgElyGw+gIlOXL8GAqGO+gHPeMSpT7d2ud44HNINuFG5Q5J/Lqlz8NnqCKcSzn2c9Nc8IZ3ALFUDobVzpnreD+NhLjErMKbBKbU7OTnn7VvV+s4HehMLYChIVmRmk8CwVe9V/Zcsbiz8qC3BVmulp5sb3gVGD//OS0IbCW1RPDS8DogT0R9Dkh50ARs5Org7BMe2/5gdxh6MFlJoGf0I4DEU1NWWIlDC6AHVtGVNVIqBiTHf1nU37WtoV/Lb00OG6cisbAfr9McX94X7oTX8u/0kSE27Tev4jtHOlRCNbRMkC3vIgKixO5OPlozS1PYF/WyN26aaN2dy7BqDCqcA90XeHSxcfNGppTi70KQbzuy1oVOBuP1OgoOJNcm4ki88Uhbip+7JWmNXJ70shZpH0pSnxC5UcXr6yuKjR8RaNsGMwg+hnroPEYIpjo0AvPUqnipneTTLZtdbX8Mt1AD4nIOklq+rWX1l7ZpFBNUznszdhjHicy/d1AMNPWgsp0VwNCKr1R1SM3dsFsJvd11MjZPypPUlKQujn+U ruIf5n2v CK68XItFirb8eaqqHN3D9xlSsyS2FGjNafOExrgYoSpNheXjM/5DmvUOZm3NzKnOpe3tqOzKyA7Y6M0lo3M1EOXjx1Lt7DvCq/YnOi1CXghT8Gt4YbEcRo6lb2zL6DoJO/djoLLrg5vg1uAifl72fhQ7uxAUcK5J+WcjeCR35mNvHirlLb7X6ElTxBcr+qwt54dkOa8pm+xaUJulu8hHc/VX4Dhd7NcfrOb32FxnbzTbb2Qv+4O7RsCAFzmNr21CAZo8LWKgEDwNJS3uPy182w2MlikESOURQCYnBQpcB9Q9PGDmw4lFs5jYfhPwJvSj2KwbA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 18 Apr 2025 14:32:39 -0700, Kees Cook wrote: > Variable Length Arrays (VLAs) on the stack must not be used in the kernel. > Function parameter VLAs[1] should be usable, but -Wvla will warn for > those. For example, this will produce a warning but it is not using a > stack VLA: > > int something(size_t n, int array[n]) { ... > > [...] Applied to for-next/hardening, thanks! [1/1] kbuild: Switch from -Wvla to -Wvla-larger-than=0 https://git.kernel.org/kees/c/9c2cfa10444c Take care, -- Kees Cook