From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA91CC25B78 for ; Tue, 4 Jun 2024 11:53:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D7A06B00C2; Tue, 4 Jun 2024 07:53:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 686B26B00C3; Tue, 4 Jun 2024 07:53:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 501916B00C4; Tue, 4 Jun 2024 07:53:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 30F5F6B00C2 for ; Tue, 4 Jun 2024 07:53:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DA82B16061E for ; Tue, 4 Jun 2024 11:53:20 +0000 (UTC) X-FDA: 82193045760.19.51BE6D6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id A163D1A0006 for ; Tue, 4 Jun 2024 11:53:18 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J5pDQvnV; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717501998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=67A4MwesB4KncfGKJd9NccNU2t26MKLzuNLJ1mum0rE=; b=z9n2AX002lWFnwXR5vw0GtgGvKbc6EKJc+WQ2Ymr5mfDi5N9FOrgLuEnZIJIrQjDpI8/np w3U4/wIxYNxCRGkO/lbebBXyOXzYWWctoQe/wMYF+nHtHzeorTUpGBOBGgMh4z6gTDBmz/ CCtEjVOClzBg9j00/ovZVg7eGXlL0ZY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717501998; a=rsa-sha256; cv=none; b=xZa/SUbo6eFxpjuy+EzjOj0yyzCk0L6F9SMhnmWyUiP/QVzXyMtyGO9TWG9Px3v3sAyLbx s7Bihln9izZTOrgVi/igbGuYuHH9kwda4EjbMfHj0kw069chjkN1ZcqrY1K0ieWiAxlsbe c3f/kloTpyegjnEiWhpeF/t/UDuFSTk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J5pDQvnV; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717501997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=67A4MwesB4KncfGKJd9NccNU2t26MKLzuNLJ1mum0rE=; b=J5pDQvnVa9DGXak+jjKk2SM7xqN8qJ2kvqe5U834KjfjteZlAnnVx4OAlYwxQeKFVuVa78 qrW2k0hOJTA2YOg94QtgUwOG5PK4Gtf0FP+PoH0IjE8e0OeMdVAVDuJFEuaIbFk1SMyf+M k+8hM5M8ga+sZe8B66XOkpVnFUJ8SpE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-pTAtdXxsOESdejbJ6cxb4Q-1; Tue, 04 Jun 2024 07:53:16 -0400 X-MC-Unique: pTAtdXxsOESdejbJ6cxb4Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4212aeac0e2so25859835e9.1 for ; Tue, 04 Jun 2024 04:53:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717501995; x=1718106795; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=67A4MwesB4KncfGKJd9NccNU2t26MKLzuNLJ1mum0rE=; b=S7zxo8aptKiaKbkl3akuP9d0jzjV1rsGwooYEh/ph1IDAafsj8xh6CS8HEZ1ZAiQ5A +wlarAVsC8uHEbIJ056JG+wW8HeaxtdFZSVD1HzKz9EBDe0F69tger8ntVdDaXZw/vIN xDZw5XiNTxYdWWMb8AyDfzg8hbp3ocIl9ZQjr32kmG6jp+ZWCGmTTxpgeUezkqxETe7i ssn/o8k8njcf4Fp0b05n6k97tP+2qE9V7hIzUXxE6YUT/Jgm/mMhbSLgGCxX1WOCWx4R NcRJ/AzEkhbxRhW6yFeMCovND/OYfI+QjBiUV19GkqVLavO/LkJhZR+ZGHbifyZxv6zj KAcA== X-Forwarded-Encrypted: i=1; AJvYcCWaX2ede5y/Eu1jWv8Mc16oDaur3kEY1hu9dCPv/bDtkXuS2CuemlLuIXoxrIKsAPb9VkmYbwt9mrO+a3iT1DN6KFE= X-Gm-Message-State: AOJu0YyTS2crP7X+Q2AL+mRqbJ4wziy39XVNkIyKn77i5JCT8hDHcrhb L0LrY6iJyZ2690n/eGdp7Zp3qCnVsQ5+58j+dpGjY+0Drs8vZ6Rke6cnyte40HAObX1Isa9HCtc iLJhpZUn6GdPjFKH++OSMXea7aYdG0qzRolNMMkWYrMTM9xih X-Received: by 2002:a05:600c:1c1f:b0:421:3bc4:50a9 with SMTP id 5b1f17b1804b1-4214511b9a4mr24537275e9.10.1717501995439; Tue, 04 Jun 2024 04:53:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEA7mp677IFCBX00uOL7nDG8HAudAy5GLoGQunCin4owqhyoHhQl8UmSJR86Bu1IaWG/7376w== X-Received: by 2002:a05:600c:1c1f:b0:421:3bc4:50a9 with SMTP id 5b1f17b1804b1-4214511b9a4mr24537085e9.10.1717501995055; Tue, 04 Jun 2024 04:53:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4212f05157esm139195595e9.20.2024.06.04.04.53.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 04:53:14 -0700 (PDT) Message-ID: <1744fef4-4928-46bd-bfab-136f9487f1cb@redhat.com> Date: Tue, 4 Jun 2024 13:53:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] fb_defio: use a folio in fb_deferred_io_work() To: Kefeng Wang , Andrew Morton Cc: Helge Deller , Daniel Vetter , Matthew Wilcox , linux-mm@kvack.org, Jonathan Corbet References: <20240604114822.2089819-1-wangkefeng.wang@huawei.com> <20240604114822.2089819-4-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240604114822.2089819-4-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: z91zbf6opmf9ofuktiintrbswmets445 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A163D1A0006 X-HE-Tag: 1717501998-515464 X-HE-Meta: U2FsdGVkX199BB3uju7PlN/L+yrjysMCURnoNBgyXk6bqn0rpuYUZwgR1QABD9B8tSs7Mg5lMrYZ0zaApdcNfv90+0GUvcMG78EoyzMZa6nqgiqu1dLu29JYqmLUN4qNZDjw19eioeWfV6mLwL40G6Xm9MEEz51nPLWEhRDWEJAkcDC+91ASovddL3EGwqPxOv7LWEQHlRo3HuueSqKyLgROCtrZ92GaJeudSzDeHCBy72j6AT/EipqOeWULv39vtMS/j3aRpjsWIHx0Cptw8eGRD9qWB37ugzD/k1QFK7ariPBH2Sf6//TarJBZBvnK2+MXLPkXRc/iI6HnyeaQZljvdiab1bTBN2eyOWki60lZEsBpejAGwvmyh4WPNPYiqHvD2w9mR/9csTPHLd1wJCA0T2I4Vymq5frXPKgSBGWn1kWPGb8pViyg7L4j73h3fwh128rynzN0CcuhV0AO7g+mf+tiuEywTRDPumiFeLDb+XNEysJMcm/dmLuqE7pfuuGszTfKZnGC36Y3pjBkUT1Pcc5VimCDimPsTEK+Xcu1bcOMHz+U9UuS8lcIcCcez7o1/si8DQv5tniaAZh7xAd1lGhlw8xGgJ9yz0DQCneWxK4TIATcuDtTyHH0f1VtW8qjOfaur3EFt2eolApeZGKt5BnGq/gzYVVz2HR1g9syXjvvEW2K+C2w0dW94Gj7mYunxdeBMPqRWHdGUklepCfzeez+GuLylvP47kQfsfBiSWscM1HQV8zPotTcE2s1PbSbtde5lYgciYnVpS80tFMeI69NonBFH2vIFzc+ot3RjQlK9tGYjuF9oPViLrkTpQxt7OCDG+bGmVyjXHGCtkxbdEO8iZdS/z/cXRgUAauIr1evfX2rLXkC0rFhbBhpimzT7DMRjE3lukhSuNfuwnVxxAD8FzWy9kE1NHxRpkF9829Ds55pdCN9zWF5laYHyakAFMUdrQp1p/KKJy/ rODaQRCz LvckNlCIw8L9NphQaAtWSmexcoeyowDSxw0a4Yw+FQ5D169g9NHDgxMj0Pt/onE4aWHwZIeddi5AtOXLGX4xB9LyrvMnJYlt9IeV/acQ+X/XeXawKfi1UcUUXszC2ltH8X+6po+B97gwk88Cnpcf60Jtov0om8lF2k5/nZm8jbK4ycEnejqk0SZT8pmxHuDhcB65pgaILZ62b5ELXiPV7nSJLkLF+yxjSzJ3UtoqjwSG/ykF6uaGs8JTYeA+oU83cLrpDfHzNlxVTMs5/hOjIn8SzYE9YkjPGt8flLmqsK6DdrGorybx8iGE4JrpFicf6FHR84ZTlpMeoAgHiK1vb6HuTlVI7BTkiXNqE/0TLo1gCFxj+6mMDe1p9M2cq6d8NhVb3ugCuW42hZ71y4yXKelJWowgb8uz73RqCWEFYryUr9NQ5CBZPMKDaC713N/DpIP3dyWcmaw/8euLHb0I8R06nGNI5z4U/+glQGo8k0NPPfxwLzQqganghCJqwKObqDJqhGQ239tW7nJ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.24 13:48, Kefeng Wang wrote: > Replaces three calls to compound_head() with one, which removes last > caller of page_mkclean(). > > Signed-off-by: Kefeng Wang > --- > drivers/video/fbdev/core/fb_defio.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c > index 806ecd32219b..c9c8e294b7e7 100644 > --- a/drivers/video/fbdev/core/fb_defio.c > +++ b/drivers/video/fbdev/core/fb_defio.c > @@ -244,10 +244,11 @@ static void fb_deferred_io_work(struct work_struct *work) > /* here we mkclean the pages, then do all deferred IO */ > mutex_lock(&fbdefio->lock); > list_for_each_entry(pageref, &fbdefio->pagereflist, list) { > - struct page *cur = pageref->page; > - lock_page(cur); > - page_mkclean(cur); > - unlock_page(cur); > + struct folio *folio = page_folio(pageref->page); > + > + folio_lock(folio); > + folio_mkclean(folio); > + folio_unlock(folio); > } > > /* driver's callback with pagereflist */ Acked-by: David Hildenbrand -- Cheers, David / dhildenb