From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE87C77B75 for ; Fri, 19 May 2023 09:25:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39466900004; Fri, 19 May 2023 05:25:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31D97900003; Fri, 19 May 2023 05:25:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E58E900004; Fri, 19 May 2023 05:25:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0A3F7900003 for ; Fri, 19 May 2023 05:25:02 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D09C614098C for ; Fri, 19 May 2023 09:25:01 +0000 (UTC) X-FDA: 80806470402.24.B09753F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id B05ABA0010 for ; Fri, 19 May 2023 09:24:59 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FXi/i2GY"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684488299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pfV01EUVDAMlcQXaMvsw0JKN2NbqBChEQxXiVek1+Jc=; b=00avr0CdNpGt0JwOOdCsNAYuyqj1nGU1Ep7rJqDYCgl+5t3j7oLn7+5Uqj+EOgqSe/sLq/ lTmt7j97xOkXn3DbtQKwYgX1YwC5Lh3HbIr1TNk+jDupCxg6GJ4VHyKhrerpNEA9NfY1m0 fSPoQWgp0uMM+56FmXvxgIkm59cys+4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FXi/i2GY"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684488299; a=rsa-sha256; cv=none; b=Hiv/g5+AZgRvnKiQR8t5EqB8kMAtVGurcTNjfV9mYYYG2gr2UMU2Uwh23nPJUqr7/Rm/x2 OZ0IGK2LylGXIXsDQdCucwVb4iIdm5apahXH0x9x930Lfl5ZuadWDLgF8WFcZffCx0NjxG kkuUz9sjrIG3cZei7bIJP6upUZ1dL6I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684488299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pfV01EUVDAMlcQXaMvsw0JKN2NbqBChEQxXiVek1+Jc=; b=FXi/i2GYQN2fVcpXu3R1C01wyfnFri2Me+NPbiyjW3d4ztSDK+Tn+NEbcXb7jlvpQgXaMt 239BsHAYU3f0/UXVm5oQobhEfDk6IJ+PRy55Wuw/TelA65/bViUUyv7iA0XiTRsq5qBjOw WGkEOA6gSnWa6RYKEdhpZGhLZrQgFUc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-619-10XT3QEBNXKSe4Iyf6x2aw-1; Fri, 19 May 2023 05:24:52 -0400 X-MC-Unique: 10XT3QEBNXKSe4Iyf6x2aw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0901F185A791; Fri, 19 May 2023 09:24:52 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id 027F540D1B60; Fri, 19 May 2023 09:24:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-14-dhowells@redhat.com> To: Xiubo Li Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Ilya Dryomov , ceph-devel@vger.kernel.org Subject: Re: [PATCH v20 13/32] ceph: Provide a splice-read stub MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1743655.1684488288.1@warthog.procyon.org.uk> Date: Fri, 19 May 2023 10:24:48 +0100 Message-ID: <1743656.1684488288@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspamd-Queue-Id: B05ABA0010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4toften4771rqqmxjagc4x957wwdhcj4 X-HE-Tag: 1684488299-907270 X-HE-Meta: U2FsdGVkX1/PvpM7oNgL38vkMa4tjeq7HWgrnOHwQZWQb8a+xSV2yq/PHIg0JI7a0V81FNCntBRAFgUqtDm13lOG2j8Ymd93XMSH3Jxo8bxUXROPLObfAGo68O9NuJ5Kvf5tzXbeIB6fQHAJ+GFVReu9z7beshq65TuA3ZTRXWUzBXpwCgdzbnywV1IY3xaRW/VixVq+TUuhfGNR7m790tun0hOA4fdJv3PwHi7WCbPhhQTizqP4LVCyDGZtHJCEo6ua//yJFSiDssPa4yBsUSBHh+uG9KnhxRxFddZ9pOaVaj3+umn1KF770flUGHWb7wbtruAwtvL+f6aDJI9H3SSXHCETE9ncZYBnAoval8w0DFKrPgpqtCtg5pQXSuKe2Er9XO4Jg6/pg/LqkBx5lItjlCUAzJRUZxga8XnJeVkbLfjiQi18pn6H/1ZtB+PhFG37XGA/N2Ontwu+oFQtBDJLLYEknGoIZse+9EQDUep6kNKmtuQCmgkOR03L+xfGpLcSnlcmw7PS5Sj2A2e8TnMhc4mQC3V7nYiRUm+ymShvDf5PE5/o19msKulKLXGOVrN0HLlwNfVYIFjEgzMWqBi54/pH4YNzEEPl2eiKa5SZ1di5ynw9iodfVn6/c7YTrIjiUCnp2q2g4MH/1c6E+zh2hbr3PJ4MlFabo9lz7BD8A4Q5clJH1y+nU4LHUu4wNT8SHcMSJLF97k6ttEoOybWcNKwGxNFxhFoDb6jJZWozepD3WDOMx0MLrCVvrulv2Uci8/Wk8+TZX+/VNOTrQznhx/hgWwkklVdz5OW8JzETI7unhg49BIMJCLQYy2spPFnmsE2HsRZHElkO9njwhMNqiKh/4jYsfzKeUIpXJwh4W4sJWYd/OYO0csX10okmdtX5X6IMTjrqg3/nxNKwQHG7iSJw7lLMLIB+XqnHpYawN8p9GHZh9uUK38+iaQY2iyBr0szt9+PiNFMiTz6 ACblxDdh BO+t4ttPwUvEzNf+VOh/nbHoiM9AH3NV/1qQhFnPnkiv6TikZosDVzuqU+/Rjniyi8jD6KSrcXQsRUimxf1HCkTIgo6l4gvdYDSvaGs+eQWBpZyY//8vLTSJ65w3x1jzwEHXTnPkh93Ntg9DI/IQ40Sp7njyWjoea6o0wMcvmFoZebmNG6MUpPGWDpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Xiubo Li wrote: > > + ret = ceph_get_caps(in, CEPH_CAP_FILE_RD, want, -1, &got); > > + if (ret < 0) { > > + ceph_end_io_read(inode); > > + return ret; > > + } > > + > > + if ((got & (CEPH_CAP_FILE_CACHE | CEPH_CAP_FILE_LAZYIO)) == 0) { > > + dout("splice_read/sync %p %llx.%llx %llu~%zu got cap refs on %s\n", > > + inode, ceph_vinop(inode), *ppos, len, > > + ceph_cap_string(got)); > > + > > + ceph_end_io_read(inode); > > + return direct_splice_read(in, ppos, pipe, len, flags); > > Shouldn't we release cap ref before returning here ? Ummm... Even if we got no caps? David