From: "NeilBrown" <neilb@suse.de>
To: "Gao Xiang" <hsiangkao@linux.alibaba.com>
Cc: "Yunsheng Lin" <linyunsheng@huawei.com>,
"Yunsheng Lin" <yunshenglin0825@gmail.com>,
"Dave Chinner" <david@fromorbit.com>,
"Yishai Hadas" <yishaih@nvidia.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Shameer Kolothum" <shameerali.kolothum.thodi@huawei.com>,
"Kevin Tian" <kevin.tian@intel.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Chris Mason" <clm@fb.com>, "Josef Bacik" <josef@toxicpanda.com>,
"David Sterba" <dsterba@suse.com>, "Gao Xiang" <xiang@kernel.org>,
"Chao Yu" <chao@kernel.org>, "Yue Hu" <zbestahu@gmail.com>,
"Jeffle Xu" <jefflexu@linux.alibaba.com>,
"Sandeep Dhavale" <dhavale@google.com>,
"Carlos Maiolino" <cem@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Trond Myklebust" <trondmy@kernel.org>,
"Anna Schumaker" <anna@kernel.org>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Jeff Layton" <jlayton@kernel.org>,
"Olga Kornievskaia" <okorniev@redhat.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
"Luiz Capitulino" <luizcap@redhat.com>,
"Mel Gorman" <mgorman@techsingularity.net>,
kvm@vger.kernel.org, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, netdev@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements
Date: Wed, 12 Mar 2025 09:55:10 +1100 [thread overview]
Message-ID: <174173371062.33508.12685894810362310394@noble.neil.brown.name> (raw)
In-Reply-To: <316d62c1-0e56-4b11-aacf-86235fba808d@linux.alibaba.com>
On Mon, 10 Mar 2025, Gao Xiang wrote:
>
> - Your new api covers narrow cases compared to the existing
> api, although all in-tree callers may be converted
> properly, but it increases mental burden of all users.
> And maybe complicate future potential users again which
> really have to "check NULL elements in the middle of page
> bulk allocating" again.
I think that the current API adds a mental burden for most users. For
most users, their code would be much cleaner if the interface accepted
an uninitialised array with length, and were told how many pages had
been stored in that array.
A (very) few users benefit from the complexity. So having two
interfaces, one simple and one full-featured, makes sense.
Thanks,
NeilBrown
next prev parent reply other threads:[~2025-03-11 22:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 9:44 Yunsheng Lin
2025-03-03 22:13 ` Chuck Lever
2025-03-04 12:04 ` Yunsheng Lin
2025-03-04 8:18 ` Dave Chinner
2025-03-04 12:09 ` Yunsheng Lin
2025-03-08 6:43 ` Dave Chinner
2025-03-09 13:40 ` Yunsheng Lin
2025-03-10 0:32 ` Gao Xiang
2025-03-10 12:31 ` Yunsheng Lin
2025-03-10 12:59 ` Gao Xiang
2025-03-11 22:55 ` NeilBrown [this message]
2025-03-12 1:45 ` Gao Xiang
2025-03-12 12:05 ` Yunsheng Lin
2025-03-12 12:41 ` Gao Xiang
2025-03-04 9:17 ` Qu Wenruo
2025-03-05 12:17 ` Yunsheng Lin
2025-03-05 23:41 ` NeilBrown
2025-03-06 11:43 ` Yunsheng Lin
2025-03-06 21:14 ` NeilBrown
2025-03-07 9:23 ` Yunsheng Lin
2025-03-07 21:02 ` NeilBrown
2025-03-09 13:23 ` Yunsheng Lin
2025-03-10 0:10 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174173371062.33508.12685894810362310394@noble.neil.brown.name \
--to=neilb@suse.de \
--cc=Dai.Ngo@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=anna@kernel.org \
--cc=cem@kernel.org \
--cc=chao@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=david@fromorbit.com \
--cc=dhavale@google.com \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jefflexu@linux.alibaba.com \
--cc=jgg@ziepe.ca \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=luizcap@redhat.com \
--cc=mgorman@techsingularity.net \
--cc=netdev@vger.kernel.org \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xiang@kernel.org \
--cc=yishaih@nvidia.com \
--cc=yunshenglin0825@gmail.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox