From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C116CC021A4 for ; Mon, 24 Feb 2025 20:53:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57D3D6B009A; Mon, 24 Feb 2025 15:53:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52CB46B009C; Mon, 24 Feb 2025 15:53:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A66F6B009F; Mon, 24 Feb 2025 15:53:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1D2246B009A for ; Mon, 24 Feb 2025 15:53:16 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D95781C6BA4 for ; Mon, 24 Feb 2025 20:53:15 +0000 (UTC) X-FDA: 83156038350.27.88E7722 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf30.hostedemail.com (Postfix) with ESMTP id 4FC4E8000A for ; Mon, 24 Feb 2025 20:53:13 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KN9+CLAD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=H2YYL45L; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KN9+CLAD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=H2YYL45L; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740430393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qJOXvzmoxen8Yfe4DbyjOI0SBc1bw6aCP1zccs3V4bI=; b=Hu33EIhU9SP2AeBtev9zbV7Wvk5wY1RdtwwJKyRzCqVDBMaTqZHQRocNtsB2sDP2RduGcg a+bJkT3Xi1rnpOmM9EGFy7R7KNROlxRkB7vi/kMxlWgdXR8dfSJ2tVc3BctygbgMtEM5Ph PMTnEis7NJzJxHDw1cxmnHC25qCNmbk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740430393; a=rsa-sha256; cv=none; b=ulUUY81Uowa66zOrfa5aepVfIT4cGzXdah+Ekvjlu8/JzMN2FViFDqVsUULa6e30nE42+T 4tGFP7A0HRbzIGJ+IDBzKQWMhpcVr9h7Eap5KvTiDDMoJak/NPby3OM8XN2tY4v2TNMXxz q+YsbE1MKy1EE0O0ZfSLtNJecIFfSCY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KN9+CLAD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=H2YYL45L; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KN9+CLAD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=H2YYL45L; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 74B4B1F44E; Mon, 24 Feb 2025 20:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740430391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qJOXvzmoxen8Yfe4DbyjOI0SBc1bw6aCP1zccs3V4bI=; b=KN9+CLADZxRzmzLwqO9felhSgKzpKKlXBV04+iU3jz++H7SDJNM7lw2YsMVV01buDOKaXn j6Pt+f7nAdOQDcbCtpmdrmdkEJRXh3+41ai+OaWK00KSZUDQum6xOiGLTYDcML9wuURr/F KmEPWY7qcozMYheuAPROkxfHySMIe/E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740430391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qJOXvzmoxen8Yfe4DbyjOI0SBc1bw6aCP1zccs3V4bI=; b=H2YYL45LjH73GwXFtIlFSuweY7V1MAUcmN5B+Wp42XyKlgvpLO4l/mezSLykb4RE766y7F +o5FaOIB7Mj/UqAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740430391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qJOXvzmoxen8Yfe4DbyjOI0SBc1bw6aCP1zccs3V4bI=; b=KN9+CLADZxRzmzLwqO9felhSgKzpKKlXBV04+iU3jz++H7SDJNM7lw2YsMVV01buDOKaXn j6Pt+f7nAdOQDcbCtpmdrmdkEJRXh3+41ai+OaWK00KSZUDQum6xOiGLTYDcML9wuURr/F KmEPWY7qcozMYheuAPROkxfHySMIe/E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740430391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qJOXvzmoxen8Yfe4DbyjOI0SBc1bw6aCP1zccs3V4bI=; b=H2YYL45LjH73GwXFtIlFSuweY7V1MAUcmN5B+Wp42XyKlgvpLO4l/mezSLykb4RE766y7F +o5FaOIB7Mj/UqAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 55BAD13332; Mon, 24 Feb 2025 20:53:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CvOMFDfcvGcJQAAAD6G6ig (envelope-from ); Mon, 24 Feb 2025 20:53:11 +0000 Message-ID: <173d4dbe-399d-4330-944c-9689588f18e8@suse.cz> Date: Mon, 24 Feb 2025 21:53:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 00/10] SLUB percpu sheaves Content-Language: en-US To: Suren Baghdasaryan , Kent Overstreet Cc: "Liam R. Howlett" , Christoph Lameter , David Rientjes , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org, Sebastian Andrzej Siewior , Alexei Starovoitov References: <20250214-slub-percpu-caches-v2-0-88592ee0966a@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 4FC4E8000A X-Rspamd-Server: rspam07 X-Stat-Signature: ueqectgbqhjecsqcbx13gfapjtywzchq X-HE-Tag: 1740430393-570955 X-HE-Meta: U2FsdGVkX19Q2rNRU7HGDFhj5nx6JSm1u+5CqtLpuoIZsRc5wdS4mkYtONKOk/Rmm3BtashW+4g6P+NX6j6uI69LPRLSVUHz9pN0+3DsG8BXA3Xxt9UPkapiUZBSa7sEjmAmocYpCNn2ZQvxIBxDWp+5F3zDP9fBZwSfz5Mxa0eK5bqdJsmwsWEcT1wBR5LB/PMXfSh8s5ip5Lf/Ns1xd6CA644+AtgswBW/nS2XIzZqwj09AcxlH1SHN2i5sgutRDv+98hnYyPTghU9IvVUWhr01fGbM0ff6gV/o41VGfTFUfaWwF+fD+Ua8dzyC2avcSqpD2Z9SOfz0I9ONJiK4gnUS9LgHk9mKSG+B5ypRHBWUh/8wdzian4xKqJjn+pRZBhoWRrVMPvVqn9f5r1wEiARCLa2JtHsxbDQcnSTNOH5jIDhRsBlku+2RGSG1iTewHf+InJZMAbMpv+68++9v18QYw+mgK29OdMjIUqVBAu20IdQoot60QOJF+RiucFm20AysyfeqXPqkxspmJ6zN8bcRM14Q5zdHvGq3TNtW0ga6pCuQ0X9CsDgHjmS45NGw5W3VM4fTYYzQTu2LaWn8Fhrnj1wZWgbKVNsSTmDR6DdkTLnIe8xIE08ql1SUhg6x7ymYxy2K7+HY7cfoLLuOOeG0TuksGRkaoAT9mHg8J3MWl7xhZrxXwjUK8f8AdZtGZB5u6PZMtLQSzoIlPDt9z+9ORvDCBOOsDHE0b2MmBTcupFIMmC6kfuoqqXGYW0V161RPhRyMiZjXQnY81FWmOfOpCpclsu4Wixr66YDsTLsfn4w0IMlgDHWHot1qSRA6JAjs4OZ6nHytigTqp9F73thK9jP70+oPtaREajhegvYmZnRCfKQ6EAr0sm2FFZlghcp6FhC0XPxwhhJjhWTWAz2/XP79gwVqEJqQBkq4flt5e+6D8XI9BDCQmekiPJJM3rLEfg3jukdXqYJ5kB OZM57eif QZph8pICtH9bg3cJX8X8Wsg/5P62hNzjOv2e4ZtWmU7+kScOV3wxuHHN1PsLDu0mfwGRuvq2PsVeI82vqKgnkrZzqYAolwfCQ4QxRac2f5G3rakckFFLlFbc5aKnyWbJVcoDa0IRY4qDX5gX+2JsXX2bi0L9bkGxSwjy3LtzebIq9Hk7kOQqY3goAFUqPe1p995QRwewlq4AlfyVebf1zQ3aRImTeBf1cjYfs4Ml1NqWaGcW8vq5hEGQsd2cWYta9ASHcM/PDjjbBTlpK7ZL/CfpNuxt3eHHbEheuSUr5QLn1ESowdGzWsjFlPI+USa+gXdJUpo/ccHcca9+2LSS8hY9gKrkNm3VyscC/Saq/qqADHa9vv0LwnYLQiMGbtwFidQDrV94RWpVW9w+eLiiw4qudkb85kFQiL32SJ7J1p8/i/LUJ7XVYwNq3sw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/24/25 02:36, Suren Baghdasaryan wrote: > On Sat, Feb 22, 2025 at 8:44 PM Suren Baghdasaryan wrote: >> >> Don't know about this particular part but testing sheaves with maple >> node cache and stress testing mmap/munmap syscalls shows performance >> benefits as long as there is some delay to let kfree_rcu() do its job. >> I'm still gathering results and will most likely post them tomorrow. Without such delay, the perf is same or worse? > Here are the promised test results: > > First I ran an Android app cycle test comparing the baseline against sheaves > used for maple tree nodes (as this patchset implements). I registered about > 3% improvement in app launch times, indicating improvement in mmap syscall > performance. There was no artificial 500us delay added for this test, right? > Next I ran an mmap stress test which maps 5 1-page readable file-backed > areas, faults them in and finally unmaps them, timing mmap syscalls. > Repeats that 200000 cycles and reports the total time. Average of 10 such > runs is used as the final result. > 3 configurations were tested: > > 1. Sheaves used for maple tree nodes only (this patchset). > > 2. Sheaves used for maple tree nodes with vm_lock to vm_refcnt conversion [1]. > This patchset avoids allocating additional vm_lock structure on each mmap > syscall and uses TYPESAFE_BY_RCU for vm_area_struct cache. > > 3. Sheaves used for maple tree nodes and for vm_area_struct cache with vm_lock > to vm_refcnt conversion [1]. For the vm_area_struct cache I had to replace > TYPESAFE_BY_RCU with sheaves, as we can't use both for the same cache. Hm why we can't use both? I don't think any kmem_cache_create check makes them exclusive? TYPESAFE_BY_RCU only affects how slab pages are freed, it doesn't e.g. delay reuse of individual objects, and caching in a sheaf doesn't write to the object. Am I missing something? > The values represent the total time it took to perform mmap syscalls, less is > better. > > (1) baseline control > Little core 7.58327 6.614939 (-12.77%) > Medium core 2.125315 1.428702 (-32.78%) > Big core 0.514673 0.422948 (-17.82%) > > (2) baseline control > Little core 7.58327 5.141478 (-32.20%) > Medium core 2.125315 0.427692 (-79.88%) > Big core 0.514673 0.046642 (-90.94%) > > (3) baseline control > Little core 7.58327 4.779624 (-36.97%) > Medium core 2.125315 0.450368 (-78.81%) > Big core 0.514673 0.037776 (-92.66%) > > Results in (3) vs (2) indicate that using sheaves for vm_area_struct > yields slightly better averages and I noticed that this was mostly due > to sheaves results missing occasional spikes that worsened > TYPESAFE_BY_RCU averages (the results seemed more stable with > sheaves). Thanks a lot, that looks promising! > [1] https://lore.kernel.org/all/20250213224655.1680278-1-surenb@google.com/ >