From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E605C83F03 for ; Fri, 4 Jul 2025 11:15:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C24A6B00CB; Fri, 4 Jul 2025 07:14:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 772A96B803F; Fri, 4 Jul 2025 07:14:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63FD66B00D1; Fri, 4 Jul 2025 07:14:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4C7F86B00CB for ; Fri, 4 Jul 2025 07:14:59 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EC5F510812C for ; Fri, 4 Jul 2025 11:14:58 +0000 (UTC) X-FDA: 83626325076.02.C90F681 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 872882000E for ; Fri, 4 Jul 2025 11:14:56 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ToJbOy2O; spf=pass (imf13.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751627696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9pLkebcs37QdmleDdjVVPJ2wuIzkHavJTHX9ult+c/4=; b=SEH73ojB41Nal2Zb8of/y2NrayYsKuQm/8Vd9b6QAln2nkr4LldnbTXjdjeqXF3+UelZNe 36GbMKTPy3orColpAs1FgZ9oBJPRfBssmmkD2tIvn0WonPw2GZGnlgD8okoNg5Fhln9/94 ktzsl/Czz3+LME68zInbGgSXx8U5CxQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ToJbOy2O; spf=pass (imf13.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751627696; a=rsa-sha256; cv=none; b=Fyk6oh7roRDy4+Vc/hELAyt9goxYfb63/823LlSiAXHJ2qjAFfbOArYYP+mNM7TC0xflCQ EgF562IRMgsgEjLfzsBB8D2FVzAn515DCKoZ3C+Ll6KMZ4AhYHY8KMGEZeoazqW4P5x8WL ZkeFXA6muPCwXrdd2LdMp2ue3vKAuUU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751627695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9pLkebcs37QdmleDdjVVPJ2wuIzkHavJTHX9ult+c/4=; b=ToJbOy2O8TtW8nE/UX9PhfrfoPkaSJVjj5cIeI4D/hwalj8kl5oFLo1K78PkZtf/xnP+sW Ty2TMzryIHou09OIqelR3sJmyegJXp6NKLKxF6XIutJh2Bd+rCV8TSv3lpboUlIYDo3ZCU 0EzxT4S48HB2l0OTgq5tImQzMWxLMm8= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-207-gAHIoeKPMQGbStoT6dLpww-1; Fri, 04 Jul 2025 07:14:54 -0400 X-MC-Unique: gAHIoeKPMQGbStoT6dLpww-1 X-Mimecast-MFC-AGG-ID: gAHIoeKPMQGbStoT6dLpww_1751627693 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-553c6367ec1so470341e87.1 for ; Fri, 04 Jul 2025 04:14:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751627693; x=1752232493; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9pLkebcs37QdmleDdjVVPJ2wuIzkHavJTHX9ult+c/4=; b=onTrSloJUz3GLvgLK1YOP7HM5JqVFvEjI+DoRAqPJEmCDSNPVWo1VapHFaG+aXku+U nCcGRSFmitsJe3gxnSZPkM9cEYuInOcz7n23N/ajphgGRgmOxqbJdVBC2OyqfLH5XAD0 aVUfGF8kz6AEfnq1U9s1N4TPLvn0uvRFaXPUd+1HqCIkFw7jJRsN/VkZyFBKJ2MHstyY O3Ak4LjW24IbXnMhXX95Ckw0fxuayQ+D+FIW4dDofvanxKVOfQPvqAdpfMUOs9spkwKW DaJinuTYtfZIrM8+jj5gcudyk0HjR6PuPYKLBVwm17Q5/rsCADV29EP54FKYxYmf3h3j +BvA== X-Forwarded-Encrypted: i=1; AJvYcCWmjXwb6oMYG3LpugnY/J7VhtPo3HSNA1tv9L99m+5t+HSz1tPwvWk27UIA/p3n9xrow7hIwjOdkw==@kvack.org X-Gm-Message-State: AOJu0YzTVRCeLR//cX4Lz3Gq4wL1fjdcW60vkftQqQgckArY2YXVvoxh z42N6kd7ChIGOdNm6KLZ7Ng1jWAXV+hCw4jgYmmxCPnUcndq7Mpayr+N7LeAt+r1J+y0S7bsifY GbxrmjuhIcHoh90iQOieryrXbF9jf+WyP3PacAV/WdRMAlt+wWlo= X-Gm-Gg: ASbGnctm5+K4F+CKDQMHrCPAR+5AkrDSzuGGu1fjNYsxUL7yQJ8Mc2Xfio25ueXHvzD orFN4g2P32T25bEguLpA++bAuHYXZxOdLI8W1HbRdrOkveKWCXjpq/j6AnUy2iPN6W5vjGcgaUQ RCCcbysQeT+Ml0yQHp1NsN1ob2xT/asDlaIl9MY6GTCKp6tiFXr9MjI27OwiqpxLNpjJuz4oog8 3IwoEto3u/GmVSjOSBZVSs/C/eIuNeExKanYI6aMtTnLsI9+Em/ibICtT0o0vZVWg0Esr1puayw bIaATP0LiOsk3hX7DX7B+rpLZuW/kvK/fyDe63dmaThUvvUr X-Received: by 2002:a05:6512:318e:b0:54f:c2ca:d33 with SMTP id 2adb3069b0e04-556dc742f53mr678714e87.20.1751627692868; Fri, 04 Jul 2025 04:14:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEe+mZzhbF/GPrjdqWw0ErCtUNIJiy+8KwW1WlvJgTONYdWorAud9n79hHADokc/A80A0fAMA== X-Received: by 2002:a05:6512:318e:b0:54f:c2ca:d33 with SMTP id 2adb3069b0e04-556dc742f53mr678687e87.20.1751627692356; Fri, 04 Jul 2025 04:14:52 -0700 (PDT) Received: from [192.168.1.86] (85-23-48-6.bb.dnainternet.fi. [85.23.48.6]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5563cfb2e3bsm196542e87.215.2025.07.04.04.14.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 04:14:51 -0700 (PDT) Message-ID: <173510d4-61b5-42c0-97a4-0cce8081b40b@redhat.com> Date: Fri, 4 Jul 2025 14:14:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v1 resend 07/12] mm/memremap: add folio_split support To: Balbir Singh , linux-mm@kvack.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Shuah Khan , David Hildenbrand , Barry Song , Baolin Wang , Ryan Roberts , Matthew Wilcox , Peter Xu , Zi Yan , Kefeng Wang , Jane Chu , Alistair Popple , Donet Tom References: <20250703233511.2028395-1-balbirs@nvidia.com> <20250703233511.2028395-8-balbirs@nvidia.com> From: =?UTF-8?Q?Mika_Penttil=C3=A4?= In-Reply-To: <20250703233511.2028395-8-balbirs@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Rw3Ox6WaByQrq_HE32av3BFbhHmNkXEo31JuJJrSfFQ_1751627693 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: b89fj4zhg8scm4n74exeimejftxckyrb X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 872882000E X-HE-Tag: 1751627696-750614 X-HE-Meta: U2FsdGVkX1/GVxC7tuDYQYJN4knH5UGI6U5xuIWWdr2n1nnz/1ALyBZ3YK878kj33N/qX3rTQ+TbRYC8rnoQvq18w+5JYmdajK2+9BaaLHRogi3p/Ryi7bPH9Hf6bqQPvsBtQRckiiggqUYkiewx1WTFX+ll/hiebxf1AwI0gDs+qN832pGhzXWtq6JCrBPhyT16G/L28zA9Td07fgsth727oqhB71g7+jITOEq2m4fzUbWiaOgphmNCYwEqJWkadOCPAMngw0yLaLC0ADwu2ln9B3Rd6HsullKH64a6+LI1Qf/Z7OnK0exsemVp05JYaMLD2jGtUs9jC8BDIG/y76vv0JhO734DquHI7mgYKqUkEMfXM4jw+d9BACgQOWyeRZr7yPkHqvCrUev47I3MhwDPX93eB/Rq79+wulQAFruz5gnp9Cp1dE9gxONM5LVydgCqZSoZhc67Cr107ARhqrNVsY6TyNlk4zl/CxeW9fIQ0vPfnIE2MEctxeAqOPaYY2WjQzdmVhA2pGGQiIEH5Sq7rXNlQl14OzWjnwecEdePYNgRpKO67czwjrCkekuWnUsYB6/2I/dnBtmtFLkigmSFrjaSPsQh5lYKoV1/cI7LX9S5rp/YueudoSbHZdm/LacFgKROJxL2X/x9SxigioI7hcaF9FnDhAa/WcP7eeMzLIESKKTIAqa9zqooBPFy97kTJdAHzQl5Nu8+UTV06qYL1u1bZpbVAlpH0kwDEaVykR1b+JpXF6cawJCrqH1eEtbYXEda5W2H0xSMrlCTusrMwoZw+b6ma7O5tmJcU7X9VLGMkjxarLWXpCHGZQIrdl3z7AbA8YeYXaouuDKGWE/0HXhypHUmJV/8AjsSWToxtfNGTDA3rdXET5BsdSRnVaRKUvKKOA1+yMXSJrYFJXxpugTuUe2csXv6xL1tAamCU0Htb9RFtOvfuy6lPHBUEb9KSmV1zIOr2hbkzov s0FJU/iH qNzGDidbxJk3Vt7M15ewRTZNrkl1IhNYlEAQiaFi1uSZIbjeeFU84sz6/8nuNSJOfSmgWgPHTDMu1oFJolyVG8ZKvd2IcRyjlYw8+hL1a7eyHkh+whLl39zoSmzLY4gcVrVm5uMhjmZ/kVNIf+dal07bJm4b2mQ4I2YuvBaC1LcDHDNzdjdOMKB5dyHWYqqeVgIeRce3MAEQO5I8itQt3unoY5l8PUGSf9gSy2SOwHzEyNg35TPu1f+HSuvRmnbPmncHYuXr87S1Rw7LkHKUYndgryBcZIxmGKMi1KumStFd/kzLtP/zB3NHcEyA07liZCyaeGBgN7XsXMH/3ipVHN0FnLWPB0mEzIIJQ/xpVxpAiILB+Z4H7iIQajAHHe3wyLCnVr0xcAA10OLlPwFc6D2YxBbfveGWE0UVVOK+5k7MtGtIUY1XFJGp9RR+4BR3ilEEYCGmKP5Wb5H11AKHCWloLdECYlSfmNgBlTIu0qXs3BWIn4J1QxaBDi11tnD2gXfRloLX2JNXFjtafGQSw/JuSWvzvE5qkzef2exH5walmuJh1ZD4SDwpuCTvmBR7Irb3l9XxAMRDf4I1XYbCXMBRwSPkIXI6xBHBHygZk7V7vlSmTcN2XRsaxbQQVo1ym6zTCFX+whsFezbc+6ZaSPc0kTmXyYMzP+VKDvZzVVinbVLIeI3XLnCqqxodrUJQa3JH+adH09+Rz9puPyZijx7sCV9CeT6+u3y5zxPD9zYizPsd7+o7P+b1ypJYPFmPvVlj5vgalicPStXwfI+3HEcYyJJyLAxqCdZz/oUCAGEG9UWerB+5kme5XevNeiRZUzphe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/4/25 02:35, Balbir Singh wrote: > When a zone device page is split (via huge pmd folio split). The > driver callback for folio_split is invoked to let the device driver > know that the folio size has been split into a smaller order. > > The HMM test driver has been updated to handle the split, since the > test driver uses backing pages, it requires a mechanism of reorganizing > the backing pages (backing pages are used to create a mirror device) > again into the right sized order pages. This is supported by exporting > prep_compound_page(). > > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich > Cc: David Airlie > Cc: Simona Vetter > Cc: "Jérôme Glisse" > Cc: Shuah Khan > Cc: David Hildenbrand > Cc: Barry Song > Cc: Baolin Wang > Cc: Ryan Roberts > Cc: Matthew Wilcox > Cc: Peter Xu > Cc: Zi Yan > Cc: Kefeng Wang > Cc: Jane Chu > Cc: Alistair Popple > Cc: Donet Tom > > Signed-off-by: Balbir Singh > --- > include/linux/memremap.h | 7 +++++++ > include/linux/mm.h | 1 + > lib/test_hmm.c | 42 ++++++++++++++++++++++++++++++++++++++++ > mm/huge_memory.c | 14 ++++++++++++++ > mm/page_alloc.c | 1 + > 5 files changed, 65 insertions(+) > > diff --git a/include/linux/memremap.h b/include/linux/memremap.h > index 11d586dd8ef1..2091b754f1da 100644 > --- a/include/linux/memremap.h > +++ b/include/linux/memremap.h > @@ -100,6 +100,13 @@ struct dev_pagemap_ops { > */ > int (*memory_failure)(struct dev_pagemap *pgmap, unsigned long pfn, > unsigned long nr_pages, int mf_flags); > + > + /* > + * Used for private (un-addressable) device memory only. > + * This callback is used when a folio is split into > + * a smaller folio > + */ > + void (*folio_split)(struct folio *head, struct folio *tail); > }; > > #define PGMAP_ALTMAP_VALID (1 << 0) > diff --git a/include/linux/mm.h b/include/linux/mm.h > index ef40f68c1183..f7bda8b1e46c 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1183,6 +1183,7 @@ static inline struct folio *virt_to_folio(const void *x) > void __folio_put(struct folio *folio); > > void split_page(struct page *page, unsigned int order); > +void prep_compound_page(struct page *page, unsigned int order); > void folio_copy(struct folio *dst, struct folio *src); > int folio_mc_copy(struct folio *dst, struct folio *src); > > diff --git a/lib/test_hmm.c b/lib/test_hmm.c > index 95b4276a17fd..e20021fb7c69 100644 > --- a/lib/test_hmm.c > +++ b/lib/test_hmm.c > @@ -1646,9 +1646,51 @@ static vm_fault_t dmirror_devmem_fault(struct vm_fault *vmf) > return ret; > } > > +static void dmirror_devmem_folio_split(struct folio *head, struct folio *tail) > +{ > + struct page *rpage = BACKING_PAGE(folio_page(head, 0)); > + struct page *rpage_tail; > + struct folio *rfolio; > + unsigned long offset = 0; > + unsigned int tail_order; > + unsigned int head_order = folio_order(head); > + > + if (!rpage) { > + tail->page.zone_device_data = NULL; > + return; > + } > + > + rfolio = page_folio(rpage); > + > + if (tail == NULL) { > + folio_reset_order(rfolio); > + rfolio->mapping = NULL; > + if (head_order) > + prep_compound_page(rpage, head_order); > + folio_set_count(rfolio, 1 << head_order); > + return; > + } > + > + offset = folio_pfn(tail) - folio_pfn(head); > + > + rpage_tail = folio_page(rfolio, offset); > + tail->page.zone_device_data = rpage_tail; > + clear_compound_head(rpage_tail); > + rpage_tail->mapping = NULL; > + > + tail_order = folio_order(tail); > + if (tail_order) > + prep_compound_page(rpage_tail, tail_order); > + > + folio_page(tail, 0)->mapping = folio_page(head, 0)->mapping; > + tail->pgmap = head->pgmap; > + folio_set_count(page_folio(rpage_tail), 1 << tail_order); > +} > + > static const struct dev_pagemap_ops dmirror_devmem_ops = { > .page_free = dmirror_devmem_free, > .migrate_to_ram = dmirror_devmem_fault, > + .folio_split = dmirror_devmem_folio_split, > }; > > static int dmirror_device_init(struct dmirror_device *mdevice, int id) > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index f29add796931..d55e36ae0c39 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3630,6 +3630,11 @@ static int __split_unmapped_folio(struct folio *folio, int new_order, > if (release == origin_folio) > continue; > > + if (folio_is_device_private(origin_folio) && > + origin_folio->pgmap->ops->folio_split) > + origin_folio->pgmap->ops->folio_split( > + origin_folio, release); Should folio split fail if pgmap->ops->folio_split() is not defined? If not then at least the >pgmap pointer copy should be in the common code. > + > folio_ref_unfreeze(release, 1 + > ((mapping || swap_cache) ? > folio_nr_pages(release) : 0)); > @@ -3661,6 +3666,15 @@ static int __split_unmapped_folio(struct folio *folio, int new_order, > } > } > > + /* > + * Mark the end of the split, so that the driver can setup origin_folio's > + * order and other metadata > + */ > + if (folio_is_device_private(origin_folio) && > + origin_folio->pgmap->ops->folio_split) > + origin_folio->pgmap->ops->folio_split( > + origin_folio, NULL); > + > /* > * Unfreeze origin_folio only after all page cache entries, which used > * to point to it, have been updated with new folios. Otherwise, > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 4f55f8ed65c7..0a538e9c24bd 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -722,6 +722,7 @@ void prep_compound_page(struct page *page, unsigned int order) > > prep_compound_head(page, order); > } > +EXPORT_SYMBOL_GPL(prep_compound_page); > > static inline void set_buddy_order(struct page *page, unsigned int order) > {