From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B2BBEB64DD for ; Thu, 6 Jul 2023 07:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48D408D0002; Thu, 6 Jul 2023 03:38:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43D068D0001; Thu, 6 Jul 2023 03:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 305808D0002; Thu, 6 Jul 2023 03:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1DD578D0001 for ; Thu, 6 Jul 2023 03:38:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AF862A0213 for ; Thu, 6 Jul 2023 07:38:35 +0000 (UTC) X-FDA: 80980384590.30.7A87664 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by imf13.hostedemail.com (Postfix) with ESMTP id D5EEB20005 for ; Thu, 6 Jul 2023 07:38:33 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=pi0wFpf6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of rientjes@google.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688629113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3wp3nIROV9TflcSxrE2jgJnjD70KAFiAFAmondYIM9o=; b=HOGubVfhdvCLxXnRJ7NkJCfLdr581EPOLrCmS2ufsKq3LR+v3SxiFYSfkWdvcPdVr3/WPR cvSfozQT1MPZNVNPWRlFjJKdVNbYdZtvCJIuSukGrTqLDStgIl23C+dhUJhXFRGEzUw9dr sAhtIJJD6hVeF5kyfw+6WgdjIt5z/rU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=pi0wFpf6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of rientjes@google.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688629113; a=rsa-sha256; cv=none; b=A6DM5AQyUJ7Ox/1ZEgFZHausqe+YZan+XPaVcpYTv86xh5oWO6ncE1zd8KT6FgC8/oNB/c RDnJcQPp4S4qSkFCQIWZr6t7S7yDTpHTNoikEYm5eIDCzcvX1fIq+MFwScJOzUy6jOULrz vUv1oJTtpI/EZkDO2HdG9CHsoDID3PQ= Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-346258cf060so104695ab.0 for ; Thu, 06 Jul 2023 00:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688629113; x=1691221113; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=3wp3nIROV9TflcSxrE2jgJnjD70KAFiAFAmondYIM9o=; b=pi0wFpf6X/VZ+08PP1Q0vtFiGT/HRzAcVttvm+YOm1EQJGnmEd9pzlrDboY9mitk87 SPrhjB6f4PmNUY6SmToKx9lmhkM6+jGz/Cxdcl93ITxBZzHXLEDBlpQtqI1wZpQ0hBW6 wc62RTY6r03WMVr0OLvcbrX2o0VABOb6JLw6Trc30mnvMEo6/SmcTsoy7d0RyZokuhqV 8NPCjQ6PSobgFIHwqV1zkvFFcR8deNH7SQgi4uPG68T8mIWQvz1mvjbtbMn+pDAIDCim nCo9Ywbkd4Ye1HSLU8tKdVyjc1SS5MaxlOzR4KPMy8M+g34AIxyJme0IKQAzgjPjJqa+ xyrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688629113; x=1691221113; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3wp3nIROV9TflcSxrE2jgJnjD70KAFiAFAmondYIM9o=; b=TV0fDVWVHKpptKs0ztIioO6SoChHNzxq/wRDW5YhNMUch9vDgn+ZGlkG1dgnPkoMdJ Q4aEt0Ax8I0FgD6hEn2nMS7hogv0CfFI4oXMnZl9sLucJfL5TRjE3Y598j8Y+wmlJSUZ RGUNoFd3BUyvJ1VOMQ9ChFas80iZIzLqaZ7Iu6Ggxk2aab60tCDTC/EUn5MEkPY2jHq9 h91Cjgr+Yj11ZKS7IjQcrjnFYvROzjaPPR0Ri3sR7XG9F6rvE0+NQgWby6xiS/NY7Lh0 7/75vSLsOdRCySgUF8mPEKWyl+icLBeuLKI58+U00qHrc4qiaUW24QOH5CK3ObSrITAc gcUg== X-Gm-Message-State: ABy/qLaqg6GrMT6vs3LcQ2QesQtz1jADlRtdXGlgaqpCnejhPaN317w3 T0EeBxizFduR124FgwRRf+nrhQ== X-Google-Smtp-Source: APBJJlGuOq8c1qAySXCbXUJ4wcUjJsKRJcSRgxSb9ccHR7tXNLCcwrUTKQ9BheOlDBW7sHnn8hr8Ag== X-Received: by 2002:a05:6e02:12c9:b0:346:8c2:5f92 with SMTP id i9-20020a056e0212c900b0034608c25f92mr70825ilm.19.1688629112865; Thu, 06 Jul 2023 00:38:32 -0700 (PDT) Received: from [2620:0:1008:15:4e6c:6fcc:6706:5cc] ([2620:0:1008:15:4e6c:6fcc:6706:5cc]) by smtp.gmail.com with ESMTPSA id fe7-20020a056a002f0700b0063f0c9eadc7sm657569pfb.200.2023.07.06.00.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 00:38:32 -0700 (PDT) Date: Thu, 6 Jul 2023 00:38:31 -0700 (PDT) From: David Rientjes To: Julian Pidancet cc: Christoph Lameter , "Lameter, Christopher" , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Kees Cook , Rafael Aquini Subject: Re: [PATCH v2] mm/slub: disable slab merging in the default configuration In-Reply-To: <8813897d-4a52-37a0-fe44-a9157716be9b@google.com> Message-ID: <17349901-df3a-494e-fa71-2584d92526b5@google.com> References: <20230629221910.359711-1-julian.pidancet@oracle.com> <38083ed2-333b-e245-44e4-2f355e4f9249@google.com> <8813897d-4a52-37a0-fe44-a9157716be9b@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D5EEB20005 X-Stat-Signature: na1n4kjh34ewg36wygnswrq13j9sns6f X-HE-Tag: 1688629113-386687 X-HE-Meta: U2FsdGVkX18g3u7HVwydDi4ZhExDApQ5lmM/fL280bj6XtbUbZXMslAL0q9tsR/DB3mtl8w3bOGoFLLQbYZs0XlaJZVUWbcatq8UCTDOqgxELzNqsBrYSylb+1thjdNdyzS60JT418rYa1TU0wXM1OP6oW68l6LIqkpz65e/pt6lTD43KPbHuJ50KKB6bhKwBV0OKB9H4bSj6E1gSFsPE+/cqbQ/gGBz3KYy2MO1GVZ1JxGyEzjQUauTgwb1B0Dt5LcQAO0p/EE+rGlL3mbRfeB/vESBz4reNVnm8CYS94TyQnW/KSR2P9ZLHPeCfPqHGy9oK5TwRTkqgf+Oz6+hcF/VxPpOcW8969TC+6bJWta58kCPcqeC1PSRalnxRfHMCtpNpB9h6HeUM2vykXij4siatAyA1zXLas+1sTUDmf3e8xfoPSwEE67dCaHnQQyy7627F6ImcEr22WN3yz7RP8uiqZbkPyEBofJwiTKOV8ZOuvzYp/VsI6+fAto/4vwROxAIgyVjwUbl05vt0TKdZyT0pNM9HJo/r+xbaV3yBjnKVpg3JT7vOchpNAzln97LZZAvLyhje9eWof88kEnOEKyrDlGrd1eq8w+6KAzoqaCqPapKRBgzDBDYJvZDm7nOBQiSuljWztVhC9FTt5Sg7Ppt9v9EHryE/TvlNIdVgaO25E7umdW7kZJcry8FCGincoHCWR6UfPQGRXQDCCyiVE8BUjgy3EtDhiaKhu+AxSzTwGO99hrSiE+y2up7NMiIXafj3aGIWxTnmgP+ZRz3pYMa9n1HUVd0/rVFpw5x+jhkffowQfzoKVsVopa/Q1XKGK1T+SpI5FEasqK66MGi2pYnQeU+061xTGfJI9F0me0Lm4DGZH7Ipy/7Qnq2lPEK/Y3umCGrYThbRUaz7kbJRDq1rF+ky7FgHRFu9SlK8ammyNLs2x+00pMkdzaTGeeLyluuInB2YtUinvEYMyI o0N9P0J4 nWMVNyOB5l/h9WFdnT7m6kuShQZpOaGMcL6eot3PFjj4vV7ZC2dMJ8MbsEyx2MHLa9HBExt6OoJ3dEOfMNCg74nnq17AWm2rid6rE7TtzBxZcZfuWfnBgZYngOQ/l59Vh7CU46BAlprz7e2aDZmctqt0EkgxnIWzEjYG2qYJi4mL4Ckwn5PRgZNfwRUxcZN4DbSkC0yRWss5TJVeFFDGNW2YjEdOdoxp1kvqccaLhcsbhkJvnupokOS/013dSKnXkDaMFeteddCQMq+z/jERU/wJSgTuF1uXHdfdD0MJDtE1xJsvQakpbbw7TfTBshCe1bkkvG80FX7fM01JaQtmCuBGdi5NRPdevvgkxD8DMvg3y8MbwdfCPEtRBU31oQykL1bdXjArjELEDSngJcYCs8xFjTjmdQTAaLYs6U7mW7gqRhV7dNvBVWCRUhOaKQaJqdK1t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 3 Jul 2023, David Rientjes wrote: > hackbench Running hackbench on Skylake with v6.1.30 (A) and v6.1.30 + your patch (B), for example: LABEL | COUNT | MIN | MAX | MEAN | MEDIAN | STDDEV | DIRECTION --------------------------------+-------+------------+------------+------------+------------+-----------+---------------- SReclaimable | | | | | | | (A) v6.1.30 | 11 | 129480.000 | 233208.000 | 189936.364 | 204316.000 | 31465.625 | (B) | 11 | 139084.000 | 236772.000 | 198931.273 | 213672.000 | 30013.204 | | | +7.42% | +1.53% | +4.74% | +4.58% | -4.62% | SUnreclaim | | | | | | | (A) v6.1.30 | 11 | 305400.000 | 538744.000 | 422148.000 | 449344.000 | 65005.045 | (B) | 11 | 305780.000 | 518300.000 | 422219.636 | 450252.000 | 61245.137 | | | +0.12% | -3.79% | +0.02% | +0.20% | -5.78% | Amount of reclaimable slab significantly increases which is likely not a problem because, well, it's reclaimable. But I suspect we'll find other interesting data points with the other suggested benchmarks. And benchmark results: LABEL | COUNT | MIN | MAX | MEAN | MEDIAN | STDDEV | DIRECTION --------------------------------+-------+------------+------------+------------+------------+-----------+---------------- hackbench_process_pipes_234 | | | | | | | (A) v6.1.30 | 7 | 1.735 | 1.979 | 1.831 | 1.835 | 0.086291 | (B) | 7 | 1.687 | 2.023 | 1.886 | 1.911 | 0.10276 | | | -2.77% | +2.22% | +3.00% | +4.14% | +19.09% | hackbench_process_pipes_max | | | | | | | (A) v6.1.30 | 7 | 1.735 | 1.979 | 1.831 | 1.835 | 0.086291 | (B) | 7 | 1.687 | 2.023 | 1.886 | 1.911 | 0.10276 | | | -2.77% | +2.22% | +3.00% | +4.14% | +19.09% | - is good hackbench_process_sockets_234 | | | | | | | (A) v6.1.30 | 7 | 7.883 | 7.909 | 7.899 | 7.899 | 0.0087808 | (B) | 7 | 7.872 | 7.961 | 7.907 | 7.904 | 0.028019 | | | -0.14% | +0.66% | +0.10% | +0.06% | +219.09% | hackbench_process_sockets_max | | | | | | | (A) v6.1.30 | 7 | 7.883 | 7.909 | 7.899 | 7.899 | 0.0087808 | (B) | 7 | 7.872 | 7.961 | 7.907 | 7.904 | 0.028019 | | | -0.14% | +0.66% | +0.10% | +0.06% | +219.09% | - is good hackbench_thread_pipes_234 | | | | | | | (A) v6.1.30 | 7 | 2.146 | 2.677 | 2.410 | 2.418 | 0.18143 | (B) | 7 | 2.016 | 2.514 | 2.268 | 2.241 | 0.17474 | | | -6.06% | -6.09% | -5.88% | -7.32% | -3.69% | hackbench_thread_pipes_max | | | | | | | (A) v6.1.30 | 7 | 2.146 | 2.677 | 2.410 | 2.418 | 0.18143 | (B) | 7 | 2.016 | 2.514 | 2.268 | 2.241 | 0.17474 | | | -6.06% | -6.09% | -5.88% | -7.32% | -3.69% | - is good hackbench_thread_sockets_234 | | | | | | | (A) v6.1.30 | 7 | 8.025 | 8.127 | 8.084 | 8.085 | 0.029755 | (B) | 7 | 7.990 | 8.093 | 8.042 | 8.035 | 0.035152 | | | -0.44% | -0.42% | -0.53% | -0.62% | +18.14% | hackbench_thread_sockets_max | | | | | | | (A) v6.1.30 | 7 | 8.025 | 8.127 | 8.084 | 8.085 | 0.029755 | (B) | 7 | 7.990 | 8.093 | 8.042 | 8.035 | 0.035152 | | | -0.44% | -0.42% | -0.53% | -0.62% | +18.14% | - is good