From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21CB8D4336F for ; Thu, 7 Nov 2024 15:13:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9172D6B0088; Thu, 7 Nov 2024 10:13:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C6D26B0089; Thu, 7 Nov 2024 10:13:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B62A6B008A; Thu, 7 Nov 2024 10:13:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5BF226B0088 for ; Thu, 7 Nov 2024 10:13:18 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0261740876 for ; Thu, 7 Nov 2024 15:13:17 +0000 (UTC) X-FDA: 82759639998.20.108F01C Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf19.hostedemail.com (Postfix) with ESMTP id 66B581A002D for ; Thu, 7 Nov 2024 15:12:31 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=fZqihrX1; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf19.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730992336; a=rsa-sha256; cv=none; b=hwCwVjUx7M/xm9f4zXwe2ggH8AwHN7AC00h2jklO5AEdTThiVMF89v6iMg89qn3y2whP2v rDjTR96aPN0YStfYBGADa3RAQ9uHrbIgVjE52EExktbmgz9GyPBb2bAy+GTJfQvr3pFj9V 0liEG01Q2YuIy6dNs+x0zA8t7GpHnSM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=fZqihrX1; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf19.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730992336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gF6tgpZVjlzW/6qkLSleVCiPXZtrJcTCC1bsI96b+2Q=; b=thy9vGudeVcylXVGMD0b7SNRw/RkF1nrfwbegzi3ChdnLqEoRHM421K6UNuSGAzu3b2o/Z NDEyyyqfh2tFh+F8iCUArmyTdlMtFqjWikXNH/QSbWIzmW746GX+riNGFXQ4w4a+4xWhud rztDLeEcAhA+5pVrLgo6XY3gxqhp35w= Received: from cwcc.thunk.org (pool-173-48-82-224.bstnma.fios.verizon.net [173.48.82.224]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 4A7FD64X003521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 7 Nov 2024 10:13:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1730992388; bh=gF6tgpZVjlzW/6qkLSleVCiPXZtrJcTCC1bsI96b+2Q=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=fZqihrX1H038m4g9Wwz5BfzkGzj86qnu+ER5o7lZc6DTQAFCkFc5NvsxjT+aaTFKJ 6QlnvAqXE59Mu68ChrzNjTPdRqBvb2ks2yzhlG/giyWfHzKGiv4prmfmIYKQOQyyiu VxD5G0TlKKKwvcq/2txDZcM+PdZNrYrvEI2jhFo6lBNMitrNxB9KfJKrgE+n5WGVaq 9Hmz5YW44SGzLEmexigOHOUzrlXV9ESO5bjhANvHLeF5PeL0YEuZuezRKGG+YuedEV vm5YHdLs1JJwxDo+mFsXjz50ueuHooPueysF4jWeH1z0a99dE1XCiq/TI1lSpCoVBF IK4pESH8nb15Q== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 42DDF15C0332; Thu, 07 Nov 2024 10:13:06 -0500 (EST) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, linux-mm@kvack.org, Brian Foster Cc: "Theodore Ts'o" , linux-fsdevel@vger.kernel.org, willy@infradead.org Subject: Re: [PATCH 0/2] ext4, mm: improve partial inode eof zeroing Date: Thu, 7 Nov 2024 10:12:55 -0500 Message-ID: <173099237654.321265.9905047947203401102.b4-ty@mit.edu> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240919160741.208162-1-bfoster@redhat.com> References: <20240919160741.208162-1-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 66B581A002D X-Rspamd-Server: rspam01 X-Stat-Signature: jxa3da7urron5kn1s6gqh71gfqewhew9 X-HE-Tag: 1730992351-701887 X-HE-Meta: U2FsdGVkX19dvGbn+KBAvc1qctqTry9cNaO1Piba8QO7aMHHvS0bRZrKyfrjVJnXWgwZ/8iIPFwAQ5uh0xW/IiKN/kVvIcqB0CycNKc23aLwjiyB+Y/gSlyZTecdVrEkGQTe/rIsP/DocXCVXSQVyRA4o/rZGu92sGO3ILWeVb1JF+1FF3ra251G1oarvhr86RqlZeG2pGmF6Y4U6Tlf9U/CjsZakxVueR/wynWAiv8wn25SjhSFZxIV2bQ9fgSOGF9q5iIT/iuvSJdmJqcm4C8ZHE+HhQh90gCEatGTk91kDpgTYnH++2RRcjwc1JYXmukneQtqzy8Hbf2k9aCC2xiIxbjfgE8rXS8W7VAE91B95a0rs1CSqEqmaZ8wHE4S+DnJZ6hkHkn8Cx2Q3dVWEFAPs20m9DkTRatdwR2zvRQKnTna+dxcsTC4RNx8JytGloe5NYX7HKFbID4MN16p2yfJoLiHl5TxdS2amH96VblYKRfThM8AVms3jQYpKgDRIx/iHeqjEBisRSW1BINOOtBYsfneMtLf7YcADHDUdZ42OvDaY3ePXkMwOb+DWfZJowgpwuyyjQQBqlRzn801dkCczR78kJ/eui+xLZMkNXlhWWZg+LrM4bHOlXA2mT2hNugHIkkHAXz3zyCo77KljTibw3L0R7o2wgT8GesnvCAUpmJPjSN9qazuLdWXMFjEOuelFO9TSUaIfEU0y1agFVsD6yntBEs3P0uo7ICEUxNqug8juxQ8wnQhpUHcbiRW8S78HAzalaYW3Qd1vgOdKHuMOnN2PHr2X9IIz7JwLjjIIJotIublkAYCeNgu6QD1cL53ah8yy6n+l3DlJcpWGKowMN+vm2vcBgNJ2h/Y6erl6AGYszKQIMovaxwx467Q0L2dviyB1L78VtxuO8bUAQuEQD4ChoAEnwim/qub686Fvy3uKRhLCErmgjXhK1AOfOzQL86QziKufR8dBIC vVKO7wPc f/avdS9rHf0nbu/aDInCgPKhDvRo/PY3vdq9BCRivtMnsm9z3WI9LdiVUnqsTWOEY3y4Q0SYskISJKvNXp0FsAgK2f5DSosC+yIcL4GOuRdA9c34L/F0qZTxDLEgfl4p+WrpGN8NPQXk55MilBP0r/cJaPOUxJ8cOKsnUat9hhpU2pZ4hb7m0MhLRdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 19 Sep 2024 12:07:39 -0400, Brian Foster wrote: > I've been poking around at testing zeroing behavior after a couple > recent enhancements to iomap_zero_range() and fsx[1]. Running [1] on > ext4 has uncovered a couple issues that I think share responsibility > between the fs and pagecache. > > The details are in the commit logs, but patch 1 updates ext4 to do > partial eof block zeroing in more cases and patch 2 tweaks > pagecache_isize_extended() to do eof folio zeroing similar to as is done > during writeback (i.e., ext4_bio_write_folio(), > iomap_writepage_handle_eof(), etc.). These kind of overlap, but the fs > changes handle the case of a block straddling eof (so we're writing to > disk in that case) and the pagecache changes handle the case of a folio > straddling eof that might be at least partially hole backed (i.e. > sub-page block sizes, so we're just clearing pagecache). > > [...] Applied, thanks! [1/2] ext4: partial zero eof block on unaligned inode size extension commit: 462a214e71f3fbc40d28f0a00fe6f0d4c4041c98 [2/2] mm: zero range of eof folio exposed by inode size extension commit: faf7bba6b84981443773952289571e5ebeda1767 Best regards, -- Theodore Ts'o