From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3864FE67809 for ; Sat, 2 Nov 2024 20:05:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C15826B008A; Sat, 2 Nov 2024 16:05:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9E196B008C; Sat, 2 Nov 2024 16:05:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A40606B0093; Sat, 2 Nov 2024 16:05:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 81D636B008A for ; Sat, 2 Nov 2024 16:05:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0A0E48154F for ; Sat, 2 Nov 2024 20:05:40 +0000 (UTC) X-FDA: 82742234274.21.F19A0D0 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf04.hostedemail.com (Postfix) with ESMTP id 8611240007 for ; Sat, 2 Nov 2024 20:05:00 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f7aOUj4o; spf=pass (imf04.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730577757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f1ekLEpQuZlddbxwbND8P56+Ak3oqJM/s680G7r1FXc=; b=cq0WdggFCphNTd6pSCQAAIgVdrIwJGWSjr+uyyMJlwfj5zv9CAglkum8crB5ani2rcTX7g IM1tJwPWKjqCD0fePXNcp4bq8IYtWqPF/3R5NO9hckkmahjp3qoX77oAcDa1s+VWx170Tq oaPXhdHADpNLlUY6A9/ygf99WJuD/bU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f7aOUj4o; spf=pass (imf04.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730577758; a=rsa-sha256; cv=none; b=KxBmVRvKd894IGYTdMChUq3/4SdMSOxn+Aw86hRlH7yYaFBek0JZ7nfll5bA6imm1qyfAP 3fz9PdQPFt63bG9DIuzz3wpkb4OrvZWb5DV3bzDxUjkLl9GtsYWY8ZDn++7SH8hdkXzUri R/lz3bQ2WBw26YZCZlnarWBvJK7o0nA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 76A53A4152B; Sat, 2 Nov 2024 20:03:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84986C4CEC3; Sat, 2 Nov 2024 20:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730577937; bh=6pOQI71vKH2U1t1m/PWM228AhDTBFZFVdAXY5O7tmFo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f7aOUj4oOIcMGB555wwaczb/S10oLnefaMyFTeBdNSNmYRAhdVKjOhs3zoEr2ngKU VZF9lNTV1Qi7mpprpwDElGbktCvJliNeoaXz74jJPrKFP66n9BR5yrXg8BZlzG/iBG 2YNkAyrH/VVoaH3RmjH3inkkN6Wped6S/Fq1MReW0M8bwLSVIXWirQ2Iwvun9OS+Mb IT4OdX0Po2t5P7ZKu03rlai4UNYt9/Li/CiD6Bg0ImL6xQl5tRHg5Q85FuxIIEwrHc NuV/WJ3JeXAoMulIdSCXwY6Tn3ZTsYLRQyYbr74DVJFBg1eQ8g7ZO0f1iU/KcmNYNW y/7f2gefRjTNg== From: Kees Cook To: ebiederm@xmission.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, nir@lichtman.org Cc: Kees Cook Subject: Re: [PATCH] exec: move warning of null argv to be next to the relevant code Date: Sat, 2 Nov 2024 13:05:29 -0700 Message-Id: <173057792683.2382793.11435101948652154284.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8611240007 X-Stat-Signature: id8878jz8oqfbxewm4ifiqk6owu43xo9 X-Rspam-User: X-HE-Tag: 1730577900-553563 X-HE-Meta: U2FsdGVkX19P8tCizK1D16Zd5rKOEI+hN/SKZyZI3lDXGcErsm1n97AZTxIII5KwiX4gqJDLOgv7Dr05zFajiG6x1ioV7aQKAIMg/gHtXtKYIX5jBlL51haRynKL7CnsDrwk4cePPwlhYCRQGfQOugLej1I5mJGKD8t8SnjujUjAYpxQuzafK8OtCaIV2N55wmk6E0rhP/WpAfj4WEPJP4K1rgoveEYrjAda4FGngNKJhlScCddlVzAWh388jG52Hix5WhhtQpZ4qSwhj3aJsIqp15VhcqWLL57SsWNKUK+92bMB3DzKcSQmSZe7LrFPs2djs+2VEz6LBxK/r4qZZwlkYaaQhbnjPDEGL/UNy23y5dKTB0ETPkN4PJmT6bW16+DH3WV1fv2R8ZI69QcXPxqHjLeHSSTA2+zVacnNUR+tVPDVCh9C4S9Y49OaIRZiXEDYNTHNvOvhb41KC7QpJKNfkh08Wxda5FF+EY5ENMmM/LP4ZFMkY7nukVb3RT+puL30f8IaW2jYILlXF78fKX652JmN70V2EF8MUoPuZpCRjl6J2aILTZJwfUZqTWVm+lbIS8e9MnEx+B6d1fBOtI6dK2fZQn9VRC2qvn4JsNESVkd6a48WPDP/X2rJxjXHyvYRsbiX4Owa99sIQFyHqNw70lZqmzu01tF/mJ8co+OA/1aMo2YuybLD5qSMqNxcUGJeNckc1ktlQxeTeC3HCpfbLze5Ngsbm9+MYdycb0siZp9Y6Jjci/FZ5ySkUafVmNcfn2wZp7Soxp0v7e9v/nT4o/x60mVxkH+bYMcuJ9BRXg+seytuYspbI7LXTrHDdmd2ZekMhc1HB7M0kCakfyrIMJRFgXJaNivDp/Zs72+GHW9flfTj5Vc2E2ZFsjutoBoyXAn5gdhjvA066nGbJP+SanZFESJ85oekhVq53Az95cYdaVdI8hiZm5DjrS257MShL6/ADzahUToliCm j15187e2 MTFVx8pR+7AFXYLd6fHM/J12OlPPpE+Wdgrp4mdRlGjteM03rJIFT0ZPINrlhEkVqfFjc59CyJsOM+i3gh17a90sw9ZPH3bYDRVya3Ns5K5QROcfsK2ts4fvO24RNhW6AZbgt3L+5wYCeWSsWPkC4j+V4OpI2BJsLFTX/x9y+Xtdy+X8FfdSrF9rJzUIyHgHc/jWSNpstvkN4YQ1YAmtKB87r8WzghvdPp36l4kO0qeSHewlgMya50KH6zO6vVgeCzseneDdw/rGw7XZ/gfCbeQ3Ok7jn0y5/UBSk1y9tKBRv8aC+eX9ysxEucWKN/YMiXgvdX5mC7FKr6s8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000154, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 02 Nov 2024 14:01:22 +0200, nir@lichtman.org wrote: > Problem: The warning is currently printed where it is detected that the > arg count is zero but the action is only taken place later in the flow > even though the warning is written as if the action is taken place in > the time of print > > This could be problematic since there could be a failure between the > print and the code that takes action which would deem this warning > misleading > > [...] Applied to for-next/execve, thanks! [1/1] exec: move warning of null argv to be next to the relevant code https://git.kernel.org/kees/c/cc0be150ca0e Take care, -- Kees Cook