linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: ebiederm@xmission.com, viro@zeniv.linux.org.uk,
	brauner@kernel.org, jack@suse.cz, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	nir@lichtman.org
Cc: Kees Cook <kees@kernel.org>
Subject: Re: [PATCH] exec: move warning of null argv to be next to the relevant code
Date: Sat,  2 Nov 2024 13:05:29 -0700	[thread overview]
Message-ID: <173057792683.2382793.11435101948652154284.b4-ty@kernel.org> (raw)
In-Reply-To: <ZyYUgiPc8A8i_3FH@nirs-laptop.>

On Sat, 02 Nov 2024 14:01:22 +0200, nir@lichtman.org wrote:
> Problem: The warning is currently printed where it is detected that the
> arg count is zero but the action is only taken place later in the flow
> even though the warning is written as if the action is taken place in
> the time of print
> 
> This could be problematic since there could be a failure between the
> print and the code that takes action which would deem this warning
> misleading
> 
> [...]

Applied to for-next/execve, thanks!

[1/1] exec: move warning of null argv to be next to the relevant code
      https://git.kernel.org/kees/c/cc0be150ca0e

Take care,

-- 
Kees Cook



  parent reply	other threads:[~2024-11-02 20:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-02 12:01 nir
2024-11-02 20:05 ` Kees Cook
2024-11-02 20:05 ` Kees Cook [this message]
2024-11-02 20:20   ` Nir Lichtman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173057792683.2382793.11435101948652154284.b4-ty@kernel.org \
    --to=kees@kernel.org \
    --cc=brauner@kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nir@lichtman.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox