From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 148E6E67809 for ; Sat, 2 Nov 2024 19:58:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83EDF6B008A; Sat, 2 Nov 2024 15:58:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EF1A6B008C; Sat, 2 Nov 2024 15:58:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B6E96B0093; Sat, 2 Nov 2024 15:58:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4C8266B008A for ; Sat, 2 Nov 2024 15:58:07 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BBA7D160B64 for ; Sat, 2 Nov 2024 19:58:06 +0000 (UTC) X-FDA: 82742214702.13.26702FD Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id CC6EE100002 for ; Sat, 2 Nov 2024 19:57:08 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bo0as462; spf=pass (imf05.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730577351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cMK3+sNyUeiKKiTrVTE1KJdhxN0EnA8ZwBu1fqTy2go=; b=hPL+cHG6Tp5/vofCc4yysv/mIhtvUran3nx+8IFeRJxa9PJTgK2PM9zwSnUQ43MeS8qPcp 15m1E7vKO+7wzgpC3Qd/qs3LTxr7xs0L8qHIYXw8x2EcFuPEqH+8yfPbuWXksLtEeIfCem ynZBZ956kISCgl4DEi7sI54deWP6O9Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730577351; a=rsa-sha256; cv=none; b=eRuVq37AnV3y19aw7iAIeePH94cn1Sm7oeXHoDVGCqop1MUSomUIflbUREWwA2rLl+95y4 4a2CR+OnJBDzUBcbPI9o0ggewSF3ykxhSIIT91jBuyKaeEOU5upxBdGtg9tq5XPBirK3Ls 5iP3LOjUp0mVUmbKrAdM03lldy2yrmY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bo0as462; spf=pass (imf05.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 16DC9A414D3; Sat, 2 Nov 2024 19:56:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26D52C4CEC3; Sat, 2 Nov 2024 19:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730577484; bh=R1xUKfbTQ9Fj33YTxe1JXPAuf1O3HXqBTQGulBGQa0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bo0as462ZJAU3ux5c70cbRrXavhlsHmyvUUAszob4E8j+/Q7ZZV/R3tsDWu8vi3Ah 6GwCMPId7qpCcgvQhtdZ0RYEdWNuSoiPFvJiNqRmCw9VkJQ7AaAENwal3EuqNz4e4e RkGk3HxAPk1zW4UGIut+NVimiaqjCFcX8P7EHFyRNjwP5DDPb7tJrAuaovQMvuu6cI 3tHFOxKzMf8kFNtsorY0MrbYwVLQnN2K/fIr0G/+8qOTsjlZdPD3xSw4NiSScOBAQo BTT/7jQ7idFoAmoLUYP7+tCIlOIc14lZD19uLvh4POZVhqd38Nc7OuURZdD/UgwQTo NNfffy3UhL/MQ== From: Kees Cook To: Tycho Andersen , Dan Carpenter Cc: Kees Cook , Eric Biederman , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] exec: Fix a NULL vs IS_ERR() test in bprm_add_fixup_comm() Date: Sat, 2 Nov 2024 12:57:58 -0700 Message-Id: <173057747484.2382073.5760107237712372637.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <18f60cb9-f0f7-484c-8828-77bd5e6aac59@stanley.mountain> References: <18f60cb9-f0f7-484c-8828-77bd5e6aac59@stanley.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CC6EE100002 X-Stat-Signature: qbu4igp5owc4mer74zaxar5hg64o393u X-HE-Tag: 1730577428-745801 X-HE-Meta: U2FsdGVkX1+3y2XTcyt7do1wMlUD6HRNpLLFNn+TAI+VKxOlZ62PgbvuIlGc7W77OHN02v+TQpPawZ9eoj7tfKu4O5oOX5wxT65knibHUkwqfyDahXFgg9qo2O8P6TclaU/7c3TDgge9yDjmk1tx2gvWzbpo9RgnZrX3EAQMNaz8++qGsS82V7BbgsrHiMEDZcfAmJFCGf0hnOmNdJVq1V57E3waWpS/wnExPJxEpa8KV2i3XmcZV8T4e1ibV8ZvUiiKRo5SQdwTJJeKI9gvymz99rYU0rmZcIaVeUF4LNrRzFHNT80h0QLnX7NGlOdWhwkM2m9OMkpJ2hEaDUFlpK7Lhu8UzEVykMaPx8xtUBaQHRpGVl4ZOhbBM7RKjWjX8ArTKbBDpO1EYVpwNkBWE23PRDcTXfUKRUkvHv2axONIput5irUbXQUGkA2Oe8Stfd/0cN6Sd/gG5R0J0pMF+aop3yqz8vUzqyJtj4XSke0E4xT61eFl8JpShyvfOT3qjAkz3Bf3/L6k5//kxvZKZ0NSasMreQE7PX+/GLE16AqZERjRetoDLSYBmivsqOev4hykTjKVFIF5oK/7YCSBHSnt29/2wwZ3E7Wrqd/dHaHAcyod3NtWKJn3IF68gIDvq21C8WtFyi/K0cbIGd8iZf5ZXxard6pqEx0nqAgduD1J63l7hbp0f1f45DpyETtt9Ikb/4tu+q9zVfknWvUOFi4tUyaUMJ4tr2pZ2ZyGyRri8try/Wb4WKo1A9lvJNu6Cwo0uMOt2q9GK4LvseZL0xeBS54NRr/tgC0LLXzp87GN9jHsLopcaCHdNcfe4DcgJgDdn0iaA7Uqu6naysB4QigJGstn0g0oje6MpfpkZ7xPbQWw9hhf3kGY5FNfaf93eTCvyuO/NKwP46VkA0f6vv07R3izQjWpAZHKALxxKFEyFyOwPyrlSRE7I99XDoFmz98zI5S9H0LmyyvlL2F ilhnQiOx T3Cjt7zsuzJFrcCBNCYPTZyNhZfvEaWLIPRPYgZmsWLd+kHSBfyw7K+PygDh9qJJBYG+HZXJKURRKPsU5cImdI31Cs/st8mMw70AnH1w1Z6luAiW1uKxwGDnf1TNSFuVVqPCYr3t/egtrUYZUJhxo6xh2hRIWtbmF6jDWcMuv3o/YIFSSh2+ZYO5hitO5LKQloRIJHz7DSLmoIhYPKzPdhfJL4g4fFcbts2IE9VnQdCLhkqDLHBb8nZj9NyoqLQwe5TfNO4B+wrjMA4R34xEFfS1NSMHecxVhxCYJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 02 Nov 2024 12:31:14 +0300, Dan Carpenter wrote: > The strndup_user() function doesn't return NULL, it returns error > pointers. Fix the check to match. > > Applied to for-next/execve, thanks! [1/1] exec: Fix a NULL vs IS_ERR() test in bprm_add_fixup_comm() https://git.kernel.org/kees/c/05e60502723d Take care, -- Kees Cook