From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F20E6B278 for ; Fri, 1 Nov 2024 13:53:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5829F6B00A5; Fri, 1 Nov 2024 09:53:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 530DF6B00A6; Fri, 1 Nov 2024 09:53:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4205F6B00A7; Fri, 1 Nov 2024 09:53:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2A7A66B00A5 for ; Fri, 1 Nov 2024 09:53:14 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D3277C0564 for ; Fri, 1 Nov 2024 13:53:13 +0000 (UTC) X-FDA: 82737667320.18.F1C56AD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 6F22480025 for ; Fri, 1 Nov 2024 13:52:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mCGMVt5Q; spf=pass (imf02.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730468975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OKbYeB4AZKdRpe37hdOVZapIy7N48fQcy+QmaB7aa+M=; b=kOavuIfbPHVrwDqFQBn7Ht0XqJQHWfSn0ki0xopwdyCvy0Jkjg/5V9fwLJWcU7gtf725q8 cVtDFBTcDIE7tn3l/lNE3JGj2hbsIcKc5RgprAMISn9BdfK2sePfZ3EsY7doXR8KM0pImf 1a7HohJJUrRmljN3At71Ij+HcJT+ikg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mCGMVt5Q; spf=pass (imf02.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730468975; a=rsa-sha256; cv=none; b=cj0Fw1IftMhsbAgaCPsJBxbAW/M94I+0di+DeuTqb36K3PFmOcNocRO34Q7CkJPOQ+IRb2 WIm8YXbSMMIzim69K/nuDO2EP942cvrG1qdqUF+fOKqceBdfwOEbarJ8+VE+TBFuJzcTs3 wBaA/GKrp+xi5jbc/YrCUOQrcLedn+E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0D9F75CA3B1; Thu, 31 Oct 2024 22:10:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D429C4CED1; Thu, 31 Oct 2024 22:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730412645; bh=eJWDa4aohLV/Z7xA2xETjGrhQOcKItwfm9HyMbigK1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mCGMVt5QnrQFSrrinkV6U6+X6+MbhpZLeHAntZF6ihcuMVMPN1Co/j9fNo45bs4td 62u3Y1eVaNTlbHr0INFpD53agamzafgSyLdrkDsVVW9vXlFnyZAX2qORqgwsWQIeHh vDXY7QuM2biKlOHjiEV3W+EHbcy1BaO8QGsdEalUYYCo4pREXCBpmnvn5RyDgA9QY4 MWcDS4aOkk440yHIr5l94Jha7RwixiFHV8xfACXnb8IFPmoOmc8rbskDbID9E8LLXP gDhQvA3CkHjagc9bUFGrqv+BxsDhLhvUWcnsADCUpkPUQNCwjaU0xjRa4KbtGn+N2M ESz24DC7k+iBA== From: Kees Cook To: Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Shuah Khan , Tycho Andersen Cc: Kees Cook , =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= , Aleksa Sarai , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Tycho Andersen Subject: Re: [PATCH 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case Date: Thu, 31 Oct 2024 15:10:37 -0700 Message-Id: <173041263505.1781237.9706368369948860422.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241030203732.248767-1-tycho@tycho.pizza> References: <20241030203732.248767-1-tycho@tycho.pizza> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6F22480025 X-Stat-Signature: 73n9w3iw4kxz4ykru4f9oo7bhwmhnocx X-Rspam-User: X-HE-Tag: 1730469138-414433 X-HE-Meta: U2FsdGVkX1/Yyw/jEUuAznbKtXhIATn5FEY+wCkuhNpvh4dkJqwPkK2qOC3NyvR68cZpyAu4Z6iat/PR1P0cG09vDYDUaASD1XpgJc1EPDB05k1Sq31OV+Xz33mBDZacRIQIFdhGC2GBVXPJjLNiLmBnfWufPavdXHhVsw2zRxcZW/DDmtq46o2a4sLTijVVRcb3tvdvMPg3q6GSlc0Qau8oyQ6JlAdcizCqX/D/6doGz7RHgyZqYAqTB+3U+sknqQiHjRoahoYjmsgBLPolhrWUewUq90R4+eHNafsCKMxveWLE2Ak8lDwnVAlix41V92+/2ugdi/lWDgfP+tp+eSLI6GcN8U4vpqrjVjcSi/iQxsmFLm8UUktMfB7bl+lg7e/8TcbXs8KMtLHNyHrTqw02QwlLJ5h5E8DM4zYb/R0fSp1VCdLFhJY5bakGScwUrPTHkqLooP5N7aEjNHAYM6MBfZAVXqdHUsegn1H3/YoSYnCDKJZVwH5PMHMxKsUhN/pIA17jkdsX7vHdQe9R80XZOuI6ZlOIUq91kZY23mwTBDwmZ/5qhHKYMcaCWZ1ZoPOnvFG8qSnEg0S9t9V9mNOnJPeOjTFO8oJcAKs+W2M7/z4H9pmCRf/0d9k8IH9QOGRJkDPW83cG7axnMlSJcHzNd9JVzgiTXcMzjuySy3FUS7QG1hgmzrscdy5sVFzxfxCIpuRO6my9jsNZ+q9kThAXFKKrlUCfFneo4Y04/X60MvIrsWjnPh567pt70Jdz9fmm/XcyMM/toWveoXFujafzgWVMm+ItyeTegdXSHBr52zIAHcHfCV2WjHK8hqEr9Yki1dYUioB/jNg6psNZc7YNpL/W3rI2NeWWxaeGGG/Qw57Bp0AfYP0WSZcc9tcxZN20iYi5g1YfxPcTDBGJa8bItBuQ4KXQ0fhx6UQOU5BQTe2SPhZJolKQUQ//g7IZiVJ7w4gFB+oJR/k5BGI +Qas3a3l VmxEZqJzOJAH92c8GzNNgasl8rRoRn9vbjzjTPoNkuuB1h/sSh0h1ZS1XBwJPgWw5Iusy+7vRDPKZ+xhq8QlSydVcnQOOsQBEUC+LVdol5AGsKbfy33KKsxxZ+Hsmtx4sVRpI1tYemz0qs2AUWx655AKyr7tE5LUt2UvLybR1NZE7aySvUETcPwLRMiiJUOnHqARXZJePxjf+BEJLTW3lEDiJ8PMl7YxLGfxWyELSdmKalwoDNhIaL/t5Sz/MlEedVJfBa0tLHTu084O6SmKiYOPU1stKkBLzv3TL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 30 Oct 2024 14:37:31 -0600, Tycho Andersen wrote: > Zbigniew mentioned at Linux Plumber's that systemd is interested in > switching to execveat() for service execution, but can't, because the > contents of /proc/pid/comm are the file descriptor which was used, > instead of the path to the binary. This makes the output of tools like > top and ps useless, especially in a world where most fds are opened > CLOEXEC so the number is truly meaningless. > > [...] Applied to for-next/execve, thanks! [1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case https://git.kernel.org/kees/c/7bdc6fc85c9a [2/2] selftests/exec: add a test for execveat()'s comm https://git.kernel.org/kees/c/bd104872311a Take care, -- Kees Cook