From: Kees Cook <kees@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Eric Biederman <ebiederm@xmission.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Tycho Andersen <tycho@tycho.pizza>
Cc: "Kees Cook" <kees@kernel.org>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
"Aleksa Sarai" <cyphar@cyphar.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Tycho Andersen" <tandersen@netflix.com>
Subject: Re: [PATCH 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case
Date: Thu, 31 Oct 2024 15:10:37 -0700 [thread overview]
Message-ID: <173041263505.1781237.9706368369948860422.b4-ty@kernel.org> (raw)
In-Reply-To: <20241030203732.248767-1-tycho@tycho.pizza>
On Wed, 30 Oct 2024 14:37:31 -0600, Tycho Andersen wrote:
> Zbigniew mentioned at Linux Plumber's that systemd is interested in
> switching to execveat() for service execution, but can't, because the
> contents of /proc/pid/comm are the file descriptor which was used,
> instead of the path to the binary. This makes the output of tools like
> top and ps useless, especially in a world where most fds are opened
> CLOEXEC so the number is truly meaningless.
>
> [...]
Applied to for-next/execve, thanks!
[1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case
https://git.kernel.org/kees/c/7bdc6fc85c9a
[2/2] selftests/exec: add a test for execveat()'s comm
https://git.kernel.org/kees/c/bd104872311a
Take care,
--
Kees Cook
next prev parent reply other threads:[~2024-11-01 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 20:37 Tycho Andersen
2024-10-30 20:37 ` [PATCH 2/2] selftests/exec: add a test for execveat()'s comm Tycho Andersen
2024-11-27 14:25 ` Mark Brown
2024-11-27 15:00 ` Tycho Andersen
2024-11-27 15:03 ` Mark Brown
2024-10-31 22:10 ` Kees Cook [this message]
2024-11-02 11:29 ` [PATCH 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case Zbigniew Jędrzejewski-Szmek
2024-11-02 19:58 ` Kees Cook
2024-11-06 10:06 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173041263505.1781237.9706368369948860422.b4-ty@kernel.org \
--to=kees@kernel.org \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=skhan@linuxfoundation.org \
--cc=tandersen@netflix.com \
--cc=tycho@tycho.pizza \
--cc=viro@zeniv.linux.org.uk \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox