From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D0C7C5B549 for ; Fri, 30 May 2025 08:50:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B37A56B0093; Fri, 30 May 2025 04:50:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE7DF6B0095; Fri, 30 May 2025 04:50:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B0A16B0096; Fri, 30 May 2025 04:50:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 79D6E6B0093 for ; Fri, 30 May 2025 04:50:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D11B6C2A5F for ; Fri, 30 May 2025 08:50:32 +0000 (UTC) X-FDA: 83498953104.28.934848D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 67CAB180002 for ; Fri, 30 May 2025 08:50:30 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TVJayZrJ; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748595030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L0+8r+h5VJZKyWcv1fSQdLPCY66hBJlKTv4UFpyXBK8=; b=doanrdjhpPjzDWNQ5eVVT58oAv/uBUsZqkAAYRBdg2KNeVudlklChtB4b711/r2SVGSbXn 5KDqeMNVBjWN87lBmB5OMUZsNdJKkou5IVaRwGBuL8bblyxNDZUH59DPK993ciCOfQD9nw /FtB/km85HVzko9C3dzBvm5iTTkDF3Y= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TVJayZrJ; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748595030; a=rsa-sha256; cv=none; b=rNGi8YrTZEJ18RisBqNeALMZAV8CYNVvJcgQRMKKF2zx2KVijHQSJni2OwMqC9h468hpY4 uUUAIlgp0pu7vaibjAyqobymy48/WiWg0yPfrq/dAdAfYX/d2mjcitIg3fBYWTfWKtxD/F MnTLvF040pLS98UXlSoZ8iJ1RJvjbac= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748595029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L0+8r+h5VJZKyWcv1fSQdLPCY66hBJlKTv4UFpyXBK8=; b=TVJayZrJod8uBz5QqvTSaAl50R3znbbEsqdRT3Ti/Q+bpVBuhrigkAJkuO4f/e4oEe1NXw GNbIIDJcPCyal5Emfp+Qjq6mlTpyAxHkRR016EgSKWkeslRx2+Or96MjyXkyW0hAH+3Gst vEsVCwvzVExHmSJ8D3yaZMojHcNoaBE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-600sF5xbPT-4uXJotJSLbQ-1; Fri, 30 May 2025 04:50:28 -0400 X-MC-Unique: 600sF5xbPT-4uXJotJSLbQ-1 X-Mimecast-MFC-AGG-ID: 600sF5xbPT-4uXJotJSLbQ_1748595027 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so282246f8f.2 for ; Fri, 30 May 2025 01:50:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748595027; x=1749199827; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L0+8r+h5VJZKyWcv1fSQdLPCY66hBJlKTv4UFpyXBK8=; b=BhjESpF3JFWPHxXXvSOgcxJpyABM2sx1qgpL8Iysd9vVwhfpi5d+SJcwjvhDLRkkGk lKYc4Y1QDZJBX6MuY4/AlL7lmD4EHFQMJBgxFHVQOGb9iBvbmR0zocr4xJpYRUfqpFBF 1jPXmgnsCkKIgzUMEjkmXoRFYr5e6BmWv0ZiOk/rNmpDxImZvFx2aE/44jzjL6yARcOu eRfs2W+mWxXBPIL/fpOKHK0Fy7N8p+kj3EpEdbtYF7F5EuCtPGwmntk7ugYWd3vgb2zU pjOzGtd9Mxl9jknw0apV8WT5jPCOtarPJ88331q44ss0unSmYS9q7EYy+EyI0OYsrR3z +kBg== X-Forwarded-Encrypted: i=1; AJvYcCUNTc0DDKu1xrHsx4McC8DxQZxO1u+J3ftfP/2d4Nnp2HS8r736G92uIVnvPFQ3SXMhpaEHu4QFLA==@kvack.org X-Gm-Message-State: AOJu0YzHIF+Ax02/cR7E2MZgsk1vImbHgIKb8RF5aY/N/0h49Lhg+Dvb RG9ZRi2x9HcWAep+5cXvRRTUPqSjKCdYMy8hvDqJG8mJzIrd7djdjB98ZJuGzgayA/IQFNYQvqp 7Iy3AYQ2cwW8Bd8UB4O20U7c4JEb2qDIMl8DYsbXCPnkU2v8xtaRh X-Gm-Gg: ASbGncvyqLtVc6w2Z0NUR/DGtK8o70l0Wmssdf9kDzMYzSbGllJQgNpLVBSHFlcOk2+ h9DevLSfbQSTqLBaQ8Rma2By9c0yMEDv9sJ8Sc9+wIrabymaihknTBs0PyR9pcCIHIE0dnOUNYg ynf/16MecmX12FUsDf5QWeWNHpoVTTwwl6pFo3clBof3jd9surjOGMRcuFL+Rb87mTS0Xy1to6l UwXLqd6T4fV6L7pvskqIqdocz8QEUOuuyIZdacSN4G+rPsMvkWDZmbohvUIr1tn9edfeN0PoxU/ YGUHRFVLGmlF1TuAc7uxYfE0TlN0/mZBN22izc+qYPYJ6Emf6POmMhXnK0schtVsIOihN3sXfqE NOVxbODey5XIorXWOXOLpFY86Zd0SY813INIbPi0= X-Received: by 2002:a05:6000:3112:b0:3a4:bac3:2792 with SMTP id ffacd0b85a97d-3a4f7a3dc11mr1778332f8f.4.1748595027202; Fri, 30 May 2025 01:50:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHn1gr3Osd9HyyalCFGtczxVvHmWzyW6PptnSQ10SjPGM6h42L5/AfeMh2GjoihBYKi6RlQw== X-Received: by 2002:a05:6000:3112:b0:3a4:bac3:2792 with SMTP id ffacd0b85a97d-3a4f7a3dc11mr1778304f8f.4.1748595026810; Fri, 30 May 2025 01:50:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fc2725sm11823505e9.37.2025.05.30.01.50.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 01:50:26 -0700 (PDT) Message-ID: <172df994-7f24-4fbb-876c-4fab22937177@redhat.com> Date: Fri, 30 May 2025 10:50:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap To: Lorenzo Stoakes Cc: Pu Lehui , Oleg Nesterov , mhiramat@kernel.org, peterz@infradead.org, Liam.Howlett@oracle.com, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <62b5ccf5-f1cd-43c2-b0bc-f542f40c5bdf@redhat.com> <13c5fe73-9e11-4465-b401-fc96a22dc5d1@redhat.com> <4cbc1e43-ea46-44de-9e2b-1c62dcd2b6d5@huaweicloud.com> <20250526154850.GA4156@redhat.com> <06bd94c0-fefe-4bdc-8483-2d9b6703c3d6@redhat.com> <57533126-eb30-4b56-bc4d-2f27514ae5ad@huaweicloud.com> <956124be-c73c-4023-9edd-25372f3f865a@huaweicloud.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6WB-jgNRVnwYLTO5dErs5Xvj7klcIOQ7m1SYcYIW8kQ_1748595027 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 67CAB180002 X-Stat-Signature: p3c3g8mynkfzddhdwqrtks7p8zfthtfo X-Rspam-User: X-HE-Tag: 1748595030-278205 X-HE-Meta: U2FsdGVkX1+YaMDoRd7Nuv1qzNVbtMzAuI6nGUz54l4mbAT0goNYpepvrJMXE6BuZIAU9uZiqbzW59TLpmFqTqTePZdW4vdRoErgUiD2zoKhkl5xNyoERHlh+zK4r1xy4++dpaPN0lMZw4l2sb3riWctV7mrQiH5TqHxqdJnvkpiiDQqr48hF5dEB2a4dj0yUeGIY+qsy0K5xrvePpDMB5Z3+3/gvilkIkRHBG5GXrIR362086J+NM3tHJfxKFeOVmmpEjIohRCt/HWhanMSAiMVj9m8maitsP4b7Y5ws2v3BU9KnR8Oe1fgA+LPD0MIeKWBsgLGzwR3Hum7vEdqEA5eDj85hSOd6wYjo9WksNcXYNx878jFr2aExWFISfL8JMuHo5eejY686wgtPD2bXszI5Po4P0j874u1YP6AnPNJljIpl2Az/4LFcX+7N/gNM9jvqJeXcExi3ggH5Sx0GGhAl+MhteRrHqaoyjCVWpgOVk9pIZwAXj60KKzCUwDHC/BcVV6a1Ohbt4v9FoaztpB7HqYzo5seGbFoSQ4iiuTMVITrol8CcVFwqKesEddW1zjam7Gvp4CfOvbwPnGMQ3W9dJS9pA+Vr/QGyL6GlcTvDpaSUIJxnCYdXpnvTlgBUs7iLyS2GSpEVQV/+bU0HkEH3HV3LRLpDK4j9NHLke5bsGepedwOQ1eTNFcU+9rOiIBIgRhyd4MHW36NMYCxcKP/u7yr2HJPhd2YriD2BSYJxFLayij4D0pLWVzFWvex+9NqpiOokOeDe2QEiXontdO8mDTHO8aKlCIB8nGI34OJFMzj5jbyJIzG7A38RDI3hW+bV6CyjvMkEzBiakisRHc41Fhl3IDrf/kZB/yH3uSEeVI7L9Pifly3dtH1rSiAKO3mOyi/UDqlbHUQd/oxsyADPkCkgjwsR+yLmwbLvr1Ubo5eeKORkX+qbzgdcccg5Az9a7ERZG4spnMaRGy DBiL8ASS vT6Lrh9o+HFAE+vnCfspoPnMYg3Ds6meLlzrOlBpthOKnTrdoJ2UREMsmIDZvqIfSmCYc59KSr4nnOEzwFlQz8W0nvJL00ZanZwJu4pq4jdv6T3VfwGTsYmv9nAIOP+YVtXqNW9q6f9QTupnJb1oqpVsO9A0y+JbI+PtuwWmRjt9Zt6BnfmZXmIdyK/7kfcZoWNayxTwLLDYZzUu9WpyuyXaLDHZCrBT4TieimdBigvr6U7u5q84Vvq/eAe28zuoANyXUaoVPwwLVjPpbCZLuupAXWQx8Zz6oN4l3t0kTXus1B+KsDHnTF/U0jMwLlUnv4ZE6c4Lf73YIbFcEvMVb1YlHDigv5H/xdYXUSw2C1ijHju/KUGmDlB+hBSaiAOtAlao9aw5X9Rj0A21FH02y7fquS/l3bS4AJzVYUYPTyb/aBJQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.25 10:41, Lorenzo Stoakes wrote: > On Fri, May 30, 2025 at 10:33:16AM +0200, David Hildenbrand wrote: >> On 29.05.25 18:07, Pu Lehui wrote: >>> >>> On 2025/5/28 17:03, David Hildenbrand wrote: >>>> On 27.05.25 15:38, Pu Lehui wrote: >>>>> Hi David, >>>>> >>>>> On 2025/5/27 2:46, David Hildenbrand wrote: >>>>>> On 26.05.25 17:48, Oleg Nesterov wrote: >>>>>>> Hi Lehui, >>>>>>> >>>>>>> As I said, I don't understand mm/, so can't comment, but... >>>>>>> >>>>>>> On 05/26, Pu Lehui wrote: >>>>>>>> >>>>>>>> To make things simpler, perhaps we could try post-processing, that is: >>>>>>>> >>>>>>>> diff --git a/mm/mremap.c b/mm/mremap.c >>>>>>>> index 83e359754961..46a757fd26dc 100644 >>>>>>>> --- a/mm/mremap.c >>>>>>>> +++ b/mm/mremap.c >>>>>>>> @@ -240,6 +240,11 @@ static int move_ptes(struct >>>>>>>> pagetable_move_control >>>>>>>> *pmc, >>>>>>>>                   if (pte_none(ptep_get(old_pte))) >>>>>>>>                           continue; >>>>>>>> >>>>>>>> +               /* skip move pte when expanded range has uprobe */ >>>>>>>> +               if (unlikely(pte_present(*new_pte) && >>>>>>>> +                            vma_has_uprobes(pmc->new, new_addr, >>>>>>>> new_addr + >>>>>>>> PAGE_SIZE))) >>>>>>>> +                       continue; >>>>>>>> + >>>>>>> >>>>>>> I was thinking about >>>>>>> >>>>>>>      WARN_ON(!pte_none(*new_pte)) >>>>>>> >>>>>>> at the start of the main loop. >>>>>>> >>>>>>> Obviously not to fix the problem, but rather to make it more explicit. >>>>>> >>>>>> Yeah, WARN_ON_ONCE(). >>>>>> >>>>>> We really should fix the code to not install uprobes into the area we >>>>>> are moving. >>>>> Alright, so let's try this direction. >>>>> >>>>>> >>>>>> Likely, the correct fix will be to pass the range as well to >>>>>> uprobe_mmap(), and passing that range to build_probe_list(). >>>>> >>>>> It will be great. But IIUC, the range we expand to is already included >>>>> when entering uprobe_mmap and also build_probe_list. >>>> >>>> Right, you'd have to communicate that information through all layers >>>> (expanded range). >>>> >>>> As an alternative, maybe we can really call handle_vma_uprobe() after >>>> moving the pages. >>> >>> Hi David, >>> >>> Not sure if this is possible, but I think it would be appropriate to not >>> handle this uprobe_mmap at the source, and maybe we should make it clear >>> that new_pte must be NULL when move_ptes, otherwise it should be an >>> exception? >> >> Yeah, we should ay least document that if we find any non-none pte in the >> range we are moving to, we have a big problem. >> >> I think the main issue is that vma_complete() calls uprobe_mmap() before >> moving the page tables over. > > Well vma_complete() is not _normally_ invoked before moving page tables, > it's mremap that's making things strange :) > > That's why I think my suggested approach of specifically indicating that we > want different behaviour for mremap is a reasonable one here, as it special > cases things for this case. > > However... > >> >> If we could defer the uprobe_mmap() call, we might be good. >> >> The entry point is copy_vma_and_data(), where we call copy_vma() before >> move_page_tables(). >> >> copy_vma() should trigger the uprobe_mmap() through vma_merge_new_range(). >> >> I wonder if there might be a clean way to move the uprobe_mmap() out of >> vma_complete(). (or at least specify to skip it because it will be done >> manually). > > ...I would also love to see some means of not having to invoke > uprobe_mmap() in the VMA code, but I mean _at all_. > > But that leads into my desire to not do: > > if (blah blah) > some_specific_hardcoded_case(); > > I wish we had a better means of hooking stuff like this. > > However I don't think currently we can reasonably do so, as in all other > merge cases we _do_ want to invoke it. "all other" -- not so sure. Why would we invoke uprobe when merging VMAs after mprotect, mremap, madvise, ordinary mremap where we are not mapping anything new but just ... merging VMAs? Really, we need to invoke uprobe only when adding new VMAs or extending existing VMAs -- mapping new file ranges some way. Or am I missing something important? -- Cheers, David / dhildenb