linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>, linux-mm@kvack.org
Cc: Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/slab: fix kernel-doc func param names
Date: Sat, 11 Jan 2025 12:24:23 -0800	[thread overview]
Message-ID: <172cd677-f212-4eff-941d-627e9596918c@infradead.org> (raw)
In-Reply-To: <839258c6-58e3-48e9-9791-0f4ab3ec2fb3@suse.cz>

Hi,

On 1/11/25 12:12 PM, Vlastimil Babka wrote:
> On 1/11/25 07:32, Randy Dunlap wrote:
>> Use corrected function parameter names to eliminate kernel-doc
>> warnings:
>>
>> slab.h:142: warning: Function parameter or struct member 's' not described in 'slab_folio'
>> slab.h:142: warning: Excess function parameter 'slab' description in 'slab_folio'
>> slab.h:168: warning: Function parameter or struct member 's' not described in 'slab_page'
>> slab.h:168: warning: Excess function parameter 'slab' description in 'slab_page'
> 
> I'm unable to get those warnings with "make htmldocs", what exactly do I
> need to run?
> 
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Christoph Lameter <cl@linux.com>
>> Cc: Pekka Enberg <penberg@kernel.org>
>> Cc: David Rientjes <rientjes@google.com>
>> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Vlastimil Babka <vbabka@suse.cz>
> 
> Anyway the problem and fix seem obvious, so applied. Thanks!

Oops. I should have said something like with 'make W=1' or if
just running scripts/kernel-doc, use -Wall.

Sorry.
-- 
~Randy



  reply	other threads:[~2025-01-11 20:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-11  6:32 Randy Dunlap
2025-01-11 20:12 ` Vlastimil Babka
2025-01-11 20:24   ` Randy Dunlap [this message]
2025-01-13  9:21     ` Vlastimil Babka
2025-01-12  6:10 ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172cd677-f212-4eff-941d-627e9596918c@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox