From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE4CBD3C528 for ; Fri, 18 Oct 2024 06:06:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58D116B0088; Fri, 18 Oct 2024 02:06:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53CEF6B008A; Fri, 18 Oct 2024 02:06:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 404D16B008C; Fri, 18 Oct 2024 02:06:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1EB866B0088 for ; Fri, 18 Oct 2024 02:06:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5D78C1617F0 for ; Fri, 18 Oct 2024 06:06:32 +0000 (UTC) X-FDA: 82685689044.02.2422486 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf19.hostedemail.com (Postfix) with ESMTP id 7C67F1A0003 for ; Fri, 18 Oct 2024 06:06:30 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UHltVWQF; spf=pass (imf19.hostedemail.com: domain of mengensun88@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=mengensun88@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729231529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=YB1LmCQcNZuiTRixfyMNEp3sh0blica8ab4H/fIaBHI=; b=DFn5n0y6b4jdP0plUw8s2GTNHEVjTpHaxQmt1iBgS3OcDSzCyARXsCIxMvvqyV02BGP2qu qXIGKpXADo1npJiwKBS31WW+g6dL2w9twI2DAZ0j/6PWm1tODK6wvvwiueZClBJoNS8fNt 3t8QsoPIWR0NyJ7Aq4Mo5HOz+tiWS0A= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UHltVWQF; spf=pass (imf19.hostedemail.com: domain of mengensun88@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=mengensun88@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729231529; a=rsa-sha256; cv=none; b=3q25aGYdC8KGtNfNclLsK60oZYfmY95ohFbLx7cH1HS9t6c8fTo0K5vLTJVncvO1utmqni QmMyLEXpLaz+YKnQGUdVR9XwNRz+FWglycCTClKNDm0GIx1Ivw0w+Kz0ieoFj/qREpYxuG aWUlV+qqFC9+Dn14k2JfYyW0FmO71DA= Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2e30fb8cb07so1333653a91.3 for ; Thu, 17 Oct 2024 23:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729231602; x=1729836402; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=YB1LmCQcNZuiTRixfyMNEp3sh0blica8ab4H/fIaBHI=; b=UHltVWQFuSKXOZL75frm4uDOy6DqNLQXIbGeRn4WZIaOnyZ6jT2q4YRIeca7JqlQD4 nMdqM1zM+GwckpAfo+xt8gKBNLlT6aZKJxIBsAe3G2xqBgPv+r+ThGUPfdQ3nhynzpCC qt/XCfPeGyUC+gHcM4WDzukdQmrViGm7IrSZ04KK6T5cB41deD5YSc5ptoVXza85c4gJ n0PceUWlJ7Y5T1BMEYWko+EwYEUOmIabLc2uLcr971cRV63F5ZhuS9wcD8d1RlHIvN11 mdVN9CC+Dkh4KggBoCYBJ3rqq3GdEn6HaW/PpJNza+wNl5fsuIVMjR4ehtTFnf+BPuvp /obQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729231602; x=1729836402; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YB1LmCQcNZuiTRixfyMNEp3sh0blica8ab4H/fIaBHI=; b=U8S/UlguHmip+UxKSTQ9t9JZBgI3xQxPoM4XhpZXPIBEajAmKtEFc15NKzzre3/AG+ u0CA21IWhQTdezemoS4Qztp/tm11Fwlx4rlVzVgUEDY+TUq3Xvk7iD91vSot35kokE1y 6mY/laOw+UboogdxiuV6ONF6533XKTlKa3IjuZ3/JcMe9xjUv84TLFIEVVAJDsZriyVd jza7ucUePqBkPbGu7Fk93PsSqa2ww4hcBiIBTn3MNHpfkTmrNYn303CLj83UIlKFjXr0 7XYIyblO7Ss2PoC/8WmOZ2oQbe0erz0lQawhxt023/z9kd2pvVk9ruZ6FOd10X22ickW v9Cg== X-Forwarded-Encrypted: i=1; AJvYcCXBZICZy05Hg7+YqKS4JXc8itnROPKWXVf8VNbSzO10JjGwbTc+/srm9nsyXM3SCkMvN69mdGVFnw==@kvack.org X-Gm-Message-State: AOJu0YwzM/uv58dZ/onmi39JNVmFE+DfMo+HBeLmXH+VGERYUQcJ1OaF e6k72nomIAUyLqawrcMmKSazMz2rza4ijkDaNjk8E9IlJSSKA+Pg X-Google-Smtp-Source: AGHT+IGMhqMVHHNFIWWyo62KZN/pX0PwPN6mmwV4upUByvOhTYxgCIAztvDcyMFtjUztU47SoKJDgg== X-Received: by 2002:a17:90b:2782:b0:2e2:af0b:7169 with SMTP id 98e67ed59e1d1-2e56171a95amr1598611a91.12.1729231602464; Thu, 17 Oct 2024 23:06:42 -0700 (PDT) Received: from localhost.localdomain ([43.153.70.29]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e55d7c4b55sm1027899a91.21.2024.10.17.23.06.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Oct 2024 23:06:42 -0700 (PDT) From: MengEn Sun X-Google-Original-From: MengEn Sun To: akpm@linux-foundation.org Cc: alexjlzheng@gmail.com, alexjlzheng@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mengensun@tencent.com Subject: [PATCH] mm: make pcp decay work with onhz Date: Fri, 18 Oct 2024 14:06:40 +0800 Message-Id: <1729231600-19607-1-git-send-email-mengensun@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <20241012154328.015f57635566485ad60712f3@linux-foundation.org> References: <20241012154328.015f57635566485ad60712f3@linux-foundation.org> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 7C67F1A0003 X-Stat-Signature: 6pz9eter85abfyo6haexebmnbgqh7kjq X-HE-Tag: 1729231590-536873 X-HE-Meta: U2FsdGVkX18Qzi1gbpEDIjsZaySpEXn2TjCBZER5uKnhF5Pxv9Eu4Gg4cLwkRWU7YH4E0sRW9MjiWGaXvdEAJ66ZkocmRhOwXXngwmeqKAS6t1flipy6gkJyXRGBqoShaMUbYeaO+iOu+ZadJYPxocX29gqbkVd9R1/IG/ba4ZsPLWmqJ58KYmUUsyjFj7bzmbWXUeVg/HBW99weeLLva35qOtMif+4OyAGt6C0X7AYMS/WSSMScbe6uFb+3/hlDRsV6utLy4i6zm2UG1/2W8n2i/GHuZcJFHggpBMRFeijfGxzm17DrvQUZPHw+7atp+uHax654JUjLamjnxVB2Q3M/u0zlGLZb5NuVotnoxjZ/LZdn9JuDn2HjEiw+XbdZnR6MwpOJA+S3axgX5BoMGPWXn/JajaC42PA/b7xyGPu+vpIAUkrJwHDzoWxmRzTajTAlz5j5VC0lV6t0Y9DibfmB0BgjhfOPe/zMgbMoCygJcSnRgtpHMcjfwyluAhfsTUWtV2A7lyReSLr6htmK6zqoxyVcC6Aoi3QdaotTVEq2BzTdM8mrqcZT4eamUMTQ5yQEHiCcdb4qfdxbNtNzvL4OpUMqtCeuk1fKyvz7iM/ivKm1bDrf8US6+tWl6OB5YKLAqDPt7Da5cr/26RGzPUysmzYYf7kYN1yZrAalphx3b9QPJ2lZ5+kMv2XlC7gecMyPvBFYT9epGKJ2kav4HZyxZlKsjIvicfK5otX67n5/v51RZIiigeNTbhcB6WfFkN4c8ynQrMIp57p5gF/ai6FdnSdDdZFuwSwIWM+js2GvK8/OvYQi9jO6Lz3rfugu4JDyjIg0DsALQo9RQO9SHqeqwhY/W/Pe4BfdcOmH2eD0XL9E6Sjnc9a3QYEmt9WyhgU6MpbQkvsB6ds1BV5TGBYF2fNQTvO+aff1htDn6GYkyo6oyP62LWJTg4rhYFrKfNQrqr5U9bhSFAkoB9e sVJsTNzF bQNIXzrj1JeWVw6WbQBCgUr/TY1lZ1su+zWV8GT7KTJ8nh+MswZkTfwNO+/5IasLK+Ruq1pgCJFgxxb4HacLdiQpFu6U+jT/U5iLki4S+OyQwXOL43wiKyLdFSdEjzs9lJO/KMrvxLv8vri1YMmQFlYYiufxeaI07kSGF9yIGLMk7NkKKfLJHkPNLHup4cPnm92L+dDZ9fRORylNNJtVf/T65Zw0He9Xc/9O/cKSPX7OIBgb1waRWDdKEZ/QOa+gV8SICn/rK94eO2OWAoKOvY3fKlzFK7o5C4xWtMz4VHqGXbDv7dUPSgz0RczWEPPfUDY5P7T4T895PGq2+YXayUsMma6QJNZNDDxMfMErXic6TZbLnH1Zf7unHlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.196362, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 12 Oct 2024 15:43:28 -0700 akpm@linux-foundation.org wrote: > On Fri, 11 Oct 2024 18:36:10 +0800 alexjlzheng@gmail.com wrote: > > > Subject: [PATCH] mm: make pcp decay work with onhz > > "NOHZ". > > > Date: Fri, 11 Oct 2024 18:36:10 +0800 > > X-Mailer: git-send-email 2.39.3 > > > > From: MengEn Sun > > > > when a cpu stops tick, quiet_vmstat may flush all the per cpu > > statistics counter. > > > > while, the shepherd is needed those counters to kick the > > vmstat_work. > > > > when a cpu in nohz with a lot of pcp pages, and do not do page > > allocating and freeing. the pcp pages of the cpu may not be hold > > for a long time > > > > we make shepherd keep a eye on the pcp high_min and high_max > > I can see what you're saying here, but it's hard to understand. Please > spend a little time clarifying the text? And please start sentences > with a capital letter! Thank you for your suggestion I will create a v2 version, and make text clarifyed > > > --- a/mm/vmstat.c > > +++ b/mm/vmstat.c > > @@ -2024,8 +2024,13 @@ static bool need_update(int cpu) > > > > for_each_populated_zone(zone) { > > struct per_cpu_zonestat *pzstats = per_cpu_ptr(zone->per_cpu_zonestats, cpu); > > + struct per_cpu_pages *pcp = per_cpu_ptr(zone->per_cpu_pageset, cpu); > > struct per_cpu_nodestat *n; > > > > + /* in onhz or nohz full make pcp decay work */ > > "NOHZ". > > > + if (pcp->high_max > pcp->high_min) > > + return true; > > + > > /* > > * The fast way of checking if there are any vmstat diffs. > > */ > > --