From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE2CBD2444F for ; Thu, 10 Oct 2024 21:43:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35E766B0085; Thu, 10 Oct 2024 17:43:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30E616B0088; Thu, 10 Oct 2024 17:43:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1885A6B0089; Thu, 10 Oct 2024 17:43:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0128B6B0085 for ; Thu, 10 Oct 2024 17:43:40 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BF7FE160C53 for ; Thu, 10 Oct 2024 21:43:36 +0000 (UTC) X-FDA: 82659019758.22.3B56742 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf09.hostedemail.com (Postfix) with ESMTP id CB61314001B for ; Thu, 10 Oct 2024 21:43:36 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a5JJZfoF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RVWaGtvm; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a5JJZfoF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RVWaGtvm; spf=pass (imf09.hostedemail.com: domain of neilb@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=neilb@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728596548; a=rsa-sha256; cv=none; b=a9yqqpjpcqGTs9V6PO7M9fJk/oQKOpj9HRdJvVXHb17VK/BS66/S9XtuS4nwjykCA/S7wp aLDsaoiFZUDTDL3g6vOrv8GkqrlCg0mg2gUQzBhhmncKHFFm/6RrOTr60FbmMNxgb5zs1V E0vbigGcPOZJ/RZgpoNgQjpmnogDpvM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a5JJZfoF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RVWaGtvm; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a5JJZfoF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RVWaGtvm; spf=pass (imf09.hostedemail.com: domain of neilb@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=neilb@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728596548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2BLVaQNxwgGS4hs6TdXQIhC+xDJeoNKY0cDCGry5g1U=; b=124DNMQgAHCuwMo9yU5Ik8IBPcpEuT1363R5d+JQWU+Mdce0npfKlbEZzqNEJ9fJKSbbV5 t7k1l5id0N+Agxedf0afsvyFDZnZnc61kuTDMMQt5rfTh74cisreNSbSFvIq463TLzervf wTDlFG4LaePGDJgQ8BgTfgWwLX15TcQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9B3CB1FE32; Thu, 10 Oct 2024 21:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1728596616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2BLVaQNxwgGS4hs6TdXQIhC+xDJeoNKY0cDCGry5g1U=; b=a5JJZfoFKe+RffAGjiKiKDWGT8xkOirsMEpsysJkAqadTXwun3xEaq+O1DDhmCym/ShUAr bh6o8s+5amzjhUKHJnUM3MjSWDU96GIHeZ5JirpVokB7w49CHI6ce9E5XSIGInUQDMXvIs bKwfMlBCqKX+9eQIEw5/w9q3lx/DeMs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1728596616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2BLVaQNxwgGS4hs6TdXQIhC+xDJeoNKY0cDCGry5g1U=; b=RVWaGtvmGJPTmtqJbLqdObnWbVcu3Y0VGtbW3Wku/80a//iKt2toqNptyvNguHWiO4MuUt WI7rq9k5AOyVqwDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1728596616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2BLVaQNxwgGS4hs6TdXQIhC+xDJeoNKY0cDCGry5g1U=; b=a5JJZfoFKe+RffAGjiKiKDWGT8xkOirsMEpsysJkAqadTXwun3xEaq+O1DDhmCym/ShUAr bh6o8s+5amzjhUKHJnUM3MjSWDU96GIHeZ5JirpVokB7w49CHI6ce9E5XSIGInUQDMXvIs bKwfMlBCqKX+9eQIEw5/w9q3lx/DeMs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1728596616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2BLVaQNxwgGS4hs6TdXQIhC+xDJeoNKY0cDCGry5g1U=; b=RVWaGtvmGJPTmtqJbLqdObnWbVcu3Y0VGtbW3Wku/80a//iKt2toqNptyvNguHWiO4MuUt WI7rq9k5AOyVqwDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CE73113A6E; Thu, 10 Oct 2024 21:43:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IPoSIXZKCGeEZwAAD6G6ig (envelope-from ); Thu, 10 Oct 2024 21:43:18 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 From: "NeilBrown" To: "Jeff Layton" Cc: "Kaixiong Yu" , akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH v3 -next 11/15] sunrpc: use vfs_pressure_ratio() helper In-reply-to: <12ec5b63b17b360f2e249a4de0ac7b86e09851a3.camel@kernel.org> References: <>, <12ec5b63b17b360f2e249a4de0ac7b86e09851a3.camel@kernel.org> Date: Fri, 11 Oct 2024 08:43:15 +1100 Message-id: <172859659591.444407.1507982523726708908@noble.neil.brown.name> X-Stat-Signature: c3rs6wu8c5qgs94rgyyfs6wcyhy3zjh8 X-Rspamd-Queue-Id: CB61314001B X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728596616-495631 X-HE-Meta: U2FsdGVkX18R2myJM7LwGczPcK6k7exm9ho+C6AwxQq1TltBHHdRwsfePo6L6HPNBg5yyh+h5iXFFeVVNkBQThbwaMdZpC3mCi7tQDSXqVoX7sBqueIPE5/023z6e2qnsvGo0F63CcNuI0oXougvk+Tus2DyhPLCPfc0vLT5+EZPiWPNG7spmd/TJrxXXgAfEieRVf6svf25LaJvCz5ZPnDqfpNAAgGTSBtzoSKPFCm5c922UxqtIKAZvJH7fP9HMbKJetjXaHRGlmQ5nI7grKc9AroCGmlk8fg1E8eqjhSiyZn5jOjod8uKAIcuFlMKsqHNIFQjeapSA2IZxcpHEoJaY80H/+Nq2n5rMV2dx7CBXGC10M94nHbfjbMkoyFLyXvJuFnMYqqhA7qlwUJRMSWm5ldE9jvrXzFEc7epKg1PK7MnIowuodRX7jc6im6pi25wcrKNC1eKgX3dlNwb//NYaVc42Yh2gYae0tRMDNuirK+1poz+WX+I7AXVB62YXFOmNvpn7FEhk1NZ7fA3ZXxVGkhGRkes4dJWDbC7beRJCcVMN9CNiaKnRS+/IvIgcY6wkkebosjj/sK7YsaDhEVOKVq58Bdnefx6jU2KPVrGy9vGIxbl00TVkrwUhaSgdZyxCqBREIZI/m6UIhKScuVa9/cAvhTFTumFBqPP9mjmgTRbeWYGL5S9peCzOiLqkUKxVmT/XByPl32n3uS2ATZ/WpuAtwamTAfRQJmTZIcArwEhoCSPZ0YtLgxnNLMAoV3bDgR8HAi3FA8zskiNZaBihJfmSWJB8oWExafiLRyymn+LgWsp2IKzEfht23/RAI09e82uwEYzossdtWjHsvC7lmgLkki0bkIpnIo7FaoO8dwUgwiNwxaatpI6COW1/BtWBDGd21m/RthCAok926bexONnA0qql26Fgw1LYzuYR9+QAAhuvYsZSHG1yMdPK4GcZ6nSZ6oJwF9zssN rcCa5bW0 7jR6Zk4pG1zgMPK1hTBRrvilyKy4nTnFArpzZDj8rTUuTdK7uA3BhL+0CK5nRDu0hCvg+RAkA+hH7KRLxMHUJ+cQ+p1P9h0GE5KO6MIkkOuZVC29+GkNiyDVVoMA5VkI3sNTQv0BtUGOkQBm24dB9OhEbdkjtiHoNmtsLmyEE6tdQmVOEXQu3mhMLuNT/nDYcrS38xyYGGio9cY4VoxN4EatQCvgRKoiNcMgB9x9D817S9sKx8vx/BGSgmoQDs6UIS9qmJCnON+QgWpcrtBJOIRxiivNz48j1chZQm2GpCX34KKgRaCAmjitLTGLO3MKi4woNO6z4tlgwGivIYrEGOUPPmsl6z1MDMNmBN9sc/Em3ujBBqPEqqg1uEppOJYlMMhxPGz0ZMX/KDqlXkABZf6SIDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 11 Oct 2024, Jeff Layton wrote: > On Thu, 2024-10-10 at 23:22 +0800, Kaixiong Yu wrote: > > Use vfs_pressure_ratio() to simplify code. > >=20 > > Signed-off-by: Kaixiong Yu > > Reviewed-by: Kees Cook > > Acked-by: Anna Schumaker > > --- > > net/sunrpc/auth.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c > > index 04534ea537c8..3d2b51d7e934 100644 > > --- a/net/sunrpc/auth.c > > +++ b/net/sunrpc/auth.c > > @@ -489,7 +489,7 @@ static unsigned long > > rpcauth_cache_shrink_count(struct shrinker *shrink, struct shrink_contro= l *sc) > > =20 > > { > > - return number_cred_unused * sysctl_vfs_cache_pressure / 100; > > + return vfs_pressure_ratio(number_cred_unused); > > } > > =20 > > static void >=20 > Acked-by: Jeff Layton >=20 I realise this is a bit of a tangent, and I'm not objecting to this patch, but I wonder what the justification is for using vfs_cache_pressure here. The sysctl is documented as This percentage value controls the tendency of the kernel to reclaim the memory which is used for caching of directory and inode objects. So it can sensibly be used for dentries and inode, and for anything directly related like the nfs access cache (which is attached to inodes) and the nfs xattr cache. But the sunrpc cred cache scales with the number of active users, not the number of inodes/dentries. So I think this should simply "return number_cred_unused;". What do others think? NeilBrown