From: Will Deacon <will@kernel.org>
To: akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
linux-mm@kvack.org, Barry Song <baohua@kernel.org>
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>,
david@redhat.com, ardb@kernel.org, jhubbard@nvidia.com,
mark.rutland@arm.com, Ryan Roberts <ryan.roberts@arm.com>
Subject: Re: [PATCH v2] mm: arm64: document why pte is not advanced in contpte_ptep_set_access_flags()
Date: Fri, 6 Sep 2024 13:29:26 +0100 [thread overview]
Message-ID: <172562211364.1176080.6213351630477902092.b4-ty@kernel.org> (raw)
In-Reply-To: <20240905081124.9576-1-21cnbao@gmail.com>
On Thu, 05 Sep 2024 20:11:24 +1200, Barry Song wrote:
> According to David and Ryan, there isn't a bug here, even though we
> don't advance the PTE entry, because __ptep_set_access_flags() only
> uses the access flags from the entry.
>
> However, we always check pte_same(pte, entry) using the first entry
> in __ptep_set_access_flags(). This means that the checks from 1 to
> nr - 1 are not comparing the same PTE indexes (thus, they always
> return false), which can be a bit confusing. To clarify the code, let's
> add some comments.
>
> [...]
Applied to arm64 (for-next/mm), thanks!
[1/1] mm: arm64: document why pte is not advanced in contpte_ptep_set_access_flags()
https://git.kernel.org/arm64/c/70565f2be880
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2024-09-06 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 8:11 Barry Song
2024-09-05 8:15 ` David Hildenbrand
2024-09-06 12:29 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172562211364.1176080.6213351630477902092.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=baohua@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox