From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB162CD5BDF for ; Thu, 5 Sep 2024 16:51:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F414F6B0088; Thu, 5 Sep 2024 12:51:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF0CA6B0089; Thu, 5 Sep 2024 12:51:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB8B26B008A; Thu, 5 Sep 2024 12:51:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BBFCC6B0088 for ; Thu, 5 Sep 2024 12:51:52 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2ECB8120891 for ; Thu, 5 Sep 2024 16:51:52 +0000 (UTC) X-FDA: 82531276464.15.4DFBF7C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id 70A63A001A for ; Thu, 5 Sep 2024 16:51:50 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S+dn4IzX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725555031; a=rsa-sha256; cv=none; b=QqFwSU5RhVYrU7DwpR+g/JFWW/cSEZ1bNHBE5YsGU1NyRAFd/KaQawx/vfiJdyQD1inPzB J+Ivli9wuO8RG/sai4OAaILjc3/PoSptisxrWot3WWxBQYycchW9BkKuoxp7hs+LxiyBCV E5w6wCEbpJK2X6IlmPjlwqpLL1MN51U= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S+dn4IzX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725555031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hSY46JlD2SpHhviv0UYs4F0tPjYxRCI8IKi0c+/Fo8g=; b=F2mjOBW9Y+pEjTFf50GRxD386LgBMobKKN2zZrOIv4O1Uk2O0MmSSaEh/jJbFRq494zbyz qNlXxYd+iMjxs1G5+YwqPCI2wakukh53/cIh/nzEy1b2WA6ioALNPeXZQnd3iRuXb0meYd N9mRYqP3YEwcdbUD8PJjEn8RPYXJzus= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 57F51A44E0C; Thu, 5 Sep 2024 16:51:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 309EEC4CEC6; Thu, 5 Sep 2024 16:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725555109; bh=0y0h16uEOrJ8vHCIrO+tdDreN+rQGphbGRKdlzR0ON8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S+dn4IzXJsgfMnrm+5s77GeQYbKNPeZIvVrIKJyW/SaPQ0NO+XGqNA4mTmCDEAoiC +Xp4nDtBLhMUXxScjGm4nUic9F7m4aMHr2Az/ZlULNUSbb6u4yD85PLi4v5R0XeBpa vXv4ge6MaNSFhg4TVTu4FW5n7iifrtJ1G1/gzzgGTd7JHL7zXS0/mVzIE5OaXtKrSR Slj1J+wEX/u4FTC1gyfJBPoFm8Kz9FnSVA97gHPcLqc+aN1qODMDAhPi8fk1ZLqxSp VFcizZuecLvb14fVgp8AICv7nIDCGoe2aAuQLXdHTcZfS/CehOwVMWykxrY+XxtDa3 nB2Pdx/E1wGQA== From: Kees Cook To: Hongbo Li , Andrew Morton Cc: Kees Cook , andy@kernel.org, trondmy@kernel.org, anna@kernel.org, gregkh@linuxfoundation.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: (subset) [PATCH -next v3 1/3] lib/string_choices: Add str_true_false()/str_false_true() helper Date: Thu, 5 Sep 2024 09:51:14 -0700 Message-Id: <172555507039.1959022.16303899697737520578.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240828132509.4447ff09665fa0d7b8020294@linux-foundation.org> References: <20240827024517.914100-1-lihongbo22@huawei.com> <20240827024517.914100-2-lihongbo22@huawei.com> <20240827164218.c45407bf2f2ef828975c1eff@linux-foundation.org> <8d19aece-3a33-4667-8bcf-635a3a861d1d@huawei.com> <20240827202204.b76c0510bf44cdfb6d3a74bd@linux-foundation.org> <20240828132509.4447ff09665fa0d7b8020294@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 70A63A001A X-Stat-Signature: 4zb69wmtiqc8ctjmns4fm8rgpxezoedo X-Rspam-User: X-HE-Tag: 1725555110-844252 X-HE-Meta: U2FsdGVkX1+qT6NPAPOnUFfBu4Sn1XiiOLTtXZDJP5a6mSvD6ksbwfYw/pGrvYn1XZDqrtKFBkBbT297x2WyaIFr+BtyBbINxx7z/xshjP2119Cbacxcgv1sm2bj87/Bjg0yYLXipTs6OA8IOhLG4ibuhPLgRRpRJ5BlZgqO8O/GG/ppxNi0LnIYQUNAkE232bEeqZ6l4p38rets2wZTpw5im6MMuWNsPt6mcycPleODx3skY80yslGgqDKTyvRlWJQ3h33D1GjeSI2I19QSdzpTsoCyx+l1bcYN+42rVNJuj1eniMmrz60mXiKmyrrlx58EBpmJtubolzenzdn0jf2pYxnUXWf8CRazY4ceJbl9ZaYjly0hFvf5CgalH1v3MRk9HBpON82Fk3KLv6/851vz+anXjix30eqydcGqEylDlHAHYJogvwVd/IlSM2Upn3mQTrns7Ti9NZsfkGMKyS3T82pi03kev8zwO5n4ZyV1F1VnZ8x5gRq+6XmwfLvsyI84cAZWQj7DZH4yhjgs6nQJgRCcrhQ318TO62Os2PHZY+eSSEYvysoGM8pPAvVND7oFWmzBIkpuDy0GgTqOZfwvzT38hzcXXZI908mW8b24rnzeBMH8Kfa3StCQyeNBm6ficSMTq3rJkBaxqb40+5das7XKw4z/rVNBneylX4zexrELKPmJpADkRaDTmzINHpehHLSmviFC9P//E4P2eRIEzZa4edHOn5SctBYh1X607LhoBdBre13T8ty7QAQaYQZ98M67modQaMe27WE/Qt17cFWIACqqMRZ+Qw3m3/62BamYNwYocHpZZME+BlUgNKnTrFKH2wFPfkvYohQdk6injZfPcm8q0pYv5VIM/ndgjvBeusPOkDiViemgRwy06Y5hjLPQm6qfJZMd3rGLuGWOn7PjWinxV/dd5jcA7aXoAAI2GeSjSh3/SDNCqzEuv14MAbC3t5ukGAJqUKp s39r5Tj1 YdYAjWQ+Aw8J7gVXxYp8BR+/mtTnxLi6ny2Hseq6i+qGGqaZ8yI9cN4yuRX4KRcb409L5EeiLfA/qqFtbTd+DshVoOBEWrQ291psC0Nj63jx6LVWFgHHTx0EzJdKcec2CdyEoC2CrdUPmsH9ebBw0sD2hf/1g5EPQIGIxtSoBUNdx0SnEiHD8IYlWNwcV/XqxaVrDsyMHphEmL7EjYguwq5q4OvAtEY3PGx5ZjegFt9fSBN58XG3RrxZ/qCVEmhzGlrY6Pw9PzGRdSaY4UThbJti65cT/puB318IJ0PT2qi/rIvlPn0DRMeYsYA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 Aug 2024 13:25:09 -0700, Andrew Morton wrote: > On Wed, 28 Aug 2024 11:49:51 +0800 Hongbo Li wrote: > > > > Anything which is calling these functions is not performance-sensitive, > > > so optimizing for space is preferred. An out-of-line function which > > > returns a const char * will achieve this? > > I think this helper can achieve this. Because it is tiny enough, the > > compiler will handle this like #define macro (do the replacement) > > without allocating extra functional stack. On the contrary, if it is > > implemented as a non-inline function, it will cause extra functional > > stack when it was called every time. And it also should be implemented > > in a source file (.c file), not in header file(.h file). > > [...] Since I've taken over string maintainership, I've applied this to my tree (where other similar changes are appearing). This should reduce conflicts here... Applied to for-next/hardening, thanks! [1/3] lib/string_choices: Add str_true_false()/str_false_true() helper https://git.kernel.org/kees/c/6ff4cd1160af Take care, -- Kees Cook