From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA795C5321D for ; Mon, 26 Aug 2024 20:12:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09F9F6B007B; Mon, 26 Aug 2024 16:12:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04F4F6B0082; Mon, 26 Aug 2024 16:12:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E59236B0083; Mon, 26 Aug 2024 16:12:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C6ACA6B007B for ; Mon, 26 Aug 2024 16:12:31 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 77821C132B for ; Mon, 26 Aug 2024 20:12:31 +0000 (UTC) X-FDA: 82495494102.10.4795C87 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id D264FA0007 for ; Mon, 26 Aug 2024 20:12:29 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ei6CbuRA; spf=pass (imf25.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724703035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+iZy7ZJ0g0K+K6GgKZsF/KqRl6XWfEwSq67kXABZ3BI=; b=eeMTnHaCrhgK8BlokcsdTsheEWZP+F2dq8/l7+ccZizzcjqkwotNLQTVjqqlA0B8r2bZWN YPU7GEJwKCPtGossjEECMcoRCIjQ0TfEaA3Piqt7FyhWa5QIuG+u07X1O94Q1z8rynb6HP xdtJlvE57nCR6Q9ILD3wcWXoA1fbMpE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ei6CbuRA; spf=pass (imf25.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724703035; a=rsa-sha256; cv=none; b=7gMRMqFFBq7aCFkt7Syt/yaIYzzY9sgLs8l7gD1oohJ/HBFNCsMiPEtnrpeG1j+oJ50Dfr XLzgF+2zsbvqHa7um8bxqQHqvkBxXWKBjqMHQkZ81l4EDhzNYnSkBUSOQclb2AKKeL+Z9R TZDGSK8WdK7qlXUtQjvH19cGIN1NsWo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 182D0A406E4; Mon, 26 Aug 2024 20:12:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C9A0C4FF72; Mon, 26 Aug 2024 20:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724702768; bh=4HdFyJdvZKE0tNyptE2wGNNoK+nN5uPzYDUa2pU7TkU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ei6CbuRAuetpbe48frNv0DGa8REv90njY+nqhLw9yxilYkyp3e26ljbYaR+3K2zeE K0scN4JEpuWiDqj8Gd1HCwWF5EmuSjUnvWPgv5gs/ZjwSf0tScodjn/Ol2B2lZ+5C5 Zo32ZQ0GNsXJSrHkV2I42Utxcr74h7YUaGg8pkMhxqUBdOXyu/Lyr9WPqupBgVi9KM q4ssm3PFUmJpJ6PIMXjvkir5hOPbMmnOKIICyxEYdLtaL9l+biaARTkEuZuB854jkR 774AMH7bUIqMnszhvR4MB1rt/hHCLdKPg20oy48XlqMoylPjWpeMaYnyLyx7qeBmdr 9RPFZHdGDUSuA== From: Kees Cook To: Greg Ungerer , linux-kernel@vger.kernel.org, Max Filippov Cc: Kees Cook , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , stable@vger.kernel.org Subject: Re: [PATCH] binfmt_elf_fdpic: fix AUXV size calculation when ELF_HWCAP2 is defined Date: Mon, 26 Aug 2024 13:06:04 -0700 Message-Id: <172470276219.1124110.5967273192476181059.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240826032745.3423812-1-jcmvbkbc@gmail.com> References: <20240826032745.3423812-1-jcmvbkbc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D264FA0007 X-Stat-Signature: 7aftyfp47aqoudhpcoq3z8pr4x4zpfeb X-Rspam-User: X-HE-Tag: 1724703149-715589 X-HE-Meta: U2FsdGVkX19fY2GizNZ+sZHjj4mSrMM30LPPN0H0Aw1tfkQ4JbEuGkngw3gEAfZcYGamF57/DuvGtOJ4cmFy+Fb8Q/crZNLJ2ty2bBC1BCLxAS9Cw6pNJHZgrELaKkUiva7hN4sOgQpsXNeDOhcDJGC5x5g4X5TV1X6Ifw/5fza482aSYT7rEBY0H8Ilyrh7p8/dOGlODjDno/KmTLIL1Ulx5wvL6lZl7e1d8pEFXBitQT2zS8JNXRz0C1BAxxsHP/tDNOuRurpGyWdWSMh6pyPSdqbSHIZVEgf980P2f6BKEG0CT5q+2ZYsWrGBw+WaxqJGFnm+QjQI1LabZ1St6J0G0MqBwUsP7cSrTF0hhv0wMTQOp5JSEiXlosMsINNqk+yKcZuVxeP9QLrud1xL/zMwifx2e5PSiU8R0N38BshQBLs4ZRmGV/FFz2QiFUPv5/A9wTtht2MHLGUDCXM31MWHDgQ7P7oKE5HTx5SdSA4LrB7f2fRBo8Z94UH5988oTieYnOrcknMnUqHm+7bYzZeODReptrS8bzI6C3kDayVLywwGaLTCO1RFbcx6AVoBuyPimhCqK/i0rgSchsBIVyB2OAEwyhfx6A4KJtG3YhTU9Hpyb1IJBRKiiZ2o7qCDO57Y803mlGVJ4oPfBgJR5Q7V76Db45/iCkQxScu7+5JrJ3h4mK5PsZcBCJQ52huzHCKcrEsRns6UztbNwW7eGkFAuNlPPFccph18W4gt7cD2lvsGlTx3HhDfzcvxfsGs9HtjhXQ4mK3H1yMpPjns2vgR85R6AoVAnocnbiOZfKYbsI2eCzoihTGA7mNlEhkN6jul2sRC5txzDDZ8Q3iL+HNHXOrwGP/WbbwBPVQW7dbScJ6mEjftxw46pHXl0cYgmPXoXfmIruV2F7okZKEx7ysMymP3ZSwEspE9LSK0P+YRq4PiEKqsWtivJ5aHNF6XTVgD4aYtXoekr1w1X89 AaZ7Kh0t 3gSENk/gCGM3Supj0gwDRKrkMac949uRM5YUa6zcrhyFO5lGeLWLeZKlO4NJ3WxOCvPbBtrYvdM1lG7iM+Smg/tAbwFgapY5kJafHL7nvN1JKMiQbemxXqxfhoZlx0TAc9ihZeg1PRY4E02CtR+RRXndLbE33LWuc2A99CN3uO86dMIBLqo7/rsfy+l18oortDIFsrZa61vxz9F8HH8tol0hxALXNq06cEfxkf67nmauH9zK7JUVa2jQ8XDOVs5bts/aJh3YpnyXAtIRI3028JXa2MrNweTv/my9lLgXsLnw08GBJDEfN5BlWj0Yo3pO5s3PzO0fNYPzYe/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 25 Aug 2024 20:27:45 -0700, Max Filippov wrote: > create_elf_fdpic_tables() does not correctly account the space for the > AUX vector when an architecture has ELF_HWCAP2 defined. Prior to the > commit 10e29251be0e ("binfmt_elf_fdpic: fix /proc//auxv") it > resulted in the last entry of the AUX vector being set to zero, but with > that change it results in a kernel BUG. > > Fix that by adding one to the number of AUXV entries (nitems) when > ELF_HWCAP2 is defined. > > [...] Applied to for-linus/execve, thanks! [1/1] binfmt_elf_fdpic: fix AUXV size calculation when ELF_HWCAP2 is defined https://git.kernel.org/kees/c/c6a09e342f8e Take care, -- Kees Cook