From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93211C3DA4A for ; Tue, 20 Aug 2024 06:33:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7A4D6B0083; Tue, 20 Aug 2024 02:33:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2BB46B0085; Tue, 20 Aug 2024 02:33:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF2B16B0088; Tue, 20 Aug 2024 02:33:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A08C16B0083 for ; Tue, 20 Aug 2024 02:33:04 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 116B61C56BF for ; Tue, 20 Aug 2024 06:33:04 +0000 (UTC) X-FDA: 82471656288.17.6997E7B Received: from h3cspam02-ex.h3c.com (smtp.h3c.com [60.191.123.50]) by imf04.hostedemail.com (Postfix) with ESMTP id 0EDA440003 for ; Tue, 20 Aug 2024 06:32:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of zhang.chunA@h3c.com designates 60.191.123.50 as permitted sender) smtp.mailfrom=zhang.chunA@h3c.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724135520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p2deglhnfRz2jRZAQ/kjRc+dP9tXxkDWXBYoh2w0d/k=; b=0HxYSuOe3Pah+lBn1L3dSFHzxmY6VR385nbW/SpT8V9HwtpkzgJ1QVaSPzeYjnfCtzU69S 4bXdXCUwrT8dOTE9jvm1Yf6zXHGRG2Jz0jEm1rwmfJYCvHjV1zdec8ii5MtaWe22lOwH2a 2oH1NAZcByC5TpwQwpDU+D3RgjH7MG4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of zhang.chunA@h3c.com designates 60.191.123.50 as permitted sender) smtp.mailfrom=zhang.chunA@h3c.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724135520; a=rsa-sha256; cv=none; b=ygeq7Ef/S8VIQtR+BTo9XAWD0w6QQfuQXTWRcySfpNDS7Y2apOhWbLLLPyn+YOh2dO5f51 NXleQVf6U0GKb7B/gQelqjYL3toEHgNb5foXox3xDxtxiRkm3yxK4+8qUSQM3q40mlC4MM 7idQVWoDaj+zkkKUfwuEPXpHFyyC/to= Received: from mail.maildlp.com ([172.25.15.154]) by h3cspam02-ex.h3c.com with ESMTP id 47K6Vg7J031506; Tue, 20 Aug 2024 14:31:42 +0800 (GMT-8) (envelope-from zhang.chunA@h3c.com) Received: from DAG6EX09-BJD.srv.huawei-3com.com (unknown [10.153.34.11]) by mail.maildlp.com (Postfix) with ESMTP id BAEDC2004C4C; Tue, 20 Aug 2024 14:36:54 +0800 (CST) Received: from localhost.localdomain.com (10.99.206.13) by DAG6EX09-BJD.srv.huawei-3com.com (10.153.34.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.27; Tue, 20 Aug 2024 14:31:44 +0800 From: zhangchun To: CC: , , , , , Subject: [PATCH] use might_sleep check if kmap_high is called from atomic context Date: Tue, 20 Aug 2024 14:33:20 +0800 Message-ID: <1724135600-42498-1-git-send-email-zhang.chuna@h3c.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.99.206.13] X-ClientProxiedBy: BJSMTP01-EX.srv.huawei-3com.com (10.63.20.132) To DAG6EX09-BJD.srv.huawei-3com.com (10.153.34.11) X-DNSRBL: X-MAIL:h3cspam02-ex.h3c.com 47K6Vg7J031506 X-Stat-Signature: hojz17mqtdaz8asibwyu9dy3dnybb9hq X-Rspam-User: X-Rspamd-Queue-Id: 0EDA440003 X-Rspamd-Server: rspam02 X-HE-Tag: 1724135578-244402 X-HE-Meta: U2FsdGVkX1/HpbS+ib5sqSQOMgasEfQAlAv0zPxZJH/jspHPDGQibAhiokGHg4/7H2Yeer9CeTWi6xxgvcE6HBZWCjyiSRbONCB9olfDJpXCvxmDi0lhR66HIoirGOZeiu/AOqxVpx8qRmGPKUJx0qVMrFueHu70m8D42pAFsUG/684qiF/a7ILBjoNG0gPH7ZYhwEUr5eYci8AUAmZBDi1SSinGxwA0KioW99ECpKYt8BWTm4nXoClkuSwOZiv7uMJu+lIHsXqmqAsIs0wOPU4sNsY+HF88IppCkOC3fHo/MsFHB3l3JwPCoVovcyWaXD90HsycubMfpop3/Qf1D5kjDOxY1GMk9LB6LLKP0cNd8+sfBvRoe3irWQzr0l9ICTX04toGoqoE+mQrHgbHVd79XEwEaB98bfwMEl0R/d2HtSnbMRXcTWYEYXMOWuKp0qPkQsK+PvtBfvz38bRg1CjxmKzuTZfl3Gay7F8aG5N+QTFNGyTpVisM9apoMPG0hKu9Zf4t7Z9Gw0NaTGsg0vSK4o/tUzTxo2pW1D85uobzV+ljFr5Cz9iNldOTKM90VFz873//DYuAMVcjaq+YjdCcr79bvDfitgHcr+A+ZiXGc1/kBrSxP8H23m2pAh/q7eexyS6RaY7FAlW5z7BORUc0canG79zQYDk+nn8b6xeU5fWjwuAXZs4YD9ZDnfaXTTjUzcFQDbezVqqpcyg2Cuf+r/hNZBSF1k4Ph/+EdUyhuz1vBehP3wJuR61FqTREFQwrN3z6Dr82mDZklfKONad/npVckUXIIgsp+XFIpoUK81qkKJijGfiCfG2uaQxB1VG8+wF5OLQorJda+y0UJSugTD/M9Z7s3sO4lET9ndFW1Wl9p6ewOgU8IvEPMTr3iB72zf527PBqOk6wOYNQE4/uUI8J3tcwOWqVtv8GVkFFjUob3hcHABBDRgW9lBt7T+KeoXGMLPnl+W2TUry h6M2a0Os Q0nn2h//hJK4FTKpOuce25awZ5acIm2zaNljAPXBAJ5o+nWn2AjlRVIyjov0iQdCZpEvwpUMhqmAIKJXdRSKJj/2ykLCLz5SDDCsCqgeEGHZ8QzBnihP6WSr0WNsP28OCHOkpSnwOxRs4WXZMlXmscPS6P9NZiSSIV900SBsWlOKgdvM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >On Tue, Aug 20, 2024 at 09:53:11AM +0800, zhangchun wrote: >> kmap_high is defined as EXPORT_SYMBOL, and cannot be called from >> atomic context. Add might_sleep check is necessary. >No. Nobody should be calling kmap_high() directly. There's already a >might_sleep() in kmap(). No need to add one in kmap_high(). To avoid anyone calls kmap_high directly, add function description "Don't use kmap_high directly, if necessary, please use kmap" Signed-off-by: zhangchun -- 1.8.3.1